Mahara

Embedded PDFs not shown in HTML export

Bug #1698699 reported by Kristina Hoeppner
18
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 19.10.0
18.04
Fix Released
Medium
Unassigned
Mahara 18.04.5
18.10
Fix Released
Medium
Unassigned
Mahara 18.10.2
19.04
Fix Released
Medium
Unassigned
Mahara 19.04.1
19.10
Fix Released
Medium
Unassigned
Mahara 19.10.0

Bug Description

https://mahara.org/interaction/forum/topic.php?id=7904

Embedded PDFs aren't show in the HTML report.

Comment from Jono on this issue:

https://bugs.launchpad.net/mahara/+bug/1279841/comments/1

The iframe that holds the PDF still uses the mahara installation as the source URL, and iframes from external sources seem to be disabled in modern browsers if you've opened the HTML file locally (ie. you're using a file:// URL)

Tags: export
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9960

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: d094f841794de2bf137a031fa44845c0a3441df2
Environment tested: Master
Browser tested: Chrome
Theme used: Primary school

PRECONDITIONS:
------------------------
1) Mahara user exists
2) portfolio page exist as follows
     a) has a pdf block with pfd

TEST STEPS:
------------------------
1) Log in as Mahara user
2) Create an HTML export of the portfolio page with a pdf block
3) save the file locally and extract the zip file
4) Open the index.html file in a browser
5) Verify that the PDF is displayed ✔

Catalyst QA Approved ✔

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
milestone: none → 19.10.0
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9960
Committed: https://git.mahara.org/mahara/mahara/commit/d094f841794de2bf137a031fa44845c0a3441df2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit d094f841794de2bf137a031fa44845c0a3441df2
Author: Robert Lyon <email address hidden>
Date: Mon May 6 14:00:40 2019 +1200

Bug 1698699: Rewrite path to PDF in HTML export

This patch rewrites the path to the html export version of the PDF file

behatnotneeded

Change-Id: I8d534af41258d219046e5f3586bf904777242cb9
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10002

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10002
Committed: https://git.mahara.org/mahara/mahara/commit/9b29d17eab9bb07240300c380d37ae63849d2e16
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 9b29d17eab9bb07240300c380d37ae63849d2e16
Author: Robert Lyon <email address hidden>
Date: Mon May 6 14:00:40 2019 +1200

Bug 1698699: Rewrite path to PDF in HTML export

This patch rewrites the path to the html export version of the PDF file

behatnotneeded

Change-Id: I8d534af41258d219046e5f3586bf904777242cb9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d094f841794de2bf137a031fa44845c0a3441df2)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10003

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10003
Committed: https://git.mahara.org/mahara/mahara/commit/bd2c77dfec2dfd937f15fbb0782ec69fa791283d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit bd2c77dfec2dfd937f15fbb0782ec69fa791283d
Author: Robert Lyon <email address hidden>
Date: Mon May 6 14:00:40 2019 +1200

Bug 1698699: Rewrite path to PDF in HTML export

This patch rewrites the path to the html export version of the PDF file

behatnotneeded

Change-Id: I8d534af41258d219046e5f3586bf904777242cb9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d094f841794de2bf137a031fa44845c0a3441df2)
(cherry picked from commit 9b29d17eab9bb07240300c380d37ae63849d2e16)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10004

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10004
Committed: https://git.mahara.org/mahara/mahara/commit/639f0a42399554fcc4649f630c1adb5b4ef3e314
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 639f0a42399554fcc4649f630c1adb5b4ef3e314
Author: Robert Lyon <email address hidden>
Date: Mon May 6 14:00:40 2019 +1200

Bug 1698699: Rewrite path to PDF in HTML export

This patch rewrites the path to the html export version of the PDF file

behatnotneeded

Change-Id: I8d534af41258d219046e5f3586bf904777242cb9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d094f841794de2bf137a031fa44845c0a3441df2)
(cherry picked from commit 9b29d17eab9bb07240300c380d37ae63849d2e16)
(cherry picked from commit bd2c77dfec2dfd937f15fbb0782ec69fa791283d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10065

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.