Tagged journal entries block combines tags

Bug #1700690 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic
17.04
Fix Released
Medium
Unassigned
17.10
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

When the "Tagged journal entries" block has 2 or more tags, the tags are combined into one element rather than kept separate when a new entry is created from within the block.

To reproduce:

1. Set up a journal entry with 2 tags
2. Add the "Tagged journal entries" block to a page and select the two tags.
3. Click the "New entry" button in the block to create a new journal entry. In Mahara 17.04 and 17.10, this button doesn't actually do anything. Related bug is bug #1700689
4. The tags are added automatically to the new entry.

Expected result: Both tags are separate entities.
Actual result: The tags are combined to 1 entity and separated by comma within that entity essentially creating a new tag. Therefore, the entry doesn't show up in the tagged journal entries block.

Also test that "-tags" are dealt with correctly and left off.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Medium priority as there is the work around to delete the tags on the journal entry and put the correct ones in.

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
no longer affects: mahara/17.04
Changed in mahara:
milestone: 17.10.0 → 17.04.3
milestone: 17.04.3 → 17.10.0
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7846

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7846
Committed: https://git.mahara.org/mahara/mahara/commit/0967a0389d46924e97acff76adf5beb2b7445825
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0967a0389d46924e97acff76adf5beb2b7445825
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 30 17:10:20 2017 +1200

Bug 1700690: Separate tags when posting from a tagged entries block

behatnotneeded

Change-Id: Id40eccb3c10c654ef807c35e0e7c480a199b9caf

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7860

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7860
Committed: https://git.mahara.org/mahara/mahara/commit/98b3924d08ae2e1b8888cce7bec1b46fc7bdd58f
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 98b3924d08ae2e1b8888cce7bec1b46fc7bdd58f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 30 17:10:20 2017 +1200

Bug 1700690: Separate tags when posting from a tagged entries block

behatnotneeded

Change-Id: Id40eccb3c10c654ef807c35e0e7c480a199b9caf
(cherry picked from commit 0967a0389d46924e97acff76adf5beb2b7445825)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.