Confusing date of shared pages/collections

Bug #1701437 reported by Dmitrii Metelkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

Version of Mahara: 16.10.2

When you are on "Shared with me" screen /view/sharedviews.php you see a list of shared pages and collections e.g.

Sidney Crosby Pesonal Portfolio (15 pages)
Sidney Crosby - 28 Jan 2017, 14:37

It looks like the date is a date when a user shared it with you. But actually it's a date when the first item in the collection was updated (if it's a collection).

Expected: date should be a date of sharing or it should be clear that this date is when a collection was updated.

A side effect of discovering of this bug is that when you share collection with a group it triggers event and save DB record like:

 53773 | 53773 | 2017-06-29 20:40:06 | saveview | {"id":"14925"}

But view hasn't been updated as we have changed collection access rule.

Tags: catathon
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I would keep it as the date the collection as last updated as that is more important to know when the last change was made rather than when it was shared. So it could just get an "Updated" as elsewhere on Mahara.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 17.10.0
tags: added: bite-sized
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Can you please report the group bug separately with a bit more information?

Revision history for this message
Dmitrii Metelkin (dmitriim) wrote :

What about have two dates?

Updated: ....
Shared: ...

I have created a new bug related to event triggering https://bugs.launchpad.net/mahara/+bug/1702374

tags: added: catathon
removed: bite-sized
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7854

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7854
Committed: https://git.mahara.org/mahara/mahara/commit/7146fcb9a577bb0525b928ee905a89e268c347dc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7146fcb9a577bb0525b928ee905a89e268c347dc
Author: Jack Gilmour <email address hidden>
Date: Fri Jul 7 14:45:37 2017 +1200

Bug 1701437: Add "Update" string to date on "Shared with me"

To make it clear that the date shown on a portfolio
is the created / update date and not the date when
a portfolio was shared.

behatnotneeded

Change-Id: Id273fae814dc27e03f5294b32425fa78a9b74dc9

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8094
Committed: https://git.mahara.org/mahara/mahara/commit/70ac7cec17e778da31d928ea37a7e2c7de13459f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 70ac7cec17e778da31d928ea37a7e2c7de13459f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 5 17:06:05 2017 +1300

Bug 1720269: old_raw patches for bugs: (General)

Bug 1720264
Bug 1720235
Bug 1719736
Bug 1718821
Bug 1705126
Bug 1694908
Bug 1690687
Bug 1690232
Bug 1686843
Bug 1685041
Bug 1683561
Bug 1681987
Bug 1681934
Bug 1675223
Bug 1636064
Bug 1575512
Bug 1369569
Bug 692769

Also fixing up un-closed html tags in Bug 1701437 for raw and old raw

behatnotneeded

Change-Id: I8ac930ceebf78b4edad97289994318e7689a1e94

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8116

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8116
Committed: https://git.mahara.org/mahara/mahara/commit/a25f4f11d35bf17d54acfb8010cd29e432fc86ea
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit a25f4f11d35bf17d54acfb8010cd29e432fc86ea
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 5 17:06:05 2017 +1300

Bug 1720269: old_raw patches for bugs: (General)

Bug 1720264
Bug 1720235
Bug 1719736
Bug 1718821
Bug 1705126
Bug 1694908
Bug 1690687
Bug 1690232
Bug 1686843
Bug 1685041
Bug 1683561
Bug 1681987
Bug 1681934
Bug 1675223
Bug 1636064
Bug 1575512
Bug 1369569
Bug 692769

Also fixing up un-closed html tags in Bug 1701437 for raw and old raw

behatnotneeded

Change-Id: I8ac930ceebf78b4edad97289994318e7689a1e94
(cherry picked from commit 70ac7cec17e778da31d928ea37a7e2c7de13459f)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.