Mahara

Masquerading sessions show deleted users

Bug #1703465 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic
Mahara 18.04.0
17.10
Fix Released
Medium
Unassigned
Mahara 17.10.1

Bug Description

when you select people to report over for masquerading sessions, people who have been deleted show up if the person you are reporting over is an admin as the masquerading sessions display both who you has masqueraded and who is being masqueraded.

Thus, if users were deleted from the system, but you are reporting over the site admin who masqueraded as them before the deletion, the deleted user data shows up, i.e. the "Deleted user (pitpalmer.deleted.1459025466.5...)" and the masquerading reason, admin and time.

Since the users are deleted, that data should not be displayed anymore.

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8286

Revision history for this message
Robert Lyon (robertl-9) wrote :

Hmm, on one hand as the data is for a time period then that user did exists and was masqueraded during that time.

But on the other hand once a user is deleted they don't exist anymore it make sense to hide them

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8286
Committed: https://git.mahara.org/mahara/mahara/commit/f8d819d76194eb112c9abe2048bbe380b800cfa7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f8d819d76194eb112c9abe2048bbe380b800cfa7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 17 13:53:43 2017 +1300

Bug 1703465: filter deleted user from masquerading report

behatnotneeded

Change-Id: I12f79b49900f3a509de1ccf3e7776160ac7a8b00

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 18.04.0
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8288

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8288
Committed: https://git.mahara.org/mahara/mahara/commit/cd69e51825046dd1b832ce25233d3a5063b7fe0c
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit cd69e51825046dd1b832ce25233d3a5063b7fe0c
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 17 13:53:43 2017 +1300

Bug 1703465: filter deleted user from masquerading report

behatnotneeded

Change-Id: I12f79b49900f3a509de1ccf3e7776160ac7a8b00
(cherry picked from commit f8d819d76194eb112c9abe2048bbe380b800cfa7)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.