Ubuntu
flashcache package

flashcache 3.1.3+git20150701-5 ADT test failure with linux 4.13.0-2.3

Bug #1706426 reported by Seth Forshee on 2017-07-25

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	flashcache (Ubuntu)	Fix Released	High	Stefan Bader
	Xenial	Fix Released	Medium	Stefan Bader

Bug Description

SRU Justification (Xenial):

Impact: Due to upstream changes the flashcache version in Xenial will not build the flashcache module for kernel version 4.13 or later. 4.13 will becom the hwe-edge/hwe kernel at some point.

Fix: Cherry-pick compat-4.13 patch from the Artful package into Xenial.

Testcase:
- dkms build of flashcache module for 4.4 and 4.8 or 4.10
- quick functional test as described in bug #1714185

---

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-bootstrap/artful/amd64/f/flashcache/20170725_182120_fab5e@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-bootstrap/artful/i386/f/flashcache/20170725_185202_fab5e@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-bootstrap/artful/ppc64el/f/flashcache/20170725_155148_fab5e@/log.gz

See original description

Tags:

Revision history for this message

Seth Forshee (sforshee) wrote on 2017-07-25:

make.log Edit (1.3 KiB, text/plain)

tags:

added: kernel-adt-failure

Stefan Bader (smb) on 2017-08-31

Changed in flashcache (Ubuntu):
assignee:	nobody → Stefan Bader (smb)
importance:	Undecided → High
status:	New → Confirmed

Revision history for this message

Stefan Bader (smb) wrote on 2017-08-31:

compat-4.13.patch Edit (772 bytes, text/plain)

Upstream changed the bio structure (once again) and replaced "int bi_error" by "blk_status_t bi_status". I believe I can leave all flashcache internal handling use int type error values and just convert the one place where this is passed on into a bio structure.

Ubuntu Foundations Team Bug Bot (crichton) on 2017-08-31

tags:

added: patch

Stefan Bader (smb) on 2017-08-31

Changed in flashcache (Ubuntu):
status:	Confirmed → In Progress

Stefan Bader (smb) on 2017-08-31

description:	updated
Changed in flashcache (Ubuntu Xenial):
assignee:	nobody → Stefan Bader (smb)
importance:	Undecided → Medium
status:	New → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-08-31:

This bug was fixed in the package flashcache - 3.1.3+git20150701-5ubuntu1

---------------
flashcache (3.1.3+git20150701-5ubuntu1) artful; urgency=medium

* Initialize bi_op_flags in dm_io_request structures (LP: #1714185).
* Fix DKMS compile for 4.13+ kernels (LP: #1706426).

-- Stefan Bader <email address hidden> Wed, 30 Aug 2017 16:49:59 +0200

Changed in flashcache (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2017-09-11: Please test proposed package

Hello Seth, or anyone else affected,

Accepted flashcache into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/flashcache/3.1.3+git20150701-2ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in flashcache (Ubuntu Xenial):
status:	In Progress → Fix Committed
tags:	added: verification-needed verification-needed-xenial

Revision history for this message

Stefan Bader (smb) wrote on 2017-09-14:

With proposed enabled on a Xenial base VM:

~$ dpkg -l|grep flashcache
ii flashcache-dkms 3.1.3+git20150701-2ubuntu3 all write-back block device cache for Linux (DKMS version)
ii flashcache-utils 3.1.3+git20150701-2ubuntu3 amd64 write-back block device cache for Linux (user space utilities)

~$ dkms status
flashcache, 3.1.3+git20150701, 4.10.0-35-generic, x86_64: installed
flashcache, 3.1.3+git20150701, 4.13.0-11-generic, x86_64: installed
flashcache, 3.1.3+git20150701, 4.4.0-96-generic, x86_64: installed

tags:

added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-09-20:

This bug was fixed in the package flashcache - 3.1.3+git20150701-2ubuntu3

---------------
flashcache (3.1.3+git20150701-2ubuntu3) xenial; urgency=medium

  * Backport compat code for kernel 4.8 (LP: #1662108)
  * Initialize bi_op_flags in dm_io_request structures (LP: #1714185)
  * Fix DKMS compile for 4.13+ kernels (LP: #1706426)

-- Stefan Bader <email address hidden> Mon, 06 Feb 2017 17:25:15 +0100

Changed in flashcache (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Revision history for this message

Chris J Arges (arges) wrote on 2017-09-20: Update Released

The verification of the Stable Release Update for flashcache has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.