Mahara

broken js when using pagination in a list of radio buttons

Bug #1710988 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
Mahara 17.10.0
17.04
Fix Released
High
Cecilia Vela Gurovic
Mahara 17.04.3
17.10
Fix Released
High
Cecilia Vela Gurovic
Mahara 17.10.0

Bug Description

affects 17.04 and master

Cases where the js is broken:

1. Notes: When setting the content of a note with the 'Use content from another note' button

Steps to reproduce:

- Edit a page
- add a note to it with text 'Test' and save
- add another note to the page
- in the configuration, press 'Use content from another note'
- Select the note with text 'Test' and save

Result expected: We have two notes with text 'Test' in the page
Actual result: We have two empty notes in the page

2. In the personal email inbox:

- have more than 10 unread messages in the inbox
- go to a page different than the first one
- Select an unread message, choosing 'Mark as read' from the Bulk options at the top

Expected result: show the message as read automatically
Actual result: will not show the message as read automatically. We need to refresh the page to see it.

- have more that 10 messages
- go to a different page than the first one
- Select one message and choose 'delete' in the Bulk options at the top.

Expected result: The messages we want to delete are removed from the list
Actual result: All messages will disappear and we have to refresh the page to see the changes.

3. In outbox (messages Sent)
Same as inbox for deleting a message

See original description
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
no longer affects: mahara/trunk
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7934

Cecilia Vela Gurovic (ceciliavg)
summary: - using content from a note removes the content on original note
+ broken js when using pagination in a list of radio buttons
Cecilia Vela Gurovic (ceciliavg)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7936

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7934
Committed: https://git.mahara.org/mahara/mahara/commit/e7ed751fa4924e761a9d7f5c39084ea521fd8836
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e7ed751fa4924e761a9d7f5c39084ea521fd8836
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 17 09:10:00 2017 +1200

Bug 1710988: fix js when catching 'pagechanged' event

Fix for broken function calls when selecting a
radio button in a list of notes, deleting and
marking as read messages in the inbox/outbox

Change-Id: Ia5f4b2a1f977d319ccd813a2499b29c98b15f6a0
behatnotneeded: adding a behat test later

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7974

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7974
Committed: https://git.mahara.org/mahara/mahara/commit/fb7cca51283a332d851109776d1eb8c7b1a99414
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit fb7cca51283a332d851109776d1eb8c7b1a99414
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 17 09:10:00 2017 +1200

Bug 1710988: fix js when catching 'pagechanged' event

Fix for broken function calls when selecting a
radio button in a list of notes, deleting and
marking as read messages in the inbox/outbox

Change-Id: Ia5f4b2a1f977d319ccd813a2499b29c98b15f6a0
behatnotneeded: adding a behat test later
(cherry picked from commit e7ed751fa4924e761a9d7f5c39084ea521fd8836)

Revision history for this message
Niranjan (niranjan528) wrote :

Here are the detailed test cases for this bug,

URL: https://bugs.launchpad.net/mahara/+bug/1710988

Scenario 1:

Bug Description: Empty notes are displayed in the page when setting the content of a note with 'Use content from another note' button.

Environment to be tested: Master branch
Browser Testing: Firefox, Chrome, Safari, IE ( latest Version)

Steps to reproduce:

Precondition: User should have existing pages.

1. Navigate to Main Menu > Portfolio > Pages and collections.

2. Click on ‘Edit’ for an existing page.

3. Click on ‘General’ to expand on the left hand side of the page.

4. Click on ‘Note’.

5. Click the ‘Add’ button.

6. Enter ‘Test into the ‘block content’ and click the ‘Save’ button.

7. Now again click on ‘Note’.

8. Click the ‘Add’ button.

9. Click on ‘Use content from another note’.

10. Choose the Radio button with the description as 'Test'

11. Click the ‘Save’ button.

Expected result: Each Note description should be displayed with the text ‘Test’ on the page.
Actual Result: Each Note description is displayed with the text 'Test'.

Scenario 2:

Bug Description: Choosing mark as read or deleting the messages from the Inbox doesn't show up unless the page is refreshed.

Environment to be tested: Master branch
Browser Testing: Firefox, Chrome, Safari, IE ( latest Version)

Steps to Reproduce:

Precondition: Personal email Inbox and outbox( sent)should have more than 10 unread messages each.

1. Navigate to 'User menu' and select the ‘Inbox’.

2. Click on ‘Second page’.

3. Select one of the unread message.

4. Now click on 'Bulk Actions' drop down and select ‘Mark as read’.

Expected Result: The unread message should be displayed as read.
Actual Result: The unread message is displayed as read.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7936
Committed: https://git.mahara.org/mahara/mahara/commit/4c54d9d7bcfd2a1099ea4f3a51c44c9604de8762
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4c54d9d7bcfd2a1099ea4f3a51c44c9604de8762
Author: Rebecca Blundell <email address hidden>
Date: Thu Aug 17 17:57:26 2017 +1200

Bug 1710988 - add behat test for broken js in note copy

The following changes are done
Rename user_content/add_note_block.feature to note_block.feature
-Fix the formatting issues with partial tests in background.
-Copy the content of blocktype/copy_note_content.feature to note_block.feature and delete the original

Change-Id: I9e5744d94bfed7470983d373cd1bfe8699661500

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8174

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8174
Committed: https://git.mahara.org/mahara/mahara/commit/24d24c8745bd94ded9fd123970c67692a2d48d09
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 24d24c8745bd94ded9fd123970c67692a2d48d09
Author: Rebecca Blundell <email address hidden>
Date: Thu Aug 17 17:57:26 2017 +1200

Bug 1710988 - add behat test for broken js in note copy

The following changes are done
Rename user_content/add_note_block.feature to note_block.feature
-Fix the formatting issues with partial tests in background.
-Copy the content of blocktype/copy_note_content.feature to note_block.feature and delete the original

Change-Id: I9e5744d94bfed7470983d373cd1bfe8699661500
(cherry picked from commit 4c54d9d7bcfd2a1099ea4f3a51c44c9604de8762)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.