FTBFS in Artful

Bug #1715167 reported by Balint Reczey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nagios-nrpe (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

3.2.0-4ubuntu1 FTBFS in Artful:

https://launchpadlibrarian.net/332819056/buildlog_ubuntu-artful-amd64.nagios-nrpe_3.2.0-4ubuntu1_BUILDING.txt.gz :
...
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/openssl -DHAVE_CONFIG_H -I ../include -I ./../include -o check_nrpe ./check_nrpe.c ./utils.c -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -L/usr/lib/x86_64-linux-gnu -lssl -lcrypto -lnsl
In file included from ./nrpe.c:45:0:
./../include/dh.h: In function ‘get_dh2048’:
./../include/dh.h:46:17: warning: implicit declaration of function ‘DH_set0_pqg’ [-Wimplicit-function-declaration]
             || !DH_set0_pqg(dh, dhp_bn, NULL, dhg_bn)) {
                 ^~~~~~~~~~~
./nrpe.c: In function ‘read_config_dir’:
./nrpe.c:1062:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 254 [-Wformat-truncation=]
   snprintf(config_file, sizeof(config_file) - 1, "%s/%s", dirname, dirfile->d_name);
                                                      ^~
In file included from /usr/include/stdio.h:938:0,
                 from ../include/config.h:31,
                 from ./nrpe.c:37:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output 2 or more bytes (assuming 257) into a destination of size 255
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/ccJ0F0xi.o: In function `get_dh2048':
./src/./../include/dh.h:46: undefined reference to `DH_set0_pqg'
collect2: error: ld returned 1 exit status
Makefile:48: recipe for target 'nrpe' failed
make[3]: *** [nrpe] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
Makefile:65: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j4 all returned exit code 2
...

Tags: ftbfs
Balint Reczey (rbalint)
Changed in nagios-nrpe (Ubuntu):
assignee: nobody → Balint Reczey (rbalint)
status: New → In Progress
Revision history for this message
Balint Reczey (rbalint) wrote :
Changed in nagios-nrpe (Ubuntu):
assignee: Balint Reczey (rbalint) → nobody
status: In Progress → Confirmed
Revision history for this message
Bas Couwenberg (sebastic) wrote :

Don't disable 11_reproducible_dh.h.patch, regenerate the dh.h with the openssl version in the distribution instead:

 quilt push 11_reproducible_dh.h.patch
 openssl dhparam -C 2048 | awk '/^-----/ {exit} {print}' > include/dh.h
 quilt refresh

Balint Reczey (rbalint)
Changed in nagios-nrpe (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Balint Reczey (rbalint) wrote :
Changed in nagios-nrpe (Ubuntu):
status: In Progress → Confirmed
Revision history for this message
Balint Reczey (rbalint) wrote :

Since shipping reproducible packages is not a release goal for Artful AFAIK, delaying fixing an FTBFS to make the package reproducible does not seem to be the best idea during freeze.

In the first approach i deliberately chose the smaller delta from upstream by disabling the patch, but I'm also OK with the second approach.

Revision history for this message
Balint Reczey (rbalint) wrote :

@sebastic but thank you for the feedback, I regenerated the patch easily for Ubuntu's current libssl.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nagios-nrpe - 3.2.0-4ubuntu2

---------------
nagios-nrpe (3.2.0-4ubuntu2) artful; urgency=medium

  * Update 11_reproducible_dh.h.patch to build with libssl 1.0.x
    (LP: #1715167)

 -- Balint Reczey <email address hidden> Tue, 05 Sep 2017 14:26:58 +0000

Changed in nagios-nrpe (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.