Upgrade from 15.04 -> 17.10 fails on logoxs not found

Patch for "master" branch: https://reviews.mahara.org/8016

Reviewed: https://reviews.mahara.org/8016
Committed: https://git.mahara.org/mahara/mahara/commit/589e4aebe45f6820b24487d142b21a9ddddab329
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 589e4aebe45f6820b24487d142b21a9ddddab329
Author: Robert Lyon <email address hidden>
Date: Fri Sep 15 10:07:57 2017 +1200

Bug 1717371: Upgrade fails from 15.04

Due to missing column 'logoxs' as this column has not been added yet

behatnotneeded

Change-Id: Ie744485923c1566f10081ab98f16a1e2b08baf5a
Signed-off-by: Robert Lyon <email address hidden>

This still fails for me when going from 15.10.2 to 17.10.0

mafen

Are you able to add in the log error here?

I tried upgrading a site from 15.10.2 -> 17.10.0 and had no issue.

So I'm wondering what might be causing your problem so I can get it fixed

Cheers
Robert

Hello Robert,

i just did a fresh restore of our 15.10.2 instance and tried to upgrade to 17.10.0

This is the whole log i get (referer changed):

[DBG] 39 (lib/db/upgrade.php:4213) Upgrade comment plugin for threaded comments, referer: https://xyz.com
[DBG] 39 (artefact/comment/db/upgrade.php:140) Adding "hidden" column to artefact_comment_comment, referer: https://xyz.com
[DBG] 39 (artefact/comment/db/upgrade.php:150) Checking for existing deleted comments that should now be hidden, referer: https://xyz.com
[DBG] 39 (lib/db/upgrade.php:4220) Expanding the size of the activity_queue.data column, referer: https://xyz.com
[DBG] 39 (lib/db/upgrade.php:4229) Upgrade wall block and add wall notifications to default inbox block, referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1054: Unknown column 'i.logoxs' in 'field list'] in EXECUTE(", referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) SELECT u.institution,IF(ctime >= '1970-01-01', UNIX_TIMESTAMP(ctime), TIMESTAMPDIFF(SECOND, '1970-01-01', ctime)) AS ctime,IF(u.expiry >= '1970-01-01', UNIX_TIMESTAMP(u.expiry), TIMESTAMPDIFF(SECOND, '1970-01-01', u.expiry)) AS membership_expiry,u.studentid,u.staff,u.admin,i.displayname,i.theme,i.registerallowed, i.showonlineusers,i.allowinstitutionpublicviews, i.logo, i.logoxs, i.style, i.licensemandatory, i.licensedefault, i.dropdownmenu, i.skins, i.suspended, referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) FROM "usr_institution" u INNER JOIN "institution" i ON u.institution = i.name, referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) WHERE u.usr = 60 ORDER BY i.priority DESC")Command was: , referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) SELECT u.institution,IF(ctime >= '1970-01-01', UNIX_TIMESTAMP(ctime), TIMESTAMPDIFF(SECOND, '1970-01-01', ctime)) AS ctime,IF(u.expiry >= '1970-01-01', UNIX_TIMESTAMP(u.expiry), TIMESTAMPDIFF(SECOND, '1970-01-01', u.expiry)) AS membership_expiry,u.studentid,u.staff,u.admin,i.displayname,i.theme,i.registerallowed, i.showonlineusers,i.allowinstitutionpublicviews, i.logo, i.logoxs, i.style, i.licensemandatory, i.licensedefault, i.dropdownmenu, i.skins, i.suspended, referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) FROM "usr_institution" u INNER JOIN "institution" i ON u.institution = i.name, referer: https://xyz.com
[WAR] 39 (lib/errors.php:859) WHERE u.usr = ? ORDER BY i.priority DESC and values was (0:60), referer: https://xyz.com
Call stack (most recent first):, referer: https://xyz.com
  * log_message("Failed to get a recordset: mysqli error: [1054: Un...", 8, true, true) at /var/www/html/maharatest/lib/errors.php:95, referer: https://xyz.com
  * log_warn("Failed to get a recordset: mysqli error: [1054: Un...") at /var/www/html/maharatest/lib/errors.php:859, referer: https://xyz.com
  * SQLException->__construct("Failed to get a recordset: mysqli error: [1054: Un...") at /var/www/html/maharatest/lib/dml.php:517, referer: https://xyz.com
  * get_recordset_sql(", referer: https://xyz.com
        SELECT u.institution,IF(ctime >= '1970-01...", array(size 1), "", "") at /var/www/html/maharatest/lib/dml.php:697...

As the error mentioned by mafen is related to this bug but is slightly different.
It is caused by the upgrading of the wallpost block data so I'll make a new bug report to deal with this issue.

The new bug 1728815 is now made for this