Mahara

Webservice connection manager not showing 'add connection' form if no connection instances exist but a plugin has 'define_webservice_connections' function set

Bug #1724704 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 17.10.0
17.04
Fix Released
High
Unassigned
Mahara 17.04.4
17.10
Fix Released
High
Robert Lyon
Mahara 17.10.0

Bug Description

To test this problem:

1) Edit a plugin file and add in the 'define_webservice_connections' function

eg edit artefact/file/lib.php and add in following function on line 28

    public static function define_webservice_connections() {
        return array(
            array('connection' => 'test',
                'name' => 'Test this',
                'notes' => 'Experimental plugin',
                'version' => get_field('artefact_installed', 'release', 'name', 'file'),
                'type' => WEBSERVICE_TYPE_REST,
                'isfatal' => false),
            );
    }

2) Go to webservice/admin/connections.php?i=mahara in your browser

Before patch:
You should see 'Connection objects' expandable section that is empty but no form to add a new one

After patch:
You should see a form to add a new one placed above the 'Connection objects' expandable section

Tags: regression
Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
milestone: none → 18.04.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 18.04.0 → 17.10.0
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9)
tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8159
Committed: https://git.mahara.org/mahara/mahara/commit/6aa412234dfb13ede969047712c55c5d3f5e16b6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6aa412234dfb13ede969047712c55c5d3f5e16b6
Author: Robert Lyon <email address hidden>
Date: Thu Oct 19 12:08:54 2017 +1300

Bug 1724704: The webservice connection manager 'Add' field missing

It only shows if there are existing connection objects

So will split out the add form from the objects list

behatnotneeded

Change-Id: Iec66f2a8a9bfb744b9673ee9a797246e1a59f420
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8186

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8186
Committed: https://git.mahara.org/mahara/mahara/commit/e1afbfa47a143657a7e332a7058903897fae2924
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit e1afbfa47a143657a7e332a7058903897fae2924
Author: Robert Lyon <email address hidden>
Date: Thu Oct 19 12:08:54 2017 +1300

Bug 1724704: The webservice connection manager 'Add' field missing

It only shows if there are existing connection objects

So will split out the add form from the objects list

behatnotneeded

Change-Id: Iec66f2a8a9bfb744b9673ee9a797246e1a59f420
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6aa412234dfb13ede969047712c55c5d3f5e16b6)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8187

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8187
Committed: https://git.mahara.org/mahara/mahara/commit/644b4f23f3bbd2c8751a49768e05fc4c25179fc7
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 644b4f23f3bbd2c8751a49768e05fc4c25179fc7
Author: Robert Lyon <email address hidden>
Date: Thu Oct 19 12:08:54 2017 +1300

Bug 1724704: The webservice connection manager 'Add' field missing

It only shows if there are existing connection objects

So will split out the add form from the objects list

behatnotneeded

Change-Id: Iec66f2a8a9bfb744b9673ee9a797246e1a59f420
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6aa412234dfb13ede969047712c55c5d3f5e16b6)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.