Artful: Fix FTBS on test-rebuild due to glibc changes

Bug #1724859 reported by Christian Ehrhardt 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
strongswan (Debian)
Fix Released
Unknown
strongswan (Ubuntu)
Fix Released
Undecided
Unassigned
Artful
Fix Released
High
Unassigned

Bug Description

[Impact]

 * FTBFS in Artful due to glibc changes

 * Fix is a backport from upstream

[Test Case]

 * build strongswan in artful

[Regression Potential]

 * fix is form upstream and "only" changing header include order to fixup
   the glibc change. The actual built content remains the same.

[Other Info]

 * n/a
----

On the test rebuild run [1] it was spotted that recently memcached does no more build [2].
This is due to glibc changing the headers too much.
It causes: error: ‘uintptr_t’ undeclared

There is a fix upstream which is trivial and easy to backport.
So this can easily be solved and I'll push an MP for review soon.

[1]: http://qa.ubuntuwire.org/ftbfs/rebuilds/test-rebuild-20170922-artful.html
[2]: https://launchpad.net/ubuntu/+archive/test-rebuild-20170922/+build/13486034/+files/buildlog_ubuntu-artful-amd64.strongswan_5.5.1-4ubuntu2_BUILDING.txt.gz

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Fix confirmed working in [1], now cleaning up branches for review.

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2999/+packages

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
Review complete - uploaded to Artful now.
BB is not open yet - please let me know if this raced with opening BB and the version used needs to change.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

While not yet needed in Debian (glibc version) I submitted the change, linking bug here.

Revision history for this message
Brian Murray (brian-murray) wrote :

Can this get fixed in Bionic?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Oh I see, this is one of the few where I uploaded (just) in time to Artful, but I think it was lost in the opening of Bionic as it was not yet from A-unaccepted to A-proposed.

Currently there is [1] in the Artful queue.

@Brian, lets sync on the right steps - I hope this is the right order then:
1. I upload 5.5.1-4ubuntu3 to B
2. someone cancels the 5.5.1-4ubuntu3 in A-unapproved
3. once 1. migrated and 2. is out of the queue I can upload an SRU (same content as we already had) as 5.5.1-4ubuntu2.1

I did #1, somebody with the permissions to do so please do #2 (I'll ask on #Ubuntu-release).

[1]: https://launchpadlibrarian.net/341672629/strongswan_5.5.1-4ubuntu3_source.changes

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Doko helped and cancelled the one in a-unapproved - thanks.
Now waiting for this to pass in Bionic which fights with the currently long queue for a while.

Changed in strongswan (Debian):
status: Unknown → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package strongswan - 5.5.1-4ubuntu3

---------------
strongswan (5.5.1-4ubuntu3) bionic; urgency=medium

  * Fix Artful FTBFS due to newer glibc (LP: #1724859)
    - d/p/utils-Include-stdint.h.patch: upstream fix for changed include
      files.

 -- Christian Ehrhardt <email address hidden> Thu, 19 Oct 2017 15:18:52 +0200

Changed in strongswan (Ubuntu):
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Done in Bionic, now uploading the same as SRU (but as 2.1) to Artful.

description: updated
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Built and uploaded to Artful-unapproved for SRU review.

Changed in strongswan (Ubuntu Artful):
status: New → In Progress
importance: Undecided → High
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello ChristianEhrhardt, or anyone else affected,

Accepted strongswan into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/strongswan/5.5.1-4ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in strongswan (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Build is fine now.
Did some basics install/upgrade tests but those went without an issue - expected given the change.
Also autopkgtests ran successful.

That said - verified

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Changed in strongswan (Debian):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package strongswan - 5.5.1-4ubuntu2.1

---------------
strongswan (5.5.1-4ubuntu2.1) artful; urgency=medium

  * Fix Artful FTBFS due to newer glibc (LP: #1724859)
    - d/p/utils-Include-stdint.h.patch: upstream fix for changed include
      files.

 -- Christian Ehrhardt <email address hidden> Thu, 19 Oct 2017 15:18:52 +0200

Changed in strongswan (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for strongswan has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.