Mahara

Internet explorer P&C 'show more' broken js

Bug #1735027 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
Mahara 18.04.0
17.10
Fix Released
High
Unassigned
Mahara 17.10.1
18.04
Fix Released
High
Cecilia Vela Gurovic
Mahara 18.04.0

Bug Description

When using Internet Explorer, if we have enough portfolios in the pages and collections screen, we will see the 'Show more' button, but it won't work when we click on it.

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → Confirmed
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 17.10.1
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8313

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8313
Committed: https://git.mahara.org/mahara/mahara/commit/1737f97955b09d0e84d57edb8b5065f49efe67c2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1737f97955b09d0e84d57edb8b5065f49efe67c2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Nov 29 13:59:01 2017 +1300

Bug 1735027: Work around for when inbuilt Number.isInteger is not defined, eg Internet Explorer 11

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger

behatnotneeded

Change-Id: I2c1b77676e603394ce1a12a88f5d763e40ad5826

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8321

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8321
Committed: https://git.mahara.org/mahara/mahara/commit/e624a075686b08f4a6b3a768b97cdddc6924a0fa
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit e624a075686b08f4a6b3a768b97cdddc6924a0fa
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Nov 29 13:59:01 2017 +1300

Bug 1735027: Work around for when inbuilt Number.isInteger is not defined, eg Internet Explorer 11

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger

behatnotneeded

Change-Id: I2c1b77676e603394ce1a12a88f5d763e40ad5826
(cherry picked from commit 1737f97955b09d0e84d57edb8b5065f49efe67c2)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.