Cannot Delete Recordset / Zone in ng_dns panels

Bug #1750384 reported by Graham Hayes
52
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Designate Dashboard
Status tracked in Rocky
Queens
Fix Released
Critical
Unassigned
Rocky
Fix Released
Critical
Unassigned
Ubuntu Cloud Archive
Invalid
Undecided
Unassigned
Queens
Fix Released
High
Unassigned
designate-dashboard (Ubuntu)
Invalid
Undecided
Unassigned
Bionic
Fix Released
High
Unassigned

Bug Description

[Impact]
When trying to delete a zone the following error appears in the JS console:

    3bf910c7ae4c.js:1336 TypeError: Cannot set property 'labels' of undefined
        at Object.perform (155a6dc00894.js:1273)
        at Scope.genPassThroughCallback [as callback] (155a6dc00894.js:421)
        at fn (eval at compile (3bf910c7ae4c.js:1398), <anonymous>:4:469)
        at expensiveCheckFn (3bf910c7ae4c.js:1447)
        at callback (3bf910c7ae4c.js:1747)
        at Scope.$eval (3bf910c7ae4c.js:1516)
        at Scope.$apply (3bf910c7ae4c.js:1517)
        at HTMLAnchorElement.<anonymous> (3bf910c7ae4c.js:1747)
        at HTMLAnchorElement.dispatch (3bf910c7ae4c.js:332)
        at HTMLAnchorElement.elemData.handle (3bf910c7ae4c.js:305)
    (anonymous) @ 3bf910c7ae4c.js:1336
    (anonymous) @ 3bf910c7ae4c.js:1197
    $apply @ 3bf910c7ae4c.js:1517
    (anonymous) @ 3bf910c7ae4c.js:1747
    dispatch @ 3bf910c7ae4c.js:332
    elemData.handle @ 3bf910c7ae4c.js:305

Recordsets get:

    TypeError: Cannot set property 'labels' of undefined
        at Object.perform (155a6dc00894.js:1236)
        at Scope.genPassThroughCallback [as callback] (155a6dc00894.js:421)
        at fn (eval at compile (3bf910c7ae4c.js:1398), <anonymous>:4:469)
        at expensiveCheckFn (3bf910c7ae4c.js:1447)
        at callback (3bf910c7ae4c.js:1747)
        at Scope.$eval (3bf910c7ae4c.js:1516)
        at Scope.$apply (3bf910c7ae4c.js:1517)
        at HTMLAnchorElement.<anonymous> (3bf910c7ae4c.js:1747)
        at HTMLAnchorElement.dispatch (3bf910c7ae4c.js:332)
        at HTMLAnchorElement.elemData.handle (3bf910c7ae4c.js:305)
    (anonymous) @ 3bf910c7ae4c.js:1336
    (anonymous) @ 3bf910c7ae4c.js:1197
    $apply @ 3bf910c7ae4c.js:1517
    (anonymous) @ 3bf910c7ae4c.js:1747
    dispatch @ 3bf910c7ae4c.js:332
    elemData.handle @ 3bf910c7ae4c.js:305

[Test Case]
Deploy OpenStack and designate-dashboard enabled. Ensure that attempts to delete zone from dashboard are successful.

[Regression Potential]
The initScope method for action services has been removed in horizon stable/queens so this code doesn't currently work. This was fixed upstream over a year ago in designate-dashboard for stable/queens and above, and therefore should have received plenty of exercise in the field by now.

Changed in designate-dashboard:
importance: Undecided → Critical
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in designate-dashboard (Ubuntu):
status: New → Confirmed
Changed in designate-dashboard (Ubuntu):
assignee: nobody → Marek Lyčka (mareklycka)
Revision history for this message
Marek Lyčka (mareklycka) wrote :

I committed a fix at:

https://review.openstack.org/#/c/588155/2

which review hasn't linked for some reason.

On a side note, this should also fix bug
https://bugs.launchpad.net/designate-dashboard/+bug/1759717

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate-dashboard 7.0.0.0rc1

This issue was fixed in the openstack/designate-dashboard 7.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate-dashboard 6.0.1

This issue was fixed in the openstack/designate-dashboard 6.0.1 release.

Revision history for this message
David Coronel (davecore) wrote :

subscribed ~field-medium

Changed in designate-dashboard (Ubuntu Bionic):
status: New → Triaged
importance: Undecided → High
Changed in designate-dashboard (Ubuntu):
status: Confirmed → Invalid
Changed in cloud-archive:
status: New → Invalid
Changed in designate-dashboard (Ubuntu):
assignee: Marek Lyčka (mareklycka) → nobody
description: updated
Revision history for this message
Corey Bryant (corey.bryant) wrote :

A new version of designate-dashboard has been uploaded to the Ubuntu unapproved queue for bionic and is awaiting review by the SRU team.

https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=designate-dashboard

description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Graham, or anyone else affected,

Accepted designate-dashboard into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/designate-dashboard/6.0.0-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in designate-dashboard (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hello Graham, or anyone else affected,

Accepted designate-dashboard into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-queens-needed
Revision history for this message
David Coronel (davecore) wrote :

I tested python-designate-dashboard version 6.0.0-0ubuntu1.2 from bionic-proposed on Ubuntu 18.04.3 LTS and I confirm I can delete the DNS zone successfully now.

ubuntu@juju-96d97f-22-lxd-14:~$ grep proposed /etc/apt/sources.list
deb http://archive.ubuntu.com/ubuntu/ bionic-proposed restricted main multiverse universe

ubuntu@juju-96d97f-21-lxd-14:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.3 LTS
Release: 18.04
Codename: bionic

ubuntu@juju-96d97f-21-lxd-14:~$ dpkg -l python-designate-dashboard
[...]
ii python-designate-dashboard 6.0.0-0ubuntu1.2 all OpenStack DNS as a Service - dashboard plugin

I created a new zone and deleted it. I get the prompt to delete it (which I didn't get without this package), and once I confirm the deletion it removes it from the list.

If I refresh the page right away, the zone comes back but in Pending state. After a few seconds I refresh again and the zone goes away for good. So it works as expected.

Thanks.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for designate-dashboard has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package designate-dashboard - 6.0.0-0ubuntu1.2

---------------
designate-dashboard (6.0.0-0ubuntu1.2) bionic; urgency=medium

  * d/gbp.conf: Create stable/queens branch.
  * d/p/updates-to-new-horizon-action-API.patch: Cherry-picked from upstream
    stable/queens to replace initScope with initAction in resource action
    definitions. initScope has been removed from horizon in stable/queens.
    (LP: #1750384).

 -- Corey Bryant <email address hidden> Mon, 09 Dec 2019 14:31:30 -0500

Changed in designate-dashboard (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote :

@David, thanks for testing! By any chance would you be able to test xenial-queens-proposed as well? Let me know if not and I'll queue it up.

Revision history for this message
David Coronel (davecore) wrote :

@Corey, I'm sorry the deployment I had was in bionic only. Can you queue it up on your side?

Revision history for this message
Corey Bryant (corey.bryant) wrote :

verified successfully on queens-proposed

Revision history for this message
Corey Bryant (corey.bryant) wrote :
tags: added: verification-queens-done
removed: verification-queens-needed
Revision history for this message
Corey Bryant (corey.bryant) wrote :

The verification of the Stable Release Update for designate-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package designate-dashboard - 6.0.0-0ubuntu1.2~cloud0
---------------

 designate-dashboard (6.0.0-0ubuntu1.2~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 designate-dashboard (6.0.0-0ubuntu1.2) bionic; urgency=medium
 .
   * d/gbp.conf: Create stable/queens branch.
   * d/p/updates-to-new-horizon-action-API.patch: Cherry-picked from upstream
     stable/queens to replace initScope with initAction in resource action
     definitions. initScope has been removed from horizon in stable/queens.
     (LP: #1750384).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.