SimpleSAML_Logger is deprecated warning

Bug #1754237 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned

Bug Description

There is a warning about:
ssphp- WARNING [CL05234431] The class or interface 'SimpleSAML_Logger' is now using namespaces, please use 'SimpleSAML\Logger'.

We need to update the config etc to use the new style of calling the logger

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8630

Changed in mahara:
milestone: 18.04.0 → 18.10.0
status: Confirmed → In Progress
Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :

There are also warnings for the store:

WARNING [TRe51b00d3] The class or interface 'SimpleSAML_Store' is now using namespaces, please use 'SimpleSAML\Store'.

Revision history for this message
Steven (stevens-q) wrote :
Download full text (6.1 KiB)

Environment tested: Master
Browser tested: Chrome

-------------------------------------
Manual Test Script
-------------------------------------

Preconditions:

1. SAML patches: Please ask Robert to apply them to https://webservices-mahara.catalystdemo.net.nz/
- It would be patch https://reviews.mahara.org/#/c/8893/2 as that also pulls in https://reviews.mahara.org/#/c/8630/8
2. Catalyst User with LDAP sign in exists (stevens)

Test Script - The class or interface 'SimpleSAML_Logger' is now using namespaces

1. User browse to https://webservices-mahara.catalystdemo.net.nz/admin/users/institutions.php
2. User click SSO Login option
3. confirm user is redirected to Catalyst SSO login page
4. User click the "LDAP User directory" bitton
5. User enter their LDAP username and password
6. Confirm user is redirected back to the Mahara site and user is logged in ✔
7. Log out and log in as admin user for the site
8. Browse around the site and confirm there are no bugs ✔
9. Create a portfolio page and add varous block to the page and confirm functionality is working as expected ✔

Test Script - Admin user set up SAML auth for instution

1. Log in as site admin
2. Create a new Institution
3. Edit the newly created Institution
4. Confirm that there is now a "Authentication plugin" drop down field ✔
5. Select the SAML option
6. Add the following information in the Institution Identity Provider SAML metadata text box
-----------------------------------------------------------------------------------------------
<?xml version="1.0" encoding="UTF-8"?>
<md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" entityID="idp.crystal.school.nz">
  <md:IDPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol" WantAuthnRequestsSigned="true">
    <md:KeyDescriptor use="signing">
      <ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
        <ds:X509Data>
          <ds:X509Certificate>MIIDnTCCAoWgAwIBAgIJAID6W0Acj/k5MA0GCSqGSIb3DQEBBQUAMGUxCzAJBgNVBAYTAk5aMQ8wDQYDVQQIDAZOZWxzb24xDzANBgNVBAcMBk5lbHNvbjEUMBIGA1UECgwLTmVsc29uIExvb3AxHjAcBgNVBAMMFWlkcC5jcnlzdGFsLnNjaG9vbC5uejAeFw0xNDA3MDYxOTQ0MjJaFw0yNDA3MDUxOTQ0MjJaMGUxCzAJBgNVBAYTAk5aMQ8wDQYDVQQIDAZOZWxzb24xDzANBgNVBAcMBk5lbHNvbjEUMBIGA1UECgwLTmVsc29uIExvb3AxHjAcBgNVBAMMFWlkcC5jcnlzdGFsLnNjaG9vbC5uejCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALui2EpTSiuByRDWTLG7Eqsdrb+PeBw1uMGbfa5pstB2TTju7+GxD6nAjRPYeyYkRMrFV6lk7Bu+ZM9irX32O3ly67SPikzl9BuqCjsRRxB9klTu/zJ1YpUp8K2VQqexctJY8GqgIpwY3UC+H/kkJXiox1RuQ/GauPO2NFQ6/keZSr3sFmeF/lWn/21Jobsyi5SXX2mN9eOED4FxptDww+i48U/7tynTtaKzEBDAFlZnU8RmLpd2IBoi3KhrssrCnb0kP3f9MoUl+hVmZanQ446PxKtmS82UM1q6K1ZiK4/lcZH4667vikyxZmjXnTQR7ALg+Edt6H3pPCQNSDaRg9MCAwEAAaNQME4wHQYDVR0OBBYEFM49ucR9Egxt4vYIpNvC1lIKcSUDMB8GA1UdIwQYMBaAFM49ucR9Egxt4vYIpNvC1lIKcSUDMAwGA1UdEwQFMAMBAf8wDQYJKoZIhvcNAQEFBQADggEBAEfL2B9CvkwzrP0NTGpg/ZlD8VzRz3q29umJJnZCHmPkfCTi+lHShfH2fTfkw+ntSQo8DbDFiu7G2EO9CgqiE8TiUoLkx8jEeM/On8Rwy6VXLrmzlmcB1YSG44r+RXIekuLvt1f5wHG+HQ4gWVQoON8kbRhfRJBkLTCefzsoELvPIdcWAsYRg1BA5eXmrdfq7W7ALI9O/WWUfNyRjTk7X/RfgB5awkuI1WyMrlsjCrjB4xtNEzcVkg/tvq48xMq6Zsx3GzUXBQu/MhITCYI5xqgbcmAEKjwHyeXcINPh1f8jxfzXIc9u6...

Read more...

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8893
Committed: https://git.mahara.org/mahara/mahara/commit/213539e75fa67dc4397b0ca5bd0945a1b0db1786
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 213539e75fa67dc4397b0ca5bd0945a1b0db1786
Author: Robert Lyon <email address hidden>
Date: Fri May 25 10:15:12 2018 +1200

Bug 1754237: Updating custom SimpleSAMLphp files

To be more in tune with their original counterparts. This means adding
new namespace way of calling things and other fixes to make them wok
as expected for version 1.15

behatnotneeded

Change-Id: If70569de61cbc1425283b68e9389ca8359b85286
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8630
Committed: https://git.mahara.org/mahara/mahara/commit/1d68ffcaaf34c044ee7bf6a4459d82f7010a6978
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1d68ffcaaf34c044ee7bf6a4459d82f7010a6978
Author: Robert Lyon <email address hidden>
Date: Fri Mar 16 14:26:18 2018 +1300

Bug 1754237: Switching SimpleSAMLphp logger call to namesapced way

behatnotneeded

Change-Id: I7015e84895533aa3ae338da27c872d0d00b97b84
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.