Behat copies html styling regardless of whether the option for an html report is passed in

Bug #1767933 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Rebecca Blundell

Bug Description

When running behat tests with the html flag as in:
./test/behat/mahara_behat.sh run test.feature html
the styling needs to be copied over to the plugin folder to make the report display correctly.

If the test is being run without 'html', there is no need for the styling to be copied over. Currently this happens regardless.

Currently the function set_report_styling is called during behat setup from /htdocs/testing/frameworks/behat/cli/util.php. In order to fix this there should be an if statement around that call.

Tags: behat
Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
status: New → In Progress
Changed in mahara:
assignee: Rebecca Blundell (rjb-dev) → nobody
status: In Progress → Confirmed
Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10718

Changed in mahara:
milestone: none → 20.10.0
importance: Undecided → Low
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10718
Committed: https://git.mahara.org/mahara/mahara/commit/b80a2a7b178733f1f119facc954adff1531b1d5a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b80a2a7b178733f1f119facc954adff1531b1d5a
Author: Rebecca Blundell <email address hidden>
Date: Wed Jan 15 18:15:48 2020 +1300

Bug 1767933: Behat: only run html copy if report option chosen

Change-Id: Id75669e3d37bdc805c9af34412d71f5e3733c36a

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.