Bug #1769581 “Remove info on subscribe / unsubscribe from topics...” : Bugs : Mahara

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-07: A patch has been submitted for review

#1

Patch for "master" branch: https://reviews.mahara.org/8833

Revision history for this message

Cecilia Vela Gurovic (ceciliavg) wrote on 2018-05-08:

#2

according to the code, the options in the 'Choose an action' dropdown are these:

for a moderator/admin of the forum (also subscribed to the forum)
Sticky, Unsticky, Close, Open, Move to

for a moderator/admin (not subscribed to the forum)
Subscribe, Unsubscribe, Sticky, Unsticky, Close, Open, Move to

for a member (not subscribed to the forum)
Subscribe, Unsubscribe

for a member (subscribed to the forum)
no actions

It looks like if you are not subscribed to the forum, you can subscribe/unsubcribe to the individual topics. it's not related to being admin, moderator or normal user.
.

Revision history for this message

Cecilia Vela Gurovic (ceciliavg) wrote on 2018-05-08:

#3

There is one more detail, the option 'Move to' is only displayed if there's at least one other forum in the group. So we could have 4 possible set of actions for admin/moderators:

Subscribe, Unsubscribe, Sticky, Unsticky, Close, Open, Move to
Subscribe, Unsubscribe, Sticky, Unsticky, Close, Open
Sticky, Unsticky, Close, Open, Move to
Sticky, Unsticky, Close, Open

So that would be 5 help texts if we want to display only the ones shown in the dropdown

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2018-05-08:

#4

Cecilia, thank you for checking. According to bug #1752442 the functionality to subscribe / unsubscribe from individual topics was removed or was it just that it was not seen because the entire forum was subscribed to?

Revision history for this message

Cecilia Vela Gurovic (ceciliavg) wrote on 2018-05-08:

#5

The functionality has not been removed. If we are not subscribed to a forum, then we are able to subscribe to individual topics.

Bug #1752442 description was corrected in first comment
https://bugs.launchpad.net/mahara/+bug/1752442/comments/1
and its patch only hid the icon for normal members (not admin or mod) that are subscribed to the forum.

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2018-05-08:

#6

Thanks, Cecilia. I'll update my lang strings.

Revision history for this message

Steven (stevens-q) wrote on 2018-05-14:

#7

Download full text (9.2 KiB)

Launchpad: https://bugs.launchpad.net/mahara/+bug/[[https://bugs.launchpad.net/mahara/+bug/1769581|1769581]]
Gerrit: https://reviews.mahara.org/#/c[[https://reviews.mahara.org/#/c/8833/|/8833/]]
Bug description: Update help icon text for topic selection
--------------------------------------------------------------
Environment tested: Master
Browser tested: Chrome
===================
Manual Test Script
===================

Special Notes:
1. Only a Mahara site admin can create a course group consisting of members, tutors and administrators.
2. Regular Mahara members can only create Standard groups consisting of members and administrators.

Preconditions:

1. The following users exist
a. Mahara Site Admin = Admin User
b. Admin of the ("Group Alice 101") = Alice User1
c. Forum moderator - General discussion (Mahara site admin course 101) and ("Group Alice 101") = Bob User2
d. Tutor for (Mahara site admin course 101) = Carol User3
e. Member (Mahara site admin course 101) and ("Group Alice 101") = Dan User4
2. Standard group ("Group Alice 101") exists with the following:
a. Created by - Alice User1 (NOT a Mahara site admin)
b. Membership - Open = yes
c. Visibility - Publicly viewable group = yes
3. Forum exists for ("Group Alice 101") as follows:
a. Forum = General discussion
b. Forum creator = Alice User1
c. Member subscribed to the forum = Bob User2
4. Second Forum exists for ("Group Alice 101") as follows:
a. Forum = "Human Resources Director"
b. Forum creator = Alice User1
5. Course group (Mahara site admin course 101) exists with the following:
a. Created by - Mahara site admin
b. Membership - Open = yes
c. Visibility - Publicly viewable group = yes
6. Forum exists for (Mahara site admin course 101) as follows:
a. Forum = General discussion
b. Forum creator = Admin User
c. Member subscribed to the forum = Bob User2
d. Tutor member = Carol User3
7. Second
a. Forum exists for (Mahara site admin course 101) as follows:
b. Forum = "Some other forum"
c. Forum creator = Admin User

Test Script Standard group:
----------------------------------------------
1. Log in as Alice User1 - admin of group ("Group Alice 101")
2. Browse to "Group Alice 101" > Forum > General discussion
3. Confirm the following is displayed in the "Update selected topics" drop down
a. Sticky ✔
b. Unsticky ✔
c. Close ✔
d. Open ✔
e. Move to ✔
4. Click the help icon to the right of the field
5. Confirm that the help text reflects the field options as follows:
a. Subscribe and unsubscribe help text is displayed even though they are not options in the drop down field ✔
b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
6. Click the unsubscribe from forum button
7. Confirm that the following is displayed in the "Update selected topics" drop down
a. Subscribe ✔
b. Unsubscribe ✔
c. Sticky ✔
d. Unsticky ✔
e. Close ✔
f. Open ✔
g. Move to ✔
8. Confirm that the help text refle...

Launchpad: https://bugs.launchpad.net/mahara/+bug/[[https://bugs.launchpad.net/mahara/+bug/1769581|1769581]]
Gerrit: https://reviews.mahara.org/#/c[[https://reviews.mahara.org/#/c/8833/|/8833/]]
Bug description: Update help icon text for topic selection
--------------------------------------------------------------
Environment tested: Master
Browser tested: Chrome
===================
Manual Test Script
===================

Special Notes:
1. Only a Mahara site admin can create a course group consisting of members, tutors and administrators.
2. Regular Mahara members can only create Standard groups consisting of members and administrators.

Preconditions:

1. The following users exist
	a. Mahara Site Admin = Admin User
	b. Admin of the ("Group Alice 101") = Alice User1
	c. Forum moderator - General discussion  (Mahara site admin course 101) and ("Group Alice 101") = Bob User2
	d. Tutor for (Mahara site admin course 101) = Carol User3
	e. Member (Mahara site admin course 101) and  ("Group Alice 101") =  Dan User4
2. Standard group ("Group Alice 101") exists with the following:
	a. Created by -  Alice User1 (NOT a Mahara site admin)
	b. Membership - Open = yes
	c. Visibility - Publicly viewable group =  yes
3. Forum exists for ("Group Alice 101") as follows:
	a. Forum = General discussion
	b. Forum creator = Alice User1
	c. Member subscribed to the forum = Bob User2
4. Second Forum exists for ("Group Alice 101") as follows:
	a. Forum = "Human Resources Director"
	b. Forum creator = Alice User1
5. Course group (Mahara site admin course 101) exists with the following:
	a. Created by -  Mahara site admin
	b. Membership - Open = yes
	c. Visibility - Publicly viewable group =  yes
6. Forum exists for (Mahara site admin course 101) as follows:
	a. Forum = General discussion
	b. Forum creator = Admin User
	c. Member subscribed to the forum = Bob User2
	d. Tutor member = Carol User3
7. Second
	a. Forum exists for (Mahara site admin course 101) as follows:
	b. Forum = "Some other forum"
	c. Forum creator = Admin User

Test Script Standard group:
----------------------------------------------
1. Log in as Alice User1 - admin of group  ("Group Alice 101")
2. Browse to "Group Alice 101" > Forum > General discussion
3. Confirm the following is displayed in the "Update selected topics" drop down
	a. Sticky ✔
	b. Unsticky ✔
	c. Close ✔
	d. Open ✔
	e. Move to ✔
4. Click the help icon to the right of the field
5. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed even though they are not options in the drop down field ✔
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
6. Click the unsubscribe from forum button
7. Confirm that the following is displayed in the "Update selected topics" drop down
	a. Subscribe ✔
	b. Unsubscribe ✔
	c. Sticky ✔
	d. Unsticky ✔
	e. Close ✔
	f. Open ✔
	g. Move to ✔
8. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed ✔
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
9. Log in as Bob User2 - moderator of General discussion ("Group Alice 101")
10. Browse to "Group Alice 101" > Forum > General discussion
11. Confirm the following is displayed in the "Update selected topics" drop down
	a. Sticky ✔
	b. Unsticky ✔
	c. Close ✔
	d. Open ✔
	e. Move to ✔
12. Click the help icon to the right of the field
13. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed even though they are not options in the drop down field ✔
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
14. Log in as Dan User4 - moderator of General discussion ("Group Alice 101")
15. Browse to Group Alice 101 > Forums > General discussion
16. Confirm the following is displayed in the "Update selected topics" drop down is not displayed 
17. Click the Unsubscribe button 
18. Confirm the following is displayed in the "Update selected topics" drop down
	a. Subscribe ✔
	b. Unsubscribe ✔
19. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed ✔
	b. Text = Subscribe:  you will receive notifications for posts to selected topics. ✔
	c. Text = Unsubscribe: you will not receive notifications for posts to selected topics. ✔

Test Script Course group:
----------------------------------------------
1.  Log in as Admin User - admin of group (Mahara site admin course 101)
2. Browse to Mahara site admin course 101 > Forums > General discussion
3. Confirm the following is displayed in the "Update selected topics" drop down
	a. Sticky ✔
	b. Unsticky ✔
	c. Close ✔
	d. Open ✔
	e. Move to ✔
4. Click the help icon to the right of the field
	a. Subscribe and unsubscribe help text is displayed even though they are not options in the drop down field ✔
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
5. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed even though they are not options in the drop down field ✔ 
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
6. Click the unsubscribe from forum button
7. Confirm that the following is displayed in the "Update selected topics" drop down
	a. Subscribe ✔
	b. Unsubscribe ✔
	c. Sticky ✔
	d. Unsticky ✔
	e. Close ✔
	f. Open ✔
	g. Move to ✔
8. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed ✔
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
9. Log in as Bob User2 - moderator of General discussion (Mahara site admin course 101)
10. Browse to Mahara site admin course 101 > Forum > General discussion
11. Confirm the following is displayed in the "Update selected topics" drop down
	a. Sticky ✔
	b. Unsticky ✔
	c. Close ✔
	d. Open ✔
	e. Move to ✔
12. Click the help icon to the right of the field
13. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed even though they are not options in the drop down field ✔
	b. Text = Subscribe: You will receive notifications for posts to selected topics. This option is only available if you are not already subscribed to the entire forum. ✔
	c. Text = Unsubscribe: You will not receive notifications for posts to selected topics. This is only possible when you are not subscribed to the forum. ✔
14. Log in as Carol User3 - moderator of General discussion (Mahara site admin course 101)
15. Browse to Mahara site admin course 101 > Forums > General discussion
16. Confirm the following is displayed in the "Update selected topics" drop down is not displayed 
17. Click the Unsubscribe button 
18. Confirm the following is displayed in the "Update selected topics" drop down
	a. Subscribe ✔
	b. Unsubscribe ✔
19. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed ✔
	b. Text = Subscribe:  you will receive notifications for posts to selected topics. ✔
	c. Text = Unsubscribe: you will not receive notifications for posts to selected topics. ✔
20. Log in as Dan User4 - moderator of General discussion (Mahara site admin course 101)
21. Browse to Mahara site admin course 101 > Forums > General discussion
22. Confirm the following is displayed in the "Update selected topics" drop down is not displayed 
23. Click the Unsubscribe button 
24. Confirm the following is displayed in the "Update selected topics" drop down
	a. Subscribe ✔
	b. Unsubscribe ✔
25. Confirm that the help text reflects the field options as follows:
	a. Subscribe and unsubscribe help text is displayed ✔
	b. Text = Subscribe:  you will receive notifications for posts to selected topics. ✔
	c. Text = Unsubscribe: you will not receive notifications for posts to selected topics. ✔

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14: A change has been merged

#8

Reviewed: https://reviews.mahara.org/8833
Committed: https://git.mahara.org/mahara/mahara/commit/a6636e566492921c2b48bda8e142d0730c6779a9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit a6636e566492921c2b48bda8e142d0730c6779a9
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Mon May 7 19:56:29 2018 +1200

Bug 1769581: Update help icon text for topic selection

Mention that the subscribe / unsubscribe options are
only available when not subscribed to the forum.

behatnotneeded

Change-Id: I5c34aed233a75a9e26346df69a52137518e44218

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14: A patch has been submitted for review

#9

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8859

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14:

#10

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8860

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14:

#11

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8861

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14: A change has been merged

#12

Reviewed: https://reviews.mahara.org/8861
Committed: https://git.mahara.org/mahara/mahara/commit/0e0231655c15ab04963c1b1669bc16f02bcd8e36
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 0e0231655c15ab04963c1b1669bc16f02bcd8e36
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Mon May 7 19:56:29 2018 +1200

Bug 1769581: Update help icon text for topic selection

Mention that the subscribe / unsubscribe options are
only available when not subscribed to the forum.

behatnotneeded

Change-Id: I5c34aed233a75a9e26346df69a52137518e44218
(cherry picked from commit a6636e566492921c2b48bda8e142d0730c6779a9)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14:

#13

Reviewed: https://reviews.mahara.org/8860
Committed: https://git.mahara.org/mahara/mahara/commit/b873dbac5a2819bfdd2347a4b8af69fcbd8c0cc1
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit b873dbac5a2819bfdd2347a4b8af69fcbd8c0cc1
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Mon May 7 19:56:29 2018 +1200

Bug 1769581: Update help icon text for topic selection

Mention that the subscribe / unsubscribe options are
only available when not subscribed to the forum.

behatnotneeded

Change-Id: I5c34aed233a75a9e26346df69a52137518e44218
(cherry picked from commit a6636e566492921c2b48bda8e142d0730c6779a9)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-14:

#14

Reviewed: https://reviews.mahara.org/8859
Committed: https://git.mahara.org/mahara/mahara/commit/2a37fa40c0e510d20443ce29e3d16250c6dde309
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 2a37fa40c0e510d20443ce29e3d16250c6dde309
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Mon May 7 19:56:29 2018 +1200

Bug 1769581: Update help icon text for topic selection

Mention that the subscribe / unsubscribe options are
only available when not subscribed to the forum.

behatnotneeded

Change-Id: I5c34aed233a75a9e26346df69a52137518e44218
(cherry picked from commit a6636e566492921c2b48bda8e142d0730c6779a9)

Kristina Hoeppner (kris-hoeppner) on 2018-05-15

tags:

added: usermanualupdate

Kristina Hoeppner (kris-hoeppner) on 2018-10-13

tags:

removed: usermanualupdate

	Status	Importance	Assigned to	Milestone
Mahara	Fix Released	Medium	Unassigned	Mahara 18.10.0
17.04	Fix Released	Medium	Unassigned	Mahara 17.04.8
17.10	Fix Released	Medium	Unassigned	Mahara 17.10.5
18.04	Fix Released	Medium	Unassigned	Mahara 18.04.1
18.10	Fix Released	Medium	Unassigned	Mahara 18.10.0

Mahara

Remove info on subscribe / unsubscribe from topics in group forums

Bug Description

Other bug subscribers

Remote bug watches