Mahara

SITEOUTOFSYNC already defined

Bug #1771698 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned
Mahara 18.10.0

Bug Description

Sometimes when testing I get this error when not in production mode

 Constant SITEOUTOFSYNC already defined

This can happen if the core version in db is greater than in htdocs/lib/version.php
and I visit the Admin dashboard page.

This is because both init.php and admin index page both call check upgrades()

Need to wrap the define('SITEOUTOFSYNC' ...); in some if (defined('SITEOUTOFSYNC')) { ... } wrappers

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Low
status: New → In Progress
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8864

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8864
Committed: https://git.mahara.org/mahara/mahara/commit/9e15f3614fb7cb210eac0ff50c67c4c477f2406c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 9e15f3614fb7cb210eac0ff50c67c4c477f2406c
Author: Robert Lyon <email address hidden>
Date: Thu May 17 11:42:52 2018 +1200

Bug 1771698: Check if SITEOUTOFSYNC is already defined

behatnotneeded

Change-Id: Ib646a8348e4533ff15b333eb839cf33ea085ec28
Signed-off-by: Robert Lyon <email address hidden>

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.