dahdi-linux 1:2.10.2~dfsg-1ubuntu2 ADT test failure with linux-hwe-edge 4.15.0-23.25~16.04.1

This debdiff looks mostly good. I had to spend quite a bit of time to figure out where the patches came from. Apparently, they're from this bug:

  https://issues.asterisk.org/jira/browse/DAHLIN-359

I've added the Origin dep-3 tag to each patch. I see that you probably just reused the patches from the Bionic or Cosmic package, which didn't include the origin, but the origin is important to include so that we know where the code is coming from, what kind of review it has gotten, etc.

As mentioned while sponsoring another recent package for you, I don't love the SRU versioning scheme used here. If you look at the current artful, bionic, and cosmic version strings, you can see why it could be a problem in future SRUs. The versioning scheme documented here has been proven to work well:

  https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

I'm sponsoring this one to xenial-proposed since you're following the existing SRU versioning scheme for the package. Thanks for the debdiff! :)

Accepting this as is, but I'm a bit worried that the patches haven't been actually accepted upstream yet? At least looking at Jira, the bug is still 'Triaged', with only comments approving that it 'WFM' (which is why I'm allowing this to get approved, since that's still better than not building at all).

Hello Marcelo, or anyone else affected,

Accepted dahdi-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dahdi-linux/1:2.10.2~dfsg-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I have tested the version 1:2.10.2~dfsg-1ubuntu3 and the DKMS package successfully builds and loads on kernels 4.15, which was the issue reported in this bug.

I also have run the ADT tests for the following kernels to ensure there's no regressions:

- linux-generic 4.4
- linux-hwe 4.15
- linux-azure-edge 4.15

This bug was fixed in the package dahdi-linux - 1:2.10.2~dfsg-1ubuntu3

---------------
dahdi-linux (1:2.10.2~dfsg-1ubuntu3) xenial; urgency=medium

  * Linux 4.15 compatibility (LP: #1779331)
    - d/p/kernel-compat-4.15_0001-xpp-move-command_timer-functions-to-xbus-core.patch
    - d/p/kernel-compat-4.15_0002-fix-building-with-4.15-init_timer-setup_timer.patch

 -- Marcelo Henrique Cerri <email address hidden> Fri, 29 Jun 2018 10:58:53 -0300

The verification of the Stable Release Update for dahdi-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.