DEP8 fixes for xenial

I must say that I'm not very fond of autopkgtest-only fixes to stable series, especially for packages that had no updates since release (which is the case here). But in this case I think I'd risk it. The fact that these tests are run for apache2 can be troublesome for regular and security updates (once the autopkgtest are enabled for security).

I would like to request some additional testing if possible, to make sure the new binaries are sane in a regular environment as well. Also, if the package FTBFS or similar, I'll instantly back it off from -proposed.

Hello Andreas, or anyone else affected,

Accepted libapache2-mod-perl2 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libapache2-mod-perl2/2.0.9-4ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

DEP8 tests are green: http://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#libapache2-mod-perl2
libapache2-mod-perl2 (2.0.9-4ubuntu1 to 2.0.9-4ubuntu1.1)
Maintainer: Ubuntu Developers
0 days old
Not touching package due to block request by freeze (contact #ubuntu-release if update is needed)
autopkgtest for libapache-authznetldap-perl/0.07-6: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libapache-singleton-perl/0.16-1: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libapache-ssllookup-perl/2.00-04-1build1: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libapache2-authcassimple-perl/0.10-3: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libapache2-authcookie-perl/3.24-1: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libapache2-authenntlm-perl/0.02-8build1: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libapache2-mod-perl2/2.0.9-4ubuntu1.1: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
autopkgtest for libreverseproxy-formfiller-perl/0.5-1: amd64: Pass, arm64: Pass, armhf: Pass, i386: Pass, ppc64el: Pass, s390x: Pass
Not considered

amd64 run: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/liba/libapache2-mod-perl2/20180723_142015_d6807@/log.gz

Previous run failed with the errors indicated here in this bug: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/liba/libapache2-mod-perl2/20180613_155933_8a3f2@/log.gz

To test libapache2-mod-perl2 itself, I installed otrs2, a web ticketing system application, in two steps:
- sudo apt install postgresql
- sudo apt install otrs2

I accessed the web ui with the administrator credentials (root@localhost / root), then created a normal user, accessed the system as that user.

Then upgraded libapache2-mod-perl2:
root@xenial-modperl:~# apt-cache policy libapache2-mod-perl2
libapache2-mod-perl2:
  Installed: 2.0.9-4ubuntu1.1
  Candidate: 2.0.9-4ubuntu1.1
  Version table:
 *** 2.0.9-4ubuntu1.1 500
        500 http://br.archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     2.0.9-4ubuntu1 500
        500 http://br.archive.ubuntu.com/ubuntu xenial/main amd64 Packages

Made sure apache2 was restarted, and lsof confirmed mod_perl.so was loaded. Web app continued to work, and apache logs showed no errors or segfaults.

I'll leave this bug unmarked for a few more days to give others a chance to test.

I also ran ldd on all .so files from libapache2-mod-perl2 and compared that output between the current and the proposed package. It's identical:

2.0.9-4ubuntu1: http://paste.ubuntu.com/p/pr3sCx26gM/
2.0.9-4ubuntu1.1: http://paste.ubuntu.com/p/74JR6xhn7g/

Script used: http://paste.ubuntu.com/p/VZDnKdYNvS/

This bug was fixed in the package libapache2-mod-perl2 - 2.0.9-4ubuntu1.1

---------------
libapache2-mod-perl2 (2.0.9-4ubuntu1.1) xenial; urgency=medium

  * Pull fixes from Debian's package 2.0.10-2 for the DEP8 tests that started
    failing after the CVE-2016-8743 fix for apache2 (LP: #1779400):
    - debian/patches/370_http_syntax.patch: [PATCH 1/2] Fix
      t/apache/read.t HTTP syntax for Apache 2.4.24.
    - debian/patches/380_inject_header_line_terminators.patch: [PATCH 2/2]
      Fix in_bbs_inject_header line terminators for Apache.

 -- Andreas Hasenack <email address hidden> Fri, 29 Jun 2018 15:48:39 -0300

The verification of the Stable Release Update for libapache2-mod-perl2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.