[SRU] unreadable text color in confirmation dialog with ubuntu theme

Attaching screenshot when mouse isn't hovering over confirmation button.

Attaching screenshot when mouse is hovering over confirmation button.

Also affects queens.

This started in queens as a result of: https://review.openstack.org/#/c/339278/

Prior to that, the delete confirmation buttons used btn-primary (white on orange). Now the btn-danger is used (which is red). The problem is that 'a, a:link, a:visited' (color: orange) is overriding btn-danger's default color (white):

a, a:link, a:visited {
    color: #e95420;
}

.btn-danger {
    color: #fff; # this gets overridden - shows with striked-through
    background-color: #d9534f;
    border-color: #d43f3a;
}

I've uploaded new versions of horizon to cosmic(rocky) and bionic(queens) with fixes for this. Bionic is awaiting approval from the SRU team.

This bug was fixed in the package horizon - 3:14.0.0-0ubuntu3

---------------
horizon (3:14.0.0-0ubuntu3) cosmic; urgency=medium

  * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
    used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).
  * d/p/add-juju-environment-download.patch: Dropped as this support is for
    an old version of Juju (1.x). Users should follow the documentation at
    docs.jujucharms.com to configure Juju (2.x) to use an OpenStack cloud.

 -- Corey Bryant <email address hidden> Tue, 11 Sep 2018 14:22:20 -0600

This bug was fixed in the package horizon - 3:14.0.0-0ubuntu3~cloud0
---------------

 horizon (3:14.0.0-0ubuntu3~cloud0) bionic-rocky; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:14.0.0-0ubuntu3) cosmic; urgency=medium
 .
   * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
     used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).
   * d/p/add-juju-environment-download.patch: Dropped as this support is for
     an old version of Juju (1.x). Users should follow the documentation at
     docs.jujucharms.com to configure Juju (2.x) to use an OpenStack cloud.

Hello Corey, or anyone else affected,

Accepted horizon into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/horizon/3:13.0.1-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Corey, or anyone else affected,

Accepted horizon into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

This bug was fixed in the package horizon - 3:14.0.0-0ubuntu3~cloud0
---------------

 horizon (3:14.0.0-0ubuntu3~cloud0) bionic-rocky; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:14.0.0-0ubuntu3) cosmic; urgency=medium
 .
   * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
     used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).
   * d/p/add-juju-environment-download.patch: Dropped as this support is for
     an old version of Juju (1.x). Users should follow the documentation at
     docs.jujucharms.com to configure Juju (2.x) to use an OpenStack cloud.

I've successfully verified this on bionic-proposed with a juju-deployed openstack. I navigated through all dashboards from Project to Admin to Identity, ensuring danger buttons look good. They all display correctly.

openstack-dashboard:
  Installed: 3:13.0.1-0ubuntu2
  Candidate: 3:13.0.1-0ubuntu2
  Version table:
 *** 3:13.0.1-0ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3:13.0.1-0ubuntu1 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     3:13.0.0-0ubuntu1 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic/main amd64 Packages

Attaching screenshot from bionic-proposed when mouse isn't hovering over confirmation button.

I've successfully verified this on queens-proposed with a juju-deployed openstack. I navigated through all dashboards from Project to Admin to Identity, ensuring danger buttons look good. They all display correctly.

openstack-dashboard:
  Installed: 3:13.0.1-0ubuntu2~cloud0
  Candidate: 3:13.0.1-0ubuntu2~cloud0
  Version table:
 *** 3:13.0.1-0ubuntu2~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu xenial-proposed/queens/main amd64 Packages
        100 /var/lib/dpkg/status
     2:9.1.2-0ubuntu5 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
     2:9.0.0-0ubuntu2 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu xenial/main amd64 Packages

Attaching screenshot from queens-proposed when mouse isn't hovering over confirmation button.

The verification of the Stable Release Update for horizon has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package horizon - 3:13.0.1-0ubuntu2

---------------
horizon (3:13.0.1-0ubuntu2) bionic; urgency=medium

  * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
    used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).

 -- Corey Bryant <email address hidden> Fri, 14 Sep 2018 13:05:57 -0400

This bug was fixed in the package horizon - 3:14.0.0-0ubuntu3~cloud0
---------------

 horizon (3:14.0.0-0ubuntu3~cloud0) bionic-rocky; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:14.0.0-0ubuntu3) cosmic; urgency=medium
 .
   * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
     used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).
   * d/p/add-juju-environment-download.patch: Dropped as this support is for
     an old version of Juju (1.x). Users should follow the documentation at
     docs.jujucharms.com to configure Juju (2.x) to use an OpenStack cloud.

The verification of the Stable Release Update for horizon has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package horizon - 3:13.0.1-0ubuntu2~cloud0
---------------

 horizon (3:13.0.1-0ubuntu2~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:13.0.1-0ubuntu2) bionic; urgency=medium
 .
   * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
     used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).

This bug was fixed in the package horizon - 3:14.0.0-0ubuntu3~cloud0
---------------

 horizon (3:14.0.0-0ubuntu3~cloud0) bionic-rocky; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:14.0.0-0ubuntu3) cosmic; urgency=medium
 .
   * d/theme/ubuntu/_styles.scss: Ensure btn-danger rules are preferred when
     used with a, a:link, a:visited and dropdown-menu.li (LP: #1790189).
   * d/p/add-juju-environment-download.patch: Dropped as this support is for
     an old version of Juju (1.x). Users should follow the documentation at
     docs.jujucharms.com to configure Juju (2.x) to use an OpenStack cloud.