Mahara

Make min PHP version tp be 7+ to allow phpunit 6.0 to work

Bug #1793227 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 18.10.0

Bug Description

we changed phpunit required version to ^6.0 here:
  https://bugs.launchpad.net/mahara/+bug/1786867
  https://reviews.mahara.org/#/c/9067/
but this only works with php7+

If you are on php 5.5.9 and want to install SimpleSaml with command
make ssphp
Composer will fail with error
phpunit/phpunit 6.5.9 requires php ^7.0 -> your PHP version (5.5.9) does not satisfy that requirement.

Should we fix this to allow older version of phpunit?

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: none → 18.10.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 18.10.0 → 18.10rc1
Robert Lyon (robertl-9)
Changed in mahara:
status: New → Confirmed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: 18.10rc1 → 18.10rc2
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9235

Robert Lyon (robertl-9)
summary: - phpunit 6.0 only works on php7+
+ Make min PHP version tp be 7+ to allow phpunit 6.0 to work
Changed in mahara:
status: Confirmed → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9235
Committed: https://git.mahara.org/mahara/mahara/commit/1bf381347860f347313fbbead18542de7a0a1c12
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 1bf381347860f347313fbbead18542de7a0a1c12
Author: Robert Lyon <email address hidden>
Date: Thu Oct 18 10:55:33 2018 +1300

Bug 1793227: Alter the minimum php version to be 7.0

Now that we rely on PHP7+ for things like phpunit we need to bump our
minimum PHP version

behatnotneeded

Change-Id: Icb85e8ff806e6847558ed099dfc81f19eedfd3a2
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9259

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9259
Committed: https://git.mahara.org/mahara/mahara/commit/5ab841bb3ccd8cf49240c98155f5839c04138ba3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 5ab841bb3ccd8cf49240c98155f5839c04138ba3
Author: Robert Lyon <email address hidden>
Date: Thu Oct 18 10:55:33 2018 +1300

Bug 1793227: Alter the minimum php version to be 7.0

Now that we rely on PHP7+ for things like phpunit we need to bump our
minimum PHP version

behatnotneeded

Change-Id: Icb85e8ff806e6847558ed099dfc81f19eedfd3a2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1bf381347860f347313fbbead18542de7a0a1c12)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: 18.10rc2 → 18.10.0
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9269

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9269
Committed: https://git.mahara.org/mahara/mahara/commit/efb93dc6d0c6dd8a8fd4dff9b6f33314b0478cac
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit efb93dc6d0c6dd8a8fd4dff9b6f33314b0478cac
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 25 14:05:02 2018 +1300

Bug 1793227: update readme file with minimum php version to be 7.0

behatnotneeded

Change-Id: I305389e6a242bc1efc4a18d355f62c734fd27221

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9271

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9271
Committed: https://git.mahara.org/mahara/mahara/commit/bcf1f2ca7a08818b4b36e234d1da6db54aad1d3f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit bcf1f2ca7a08818b4b36e234d1da6db54aad1d3f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 25 14:05:02 2018 +1300

Bug 1793227: update readme file with minimum php version to be 7.0

behatnotneeded

Change-Id: I305389e6a242bc1efc4a18d355f62c734fd27221
(cherry picked from commit efb93dc6d0c6dd8a8fd4dff9b6f33314b0478cac)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.