Mahara

Tag sideblock showing on incorrect page

Bug #1798217 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 18.10.0

Bug Description

For bug 1791544 we are looking to simplify how/where we show side blocks.

but for now we need to fix up the problem where the 'tags' sideblock appears on the Admin -> Institution -> Settings page

This problem occurs because we match the start of a menuitem string and there is manage, eg 'manage/export' which is different to manageinstitutions, eg 'manageinstitutions/institutionusers'

We should match on 'manage/' instead of 'manage'

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 18.10rc2
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9226

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9226
Committed: https://git.mahara.org/mahara/mahara/commit/15bf6dd441c36ca2ca114137545aea785cf03546
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 15bf6dd441c36ca2ca114137545aea785cf03546
Author: Robert Lyon <email address hidden>
Date: Wed Oct 17 12:29:18 2018 +1300

Bug 1798217: Hiding 'tags' sideblock from admin section

behatnotneeded

Change-Id: Ia902165c8149db90b3b7affb4aa947397137a038
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9260

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9260
Committed: https://git.mahara.org/mahara/mahara/commit/90a44b53958f8cf7968bdb57cbef730b95f4290e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 90a44b53958f8cf7968bdb57cbef730b95f4290e
Author: Robert Lyon <email address hidden>
Date: Wed Oct 17 12:29:18 2018 +1300

Bug 1798217: Hiding 'tags' sideblock from admin section

behatnotneeded

Change-Id: Ia902165c8149db90b3b7affb4aa947397137a038
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 15bf6dd441c36ca2ca114137545aea785cf03546)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: In Progress → Fix Committed
milestone: 18.10rc2 → 18.10.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.