Mahara

Change the style for "Instructions"

Bug #1798223 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Liam
Mahara 18.10.0

Bug Description

The page and peer assessment block instructions should not have "Instructions" underlined, but look like the "Display page" link and icon: More weight, no underline and the icon a little closer to the text.

Tags: front-end
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

These two screenshots show the current state, not the ideal one.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9231

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
1. Page A exists and has description text and the instructions (found in page settings > advanced ) fields filled in
2. Page A is shared with public
3. Page B exists and has a text block and a peer review block with instructions
4. Page B is shared with UserA who has been given the role of peer

Test Steps:
1. Log in as UserA
2. Browse to Page A
3. Confirm that the Instructions accordion is displayed as follows
-- a. Instructions label has no underline ✔
-- b. Instructions weight is same as the Page description text ✔
-- c. the icon is a little closer to the text ✔
4. Browse to Page B
5. Click on the Add peer assessment link in the peer assessment block
6. Confirm the Instructions accordion in the Peer assessment fly out modal is displayed as follows
-- a. Instructions label has no underline ✔
-- b. Instructions weight is same as the Page description text ✔
-- c. the icon is a little closer to the text ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9231
Committed: https://git.mahara.org/mahara/mahara/commit/3ffc86dd673af0fe6fe0e9b5abfe9f0faf8661f0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 3ffc86dd673af0fe6fe0e9b5abfe9f0faf8661f0
Author: Liam <email address hidden>
Date: Wed Oct 17 14:28:03 2018 +1300

Bug #1798223: Change the style for "Instructions"

behatnotneeded

Change-Id: I5368ab3c90a7b7901607f4ff6021ed3b071e06d8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9262

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9262
Committed: https://git.mahara.org/mahara/mahara/commit/cec8761d6a375cb6b8ea9099affab774bec899fa
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit cec8761d6a375cb6b8ea9099affab774bec899fa
Author: Liam <email address hidden>
Date: Wed Oct 17 14:28:03 2018 +1300

Bug #1798223: Change the style for "Instructions"

behatnotneeded

Change-Id: I5368ab3c90a7b7901607f4ff6021ed3b071e06d8
(cherry picked from commit 3ffc86dd673af0fe6fe0e9b5abfe9f0faf8661f0)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: 18.10rc2 → 18.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.