Peer assessment qualities are lost when pages are added to a collection

Bug #1798932 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Mahara 18.10RC2

When pages are created outside of a collection and the peer role is given, the peer qualities, i.e. not displaying content in blocks are lost when they are added to a collection. I believe it is due to the fact that the user who is a peer is listed multiple times and even if they show all the peer role, the content was displayed.

To replicate:

1. Create 2 pages: 1 with a peer assessment, the other without. Place a text block with some text on both pages.
2. Give another user peer permissions on both pages.
Correct result: On the page with the peer assessment, only the block heading is displayed. On the page without the peer assessment, only the notice "You cannot see the content on this page because it does not require a peer assessment." is displayed.

3. Add the pages to a new collection.
Expected result: The pages are displayed as above for the peer assessor.
Actual result: The content of the pages is displayed to the peer assessor.

On the "Edit access" page, the name of the peer assessor appears twice (or however many pages were added) and it seems that they are cancelling each other out.

Also, when you remove the collection and look at the pages separately again, the content is displayed for the peer assessor even after removing one of the access lines. You need to remove both of them, save the page, and then add the permissions back in to get it to work properly.

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9251

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9251
Committed: https://git.mahara.org/mahara/mahara/commit/71c8efa88c2cf77dd669750798eb1b580ddac016
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 71c8efa88c2cf77dd669750798eb1b580ddac016
Author: Robert Lyon <email address hidden>
Date: Tue Oct 23 10:00:19 2018 +1300

Bug 1798932: Ignore ctime when compare different access rules

When merging rules for pages of a collection

behatnotneeded

Change-Id: I106dfa12c7836356f2c0e65e55fa68339919d0cb
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9257

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9257
Committed: https://git.mahara.org/mahara/mahara/commit/2285d7831291ec094986c1661001b910e9cdb03e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 2285d7831291ec094986c1661001b910e9cdb03e
Author: Robert Lyon <email address hidden>
Date: Tue Oct 23 10:00:19 2018 +1300

Bug 1798932: Ignore ctime when compare different access rules

When merging rules for pages of a collection

behatnotneeded

Change-Id: I106dfa12c7836356f2c0e65e55fa68339919d0cb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 71c8efa88c2cf77dd669750798eb1b580ddac016)

Changed in mahara:
milestone: 18.10rc2 → 18.10.0
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.