SRU 2.56.4 to bionic

Bug #1816547 reported by Marco Trevisan (Treviño)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glib2.0 (Ubuntu)
Fix Released
Medium
Unassigned
Bionic
Fix Released
Medium
Iain Lane

Bug Description

[ Description ]

New upstream bug fix microrelease

* Various buffer overflow fixes in GMarkup/GVariant/GDBus (#1582)

* Bug fixes:
 #1588 Moving a bookmark item to the same URI causes a crash
 #1582 Backport GMarkup/GVariant/GDBus fixes to glib-2-58 and glib-2-56

Plus fix for LP: #1760569

[ QA ]

Under the GNOME MRE, believe all bugs that upstream says are fixed are really fixed without explicitly verifying them.

https://wiki.ubuntu.com/StableReleaseUpdates/GNOME

Test various parts of the desktop.

  - Logging in
  - Shutting down
  - Starting a variety of apps and checking that they work
    + rhythmbox (play a song using gstreamer)
    + cheese (look at yourself with your webcam using gstreamer)
    + network-manager
    + epiphany (web stuff works)

Monitor the error tracker for any increases.

[ Regression potential ]

It's GLib. A regression could break the whole desktop, or any part of it... Our QA should help us have confidence that the update is at least not that bad.

Changed in glib2.0 (Ubuntu):
importance: Undecided → Medium
Iain Lane (laney)
Changed in glib2.0 (Ubuntu):
assignee: Iain Lane (laney) → nobody
status: Triaged → Fix Released
Changed in glib2.0 (Ubuntu Bionic):
assignee: nobody → Iain Lane (laney)
status: New → Triaged
importance: Undecided → Medium
Iain Lane (laney)
description: updated
description: updated
Changed in glib2.0 (Ubuntu Bionic):
status: Triaged → In Progress
Revision history for this message
Iain Lane (laney) wrote :

uploaded to the SRU queue, now we wait

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Marco, or anyone else affected,

Accepted glib2.0 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glib2.0/2.56.4-0ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in glib2.0 (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Iain Lane (laney) wrote :

bah, it failed on i386 and s390x:

Bail out! GLib:ERROR:../../../../glib/gvariant-serialiser.c:174:g_variant_serialised_check: assertion failed (alignment & (gsize) serialised.data == 0): (3 == 0)
ERROR: gvariant - Bail out! GLib:ERROR:../../../../glib/gvariant-serialiser.c:174:g_variant_serialised_check: assertion failed (alignment & (gsize) serialised.data == 0): (3 == 0)

I guess we need these from the branch:

* commit d202953c47284a17d03dd2d14b67756aa5edc872
|\ Merge: 8723aba59 4ef58e566
| | Author: Simon McVittie <email address hidden>
| | Date: Fri Jan 4 14:14:56 2019 +0000
| |
| | Merge branch 'backport-552-gvariant-test-alignment-glib-2-56' into 'glib-2-56'
| |
| | Backport tests: Allocate gvariant data from the heap to guarantee alignment to glib-2-56
| |
| | See merge request GNOME/glib!557
| |
| * commit 4ef58e5661849317a1110c9b93957f2c608677dd
| | Author: Simon McVittie <email address hidden>
| | Date: Thu Jan 3 08:21:40 2019 +0000
| |
| | gvariant test: Also force alignment for tuple test data
| |
| | glib!552 (commit 9eed22b3) fixed this for the tests that failed on i686,
| | but this additional test failed on Debian's s390x port
| | (IBM z/Architecture, 64-bit big-endian).
| |
| | Signed-off-by: Simon McVittie <email address hidden>
| |
| * commit 85c4031696add9797e2334ced20678edcd96c869
|/ Author: Mart Raudsepp <email address hidden>
| Date: Wed Dec 19 16:22:21 2018 +0200
|
| tests: Allocate gvariant data from the heap to guarantee alignment
|
| On glib-2-58 branch we don't have !455, thus we need aligned data
| for the gvariant tests to not fail on i686.
|
| Fixes #1626

probably.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Marco, or anyone else affected,

Accepted glib2.0 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glib2.0/2.56.4-0ubuntu0.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

As per GNOME MRE, package hit properly proposed.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

There's quite a few autopkgtest regressions reported for this upload. Can someone take a look at it and check if they're related? Thank you!

Revision history for this message
Iain Lane (laney) wrote :

Thanks, I retried them all and AFAICS they're all going to go green now (three are red at the minute but I looked at the output on the controller).

Revision history for this message
Iain Lane (laney) wrote :

yep, looks good to me nwo

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glib2.0 - 2.56.4-0ubuntu0.18.04.2

---------------
glib2.0 (2.56.4-0ubuntu0.18.04.2) bionic; urgency=medium

  * Backport upstream patches to fix GVariant alignment tests
    d/p/gvariant-test-Also-force-alignment-for-tuple-test-data.patch,
    d/p/tests-Allocate-gvariant-data-from-the-heap-to-guarantee-a.patch:
    Cherry-pick.

glib2.0 (2.56.4-0ubuntu0.18.04.1) bionic; urgency=medium

  * New upstream release (LP: #1816547)
    + Various buffer overflow fixes in GMarkup/GVariant/GDBus
    + Fix "Moving a bookmark item to the same URI causes a crash" (LP:
      #1760569)
  * debian/libglib2.0-0.symbols: New symbols

 -- Iain Lane <email address hidden> Fri, 22 Mar 2019 12:17:34 +0000

Changed in glib2.0 (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for glib2.0 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.