[SRU] modem-manager-gui fails to start after modemmanager is upgraded to 1.10.0-1

Bug #1820130 reported by David Kastrup
32
This bug affects 3 people
Affects Status Importance Assigned to Milestone
modem-manager-gui (Debian)
Fix Released
Unknown
modem-manager-gui (Ubuntu)
Fix Released
Medium
Unassigned
Bionic
Fix Released
Undecided
Unassigned
Disco
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
After modemmanager is upgraded to 1.10.0-1, modem-manager-gui crashes at startup for users with modems with 3gpp location capability.

[Test Case]
Attempt to start modem-manager-gui with a modem with 3gpp location capability plugged in, modem-manager-gui should crash with:
free(): invalid pointer
Aborted (core dumped)

[Regression Potential]
Minimal; modem-manager-gui is a leaf package.
The new code in:
https://bitbucket.org/linuxonly/modem-manager-gui/commits/6710bf86869852bb8a9946b628eff5bc1019b5aa/
is guarded by:
if ((locationtype == MODULE_INT_MODEM_LOCATION_CAPABILITY_GSM_LAC_CI) && (locationdata != NULL))
so should not be able to regress for users with modems without location capability, who would not have experienced this issue.

-----------------------------------------------------------------------------

No idea since when it does that. Must be some Disco Dingo problem.

ProblemType: Crash
DistroRelease: Ubuntu 19.04
Package: modem-manager-gui 0.0.19.1-1build1
ProcVersionSignature: Ubuntu 5.0.0-7.8-lowlatency 5.0.0
Uname: Linux 5.0.0-7-lowlatency x86_64
ApportVersion: 2.20.10-0ubuntu23
Architecture: amd64
AssertionMessage: munmap_chunk(): invalid pointer
CrashCounter: 1
CurrentDesktop: XFCE
Date: Thu Mar 14 22:44:38 2019
ExecutablePath: /usr/bin/modem-manager-gui
InstallationDate: Installed on 2011-10-14 (2708 days ago)
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release i386 (20111011)
ProcCmdline: modem-manager-gui
Signal: 6
SourcePackage: modem-manager-gui
StacktraceTop:
 __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7f8a1b39b952 "%s\n") at ../sysdeps/posix/libc_fatal.c:181
 malloc_printerr (str=str@entry=0x7f8a1b39d5a0 "munmap_chunk(): invalid pointer") at malloc.c:5352
 munmap_chunk (p=<optimized out>) at malloc.c:2840
 () at /usr/lib/x86_64-linux-gnu/modem-manager-gui/modules/libmodmm_mm07.so
 mmgui_module_devices_information () at /usr/lib/x86_64-linux-gnu/modem-manager-gui/modules/libmodmm_mm07.so
Title: modem-manager-gui assert failure: munmap_chunk(): invalid pointer
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm admin audio cdrom dialout fax floppy lpadmin lxd plugdev pulse-access sambashare
separator:

Revision history for this message
David Kastrup (dak) wrote :
information type: Private → Public
Revision history for this message
Apport retracing service (apport) wrote :

StacktraceTop:
 __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7f8a1b39b952 "%s\n") at ../sysdeps/posix/libc_fatal.c:181
 malloc_printerr (str=str@entry=0x7f8a1b39d5a0 "munmap_chunk(): invalid pointer") at malloc.c:5352
 munmap_chunk (p=<optimized out>) at malloc.c:2840
 mmgui_module_devices_update_location (mmguicore=mmguicore@entry=0x55e1c841eeb0, device=device@entry=0x55e1c849d690) at mm07.c:1692
 mmgui_module_devices_update_location (device=0x55e1c849d690, mmguicore=0x55e1c841eeb0) at mm07.c:2013

Revision history for this message
Apport retracing service (apport) wrote : Stacktrace.txt
Revision history for this message
Apport retracing service (apport) wrote : StacktraceSource.txt
Revision history for this message
Apport retracing service (apport) wrote : ThreadStacktrace.txt
Changed in modem-manager-gui (Ubuntu):
importance: Undecided → Medium
tags: removed: need-amd64-retrace
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: modem-manager-gui assert failure: munmap_chunk(): invalid pointer

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in modem-manager-gui (Ubuntu):
status: New → Confirmed
Revision history for this message
Jan (ijonfryderyk) wrote :

Same on Ubuntu 18.04 (4.18.0-20-generic), Modem Manager Gui(0.0.19.1-1).
This bug probably revealed another one – Modem Manager Gui prevents from suspend on Ubuntu 18.04 when mobile network connected and no WiFi connection.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1826461

Revision history for this message
Graham Inggs (ginggs) wrote :

This sounds a lot like Debian bug #922608 [1] which is fixed in Eoan.

Disco got modemmanager 1.10.0-1 on 2019-02-23, and Bionic got the backport on 2019-05-16.

Please try the version of modem-manager-gui from my PPA [2] and if this solves the problem we can prepare a Stable Release Update for Disco and Bionic.

[1] https://bugs.debian.org/922608
[2] https://launchpad.net/~ginggs/+archive/ubuntu/sru

Revision history for this message
David Kastrup (dak) wrote :

I've since updated to Eoan. Don't know under what circumstances the bug triggers exactly but startup here appears to work currently.

Revision history for this message
Jan (ijonfryderyk) wrote :

Hi Graham, I have installed modem-manager-gui from your PPA. It solves the problem. But unfortunately my problem with suspend is still present.
Modem-manager-gui in specific circumstances blocks system from suspend.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1826461

Graham Inggs (ginggs)
Changed in modem-manager-gui (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Graham Inggs (ginggs) wrote :

I don't think Cosmic needs to be targeted as it does not have modemmanager 1.10.

Graham Inggs (ginggs)
summary: - modem-manager-gui assert failure: munmap_chunk(): invalid pointer
+ [SRU] modem-manager-gui fails to start after modemmanager is upgraded to
+ 1.10.0-1
Graham Inggs (ginggs)
description: updated
Graham Inggs (ginggs)
Changed in modem-manager-gui (Ubuntu Bionic):
status: New → In Progress
Changed in modem-manager-gui (Ubuntu Disco):
status: New → In Progress
Changed in modem-manager-gui (Debian):
status: Unknown → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

The "Regression Potential" portion of the SRU template is to indicate how things might go wrong to improve testing of the Stable Release Update. Can you please update the regression potential with something that meets that criteria?

Changed in modem-manager-gui (Ubuntu Disco):
status: In Progress → Incomplete
Graham Inggs (ginggs)
description: updated
Changed in modem-manager-gui (Ubuntu Disco):
status: Incomplete → In Progress
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello David, or anyone else affected,

Accepted modem-manager-gui into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/modem-manager-gui/0.0.19.1-1ubuntu0.19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in modem-manager-gui (Ubuntu Disco):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-disco
Changed in modem-manager-gui (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello David, or anyone else affected,

Accepted modem-manager-gui into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/modem-manager-gui/0.0.19.1-1ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Jan (ijonfryderyk) wrote :

Hi Timo, is this package the same that was in Graham PPA https://launchpad.net/~ginggs/+archive/ubuntu/sru? I've already tested it and it fixes the bug.

Revision history for this message
Graham Inggs (ginggs) wrote :

Hi Jan
Yes, this package should be identical to the one in my PPA, but please test again with the official version from the archive.

Would you be willing to test the Disco version as well please? I am unable to do the verification as I don't have an affected modem.

Revision history for this message
Jan (ijonfryderyk) wrote :

modem-manager-gui (0.0.19.1-1ubuntu0.18.04.1) bionic-proposed – tested, fixes the bug.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Jan (ijonfryderyk) wrote :

Graham, I'm on Bionc. Can I test the disco package on bionic?

Revision history for this message
Graham Inggs (ginggs) wrote :

Jan, no the Disco package needs to be tested on Disco. If you don't have access to another computer, a live CD, or virtual machine with USB pass-through could work.

Revision history for this message
Graham Inggs (ginggs) wrote :

We still need someone to perform the verification in Disco.

Revision history for this message
Mattia Rizzolo (mapreri) wrote :

I tested in disco, 0.0.19.1-1build1 crashes as described, 0.0.19.1-1ubuntu0.19.04.1 does not.

tags: added: verification-disco-disco verification-done
removed: verification-needed verification-needed-disco
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package modem-manager-gui - 0.0.19.1-1ubuntu0.18.04.1

---------------
modem-manager-gui (0.0.19.1-1ubuntu0.18.04.1) bionic; urgency=medium

  * Backport fixes from 0.0.19.1-2 in Eoan (LP: #1820130)
    - Fix memory corruption because of wrong strsep() usage (Closes: #922608)
    - Fix segfault in strftime_l() because of timestamps from future

 -- Graham Inggs <email address hidden> Sun, 02 Jun 2019 11:21:07 +0000

Changed in modem-manager-gui (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for modem-manager-gui has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

tags: added: verification-done-disco
removed: verification-disco-disco
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package modem-manager-gui - 0.0.19.1-1ubuntu0.19.04.1

---------------
modem-manager-gui (0.0.19.1-1ubuntu0.19.04.1) disco; urgency=medium

  * Backport fixes from 0.0.19.1-2 in Eoan (LP: #1820130)
    - Fix memory corruption because of wrong strsep() usage (Closes: #922608)
    - Fix segfault in strftime_l() because of timestamps from future

 -- Graham Inggs <email address hidden> Sun, 02 Jun 2019 11:25:16 +0000

Changed in modem-manager-gui (Ubuntu Disco):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.