FTBFS with gcc-8

Bug #1821803 reported by Andreas Hasenack
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
boost1.67 (Debian)
Fix Released
Unknown
boost1.67 (Ubuntu)
Fix Released
Undecided
Unassigned
Cosmic
Fix Released
High
Andreas Hasenack

Bug Description

[Impact]

There is an FTBFS with boost1.67 in cosmic that is fixed in disco already via this patch[1].

This FTBFS prevents boost1.67 in cosmic from ever being SRUed. Such an SRU need has showed up[2].

[Test Case]
Build boost1.67 in cosmic. Without this fix, the build fails.

[Regression Potential]
Patch is applied upstream and in disco already. Bug was caused by newly introduced gcc8 checks, and one such check is being fixed.

[Other Info]
Not at this time.

[Original Description]

There is an FTBFS with boost1.67 in cosmic that is fixed in disco via this patch[1]:

From fdbdb94db64e888fce90fe519be23c2a4396a82e Mon Sep 17 00:00:00 2001
From: pradeep <email address hidden>
Date: Tue, 8 May 2018 14:53:38 +0530
Subject: [PATCH 1/2] Fix return var qualifier in svm_ptr::get_context

Lack of `const` qualifier is throwing errors with GCC 8.1
---
 include/boost/compute/memory/svm_ptr.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/boost/compute/memory/svm_ptr.hpp b/include/boost/compute/memory/svm_ptr.hpp
index c8753f5b..56cf1268 100644
--- a/libs/compute/include/boost/compute/memory/svm_ptr.hpp
+++ b/libs/compute/include/boost/compute/memory/svm_ptr.hpp
@@ -126,7 +126,7 @@ class svm_ptr
         return m_ptr - other.m_ptr;
     }

- context& get_context() const
+ const context& get_context() const
     {
         return m_context;
     }

1. https://git.launchpad.net/~usd-import-team/ubuntu/+source/boost1.67/tree/debian/patches/fix-boost-compute-gcc8-ftbfs.patch?h=ubuntu/disco-devel
2. https://bugs.launchpad.net/ubuntu/+source/boost1.67/+bug/1821762

Related branches

Changed in boost1.67 (Ubuntu):
status: New → Fix Released
Changed in boost1.67 (Ubuntu Cosmic):
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → In Progress
importance: Undecided → High
Changed in boost1.67 (Debian):
status: Unknown → Fix Released
description: updated
description: updated
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Andreas, or anyone else affected,

Accepted boost1.67 into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/boost1.67/1.67.0-7ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in boost1.67 (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

boost1.67-1.67.0-7ubuntu0.1 built in cosmic-proposed:
https://launchpad.net/ubuntu/+source/boost1.67/1.67.0-7ubuntu0.1

There is a dep8 failure in mothur/i386, though. I have retried a few times but it won't go away. It's very weird actually:

mothur > cluster(method=furthest, column=HA.unique.dist, name=HA.names, cutoff=0.01, precision=1000)
The precision parameter can only take powers of 10 as a value (e.g. 10,1000,1000, etc.)

As can be seen, precision was given a value of "1000", which is correct. Maybe a math rounding error of some sort is happening? Can't imagine what would be different in the launchpad tester. This is the code:

if(parameter.compare("precision") == 0) {
        double logNum = log10((double)pVal);
        double diff = (double)((int)logNum - logNum);
        if(diff != 0) {
                m->mothurOut("The precision parameter can only take powers of 10 as a value (e.g. 10,1000,1000, etc.)\n");
                return false;
        }
}

I ran the test suite locally on a cosmic/i386 VM, with and without proposed packages installed, and it passes every time. I could try bileto, see if it fails there, and if it does, add some extra debugging information, but that will take a while.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

log of a local dep8 run on cosmic/i386 with proposed enabled

tags: added: verification-done-cosmic
removed: verification-needed-cosmic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for boost1.67 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package boost1.67 - 1.67.0-7ubuntu0.1

---------------
boost1.67 (1.67.0-7ubuntu0.1) cosmic; urgency=medium

  * d/p/boostorg-program_options-pull-59.patch: pulled in patch from disco to
    fix regression (vs 1.66.0 and older) to allow argc == 0 (LP: #1821762)
  * d/p/fix-boost-compute-gcc8-ftbfs.patch: Fix FTBFS in boost.compute with
    GCC-8 (LP: #1821803)

 -- Andreas Hasenack <email address hidden> Tue, 26 Mar 2019 17:06:29 -0300

Changed in boost1.67 (Ubuntu Cosmic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.