[SRU] blender: erases photoshop files

patches sponsored in bionic/cosmic/disco

@guismo, can you please try blender from here?
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+packages

thanks! I uploaded in the official ubuntu repository for review, this is for sure candidate for a stable upload!
thanks for reporting the bug

Hello Gianfranco, or anyone else affected,

Accepted blender into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/blender/2.79.b+dfsg0-6ubuntu1.19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Gianfranco, or anyone else affected,

Accepted blender into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/blender/2.79.b+dfsg0-4ubuntu1.18.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Gianfranco, or anyone else affected,

Accepted blender into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/blender/2.79.b+dfsg0-1ubuntu1.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Sorry Gianfranco, I don't know why I didn't receive your request to test by email. I received the others.

So, first thing, trying to install it through synaptic after enabling the proposed repository I get this message:
"W: Download is performed unsandboxed as root as file '/root/.synaptic/tmp//tmp_cl' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)"

Never got that before.

Regarding the .psd bug, it seems to be solved on my ubuntu-mate 18.04.2 LTS 64 bits. My other systems are the same so it will be hard to test on other versions.

The other thing is that looking for a .psd to test on older projects I discovered that many more .psd files have been destroyed than I thought... I must have accessed those folders while looking for other things.

I wonder if more people were affecting by that and don't realize they have a non functional archive and if there is something that can be done to warn them to make sure they get a backup, if they have.

Maybe it's possible to give a warning to those who downloaded Blender since the bug was active?

>Sorry Gianfranco, I don't know why I didn't receive your request to test by email. I received >the others.

no problem!

>So, first thing, trying to install it through synaptic after enabling the proposed repository I >get this message:
>"W: Download is performed unsandboxed as root as file '/root/.synaptic/tmp//tmp_cl' couldn't be >accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)"
>
>Never got that before.

I'm not worries, this might be something related to a lock not being cleared, not related to this bug...

>Regarding the .psd bug, it seems to be solved on my ubuntu-mate 18.04.2 LTS 64 bits. My other >systems are the same so it will be hard to test on other versions.

nice to know!
>The other thing is that looking for a .psd to test on older projects I discovered that many more >.psd files have been destroyed than I thought... I must have accessed those folders while >looking for other things.
>
>I wonder if more people were affecting by that and don't realize they have a non functional >archive and if there is something that can be done to warn them to make sure they get a backup, >if they have.
>
>Maybe it's possible to give a warning to those who downloaded Blender since the bug was active?

not sure, I'll forward this to the Debian developer.

Can you please tell me the "exact" steps to reproduce the problem?
(where to click on the gui), so I can check if the other fixes are working properly!

steps performed on cosmic/disco
1) downloaded this file:
https://developer.blender.org/T63045
2) copied in disco and cosmic chroots
3) installed blender
4) run blender
5) click "open file"
6) go in the directory with the psd file (68.4k)
7) click to enable preview "show image files"
8) click to show files as thumbnails (mode list)
9) open it
10) close blender
ls -l diagonaloriginal.psd
-rw-r--r-- 1 root root 70030 May 2 10:36 diagonaloriginal.psd

I consider this bug fixed.
I hope this is the right approach to check for this bug!

I don't see any indication that Bionic testing was done so I'm flipping that tag back.

This bug was fixed in the package blender - 2.79.b+dfsg0-6ubuntu1.19.04.1

---------------
blender (2.79.b+dfsg0-6ubuntu1.19.04.1) disco; urgency=medium

  * debian/patches/0007-fix_OpenJPEG2_build.patch:
    fix disruptive change (Closes: #927809, LP: #1826180)

 -- Gianfranco Costamagna <email address hidden> Wed, 24 Apr 2019 12:21:57 +0200

The verification of the Stable Release Update for blender has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package blender - 2.79.b+dfsg0-4ubuntu1.18.10.1

---------------
blender (2.79.b+dfsg0-4ubuntu1.18.10.1) cosmic; urgency=medium

  * debian/patches/0007-fix_OpenJPEG2_build.patch:
    fix disruptive change (Closes: #927809, LP: #1826180)

 -- Gianfranco Costamagna <email address hidden> Wed, 24 Apr 2019 12:20:35 +0200

Thank you for taking the time to verify this stable release fix. We have noticed that you have used the verification-done tag for marking the bug as verified and would like to point out that due to a recent change in SRU bug verification policy fixes now have to be marked with per-release tags (i.e. verification-done-$RELEASE). Please remove the verification-done tag and add one for the release you have tested the package in. Thank you!

https://wiki.ubuntu.com/StableReleaseUpdates#Verification

Hi Gianfranco, sorry. Again I didn't see your comments. I only get email when other people post here.

I attached another .psd file but I forgot I had included another smaller one on the blender thread. Either way both can be used to test.

Regarding the steps, there is one mistake. Blender is very confusing. When you open file on the main menu, it will only show .blend files (it will only open those). To see image files you need to use the image tab.

STEPS:

1-Open blender
2-change the main, bigger window that has a cube and camera to the image viewer. To do so, click on the lowest left button of that window (by default the view will be made of many windows, the lowest one is a timeline, I'm talking about the biggest one). The button should have a little cube on it, like the one present on the biggest window. Change it to "UV/Image Editor".
3-That window should change, including the menu where the button is located. Use THAT new menu to open and browse for the PSD file (be careful that if it's not patched every .psd you view will be erased).
4-While browsing, change to thumbnail mode (using the top buttons on that window). That's optional, OR
4b- Open a .psd with that window.

If you can actually see the .psd file, the bug is fixed. If it's black or you can't see the file, it's zeroed and destroyed, you need to use another .psd to test again.

On my computer, Ubuntu 18.04.2 LTS bionic, with the new patched blender, the problem is fixed. The PSD is not destroyed.

Let me know if this helps.

Bionic is ok, according to previous comment!

I can confirm the fix on my laptop too, with the above psd file

This bug was fixed in the package blender - 2.79.b+dfsg0-1ubuntu1.18.04.1

---------------
blender (2.79.b+dfsg0-1ubuntu1.18.04.1) bionic; urgency=medium

  * debian/patches/0007-fix_OpenJPEG2_build.patch:
    fix disruptive change (Closes: #927809, LP: #1826180)

 -- Gianfranco Costamagna <email address hidden> Wed, 24 Apr 2019 12:17:52 +0200