The Site admin email for new registrants is sent in wrong language

ADDITIONAL TESTING
====================
Can you please check if that was the same before we made the security update? Please ask Cecilia how you can check out 18.04.3. since i saw the issue on mahara.org, which runs on 18.04.4 now, we need to go back to the previous minor point release to see if the problem was there already or if is an issue that was introduced with the latest bug fixes.

Commit hash: N/A
Environment tested: 18.04.3
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Site with a couple of languages installed (German French & English)
2) Site options for Institutions - "Confirm registration" toggle is set to = Yes (Force all institutions to approve new self-registered accounts)
3) Institution Exists (Institution One) and has the following
a) Registration allowed toggle is set to = Yes
4) Site admin's preferred language is set to English

TEST STEPS:
------------------------
1) Person wanting to register for an account changes the interface language to something other than english (site admin stays on english) and registers for an account.
2) Verify Site admin receives an email message in the language that the Site admin has set.

EXPECTED RESULT:
1) The admin should get the notification in the language they have set, not the one that the registrant had set.
2) The registrant should receive an email of their registration in the same language they used when submitting the application.

ACTUAL RESULT:
1) The languages sent to the Admin are the languages that the Registrant registered in & The languages sent to the Registrant are the languages that the Registrant registered in ✘
2) The registrant received an email of their registration in the same language they used when submitting the application.✔

Catalyst QA Failed Testing ✘

This is also the case of other emails, e.g. forum notifications. Steven, can you please test the following?

Site language is in te reo Māori. Use the "Send now" function on the post to get the notification more quickly.

Scenario 1: Personal setting of the person posting a forum post is English. Personal setting of second group member is te reo Māori. Personal setting of third group member is French. What's the language in which the post is seen by these three when they get the notification?

Scenario 2: Personal setting of the person posting a forum post is English. Personal setting of second group member is te reo Māori. Personal setting of third group member is French. What's the language in which the post is seen by these three when they get the notification?

Scenario 3: Personal setting of the person posting a forum post is te reo Māori. Personal setting of second group member is English. Personal setting of third group member is French. What's the language in which the post is seen by these three when they get the notification?

Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS: Scenario 1
------------------------
1) Personal setting of the person posting a forum post is English. (Mahara User1)
2) Personal setting of second group member is te reo Māori. (Mahara User2)
3) Personal setting of third group member is French. (Mahara User3)
4) Group exists as follows:
    a) Owner = (Mahara User1- English)
    b) Group Forum (Forum1) and topic (Topic1) exists

TEST STEPS:
------------------------
1) What's the language in which the post is seen by these three when they get the notification?
    a) User1 (English) = English
    b) User2 (Māori) = Maori
    c) User3 (French) = French

+++++++++++++++++++++++++++++++++++++++++++

PRECONDITIONS: Scenario 2
------------------------
1) Personal setting of the person posting a forum post is te reo Māori (Mahara User2)
2) Personal setting of second group member is English. (Mahara User1)
3) Personal setting of third group member is French. (Mahara User3)
4) Group exists as follows:
    a) Owner = (Mahara User2 - Maori)
    b) Group Forum (Forum1) and topic (Topic1) exists

TEST STEPS:
------------------------
1) What's the language in which the post is seen by these three when they get the notification?
    a) User1 (English) = English
    b) User2 (Māori) = Maori
    c) User3 (French) = French

Patch for "master" branch: https://reviews.mahara.org/10134

Commit hash: 1dd1bdf98e6e4d5aec54a58b2d3f5a624bfb692f
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) The following languages are installed on the Mahara site
   a) English
   b) German: Deutsch
   c) Basque: Euskara
   d) French: Français
   e) Māori
   f) Slovakia: Slovensko
   g) Japanese: 日本語
2) Institution exists with the following settings
   a) Registration allowed = yes
   b) Confirm registration = yes
3) Site admin has language set to English

TEST STEPS:
------------------------
1) New student registers in "German: Deutsch" Language
2) New student registers in "Basque: Euskara" Language
3) New student registers in "French: Français" Language
4) New student registers in "Māori" Language
5) New student registers in "Slovakia: Slovensko" Language
6) New student registers in "Japanese: 日本語" Language
7) Verify that the registrant receives and email in the language that they registered in ✔
8) Verify that the Site admin receives an email for each of the students registering in English ✔
9) Log in as Site admin ensure that new users are approved for registration into Instution
10) Ensure that each new user logs in and sets password so they are registered
11) Browse to main menu > Engage > People
12) Request friendship from each of the new students
13) Verify that the user receives and email in the language that they registered in ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/10134
Committed: https://git.mahara.org/mahara/mahara/commit/8af3a59933d9b31997a33d2086146b37315e8545
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8af3a59933d9b31997a33d2086146b37315e8545
Author: Doris Tam <email address hidden>
Date: Wed Jun 26 18:21:12 2019 +1200

Bug 1827812: Ensure people receive notifications in their preferred language

'Preferred language' is the language they set in their account settings.

It does not mean that text that is written in a different language is
translated automatically. Only Mahara provided language strings are
of concern here.

Note: Preferred language can be changed if user changes language via
the language switcher before logging in

behatnotneeded

Change-Id: I9eebd522bfc222c0dbfa87c5ca5217f4a50d402b

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10186

Reviewed: https://reviews.mahara.org/10186
Committed: https://git.mahara.org/mahara/mahara/commit/6eb1106f027aac6e074468ca62c31c80b139af71
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 6eb1106f027aac6e074468ca62c31c80b139af71
Author: Doris Tam <email address hidden>
Date: Wed Jun 26 18:21:12 2019 +1200

Bug 1827812: Ensure people receive notifications in their preferred language

'Preferred language' is the language they set in their account settings.

It does not mean that text that is written in a different language is
translated automatically. Only Mahara provided language strings are
of concern here.

Note: Preferred language can be changed if user changes language via
the language switcher before logging in

behatnotneeded

Change-Id: I9eebd522bfc222c0dbfa87c5ca5217f4a50d402b
(cherry picked from commit 8af3a59933d9b31997a33d2086146b37315e8545)