Ubuntu
yaru-theme package

Switches are gone from the VPN menu

Bug #1829699 reported by Jean-Baptiste Lallement
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
yaru-theme (Ubuntu)
Fix Released
Low
Iain Lane
Disco
Fix Released
Low
Iain Lane
Eoan
Fix Released
Low
Iain Lane

Bug Description

[ Description ]

There is no more switch in the system menu for the VPN entries. Although the VPN can still be turned on/off by clicking on the menu entry (cf screenshot)

[ Fix ]

GNOME Shell 3.32.1 shuffled some theme bits around. Yaru generally needs to follow Shell's changes to remain compatible. The fix is to sync those changes and make the corresponding modifications to Yaru.

NOTE: there are changes in the gnome-shell/upstream directory for this. These are not shipped anywhere. Yaru keeps a copy of the upstream theme it's currently based on for three way merging purposes.

[ QA ]

With multiple VPNs configured, check that you get switches in the top-right menu. Check the attached screenshot for reference.

[ Regression potential ]

As with any theme change, this could accidentally break other parts of the shell (probably subtly given the nature of the change). This particular change is in the shell - not the GTK - theme, so look out for breakage there.

[ ... ]

ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: gnome-shell 3.32.1-1ubuntu1
ProcVersionSignature: Ubuntu 5.0.0-13.14-generic 5.0.6
Uname: Linux 5.0.0-13-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.10-0ubuntu27
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon May 20 06:48:13 2019
DisplayManager: gdm3
InstallationDate: Installed on 2014-07-15 (1769 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: gnome-shell
UpgradeStatus: Upgraded to eoan on 2018-03-24 (421 days ago)

See original description
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Jean-Baptiste Lallement (jibel)
tags: added: rls-ee-incoming
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I guess this is a new bug in gnome-shell 3.32.1, if it didn't exist in 3.32.0...?

Revision history for this message
Sebastien Bacher (seb128) wrote :

Could you add your journalctl log to the bug?
3.32.1 is also in disco-proposed so it would be good to also test if the problem exist there/is really with gnome-shell

Changed in gnome-shell (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Iain Lane (laney) wrote :

I checked the commits and found that toggle switches had some changes in 3.32.1 - yaru needs to be rebased to get these working again.

See: https://github.com/ubuntu/yaru/pull/1369

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Yes it's difinetely a yaru thing.

affects: gnome-shell (Ubuntu) → yaru-theme (Ubuntu)
Iain Lane (laney)
Changed in yaru-theme (Ubuntu):
status: Incomplete → Triaged
Changed in yaru-theme (Ubuntu Disco):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Iain Lane (laney)
Changed in yaru-theme (Ubuntu):
assignee: nobody → Iain Lane (laney)
Iain Lane (laney)
description: updated
Iain Lane (laney)
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Jean-Baptiste, or anyone else affected,

Accepted yaru-theme into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yaru-theme/19.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in yaru-theme (Ubuntu Disco):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-disco
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 19.04.3

---------------
yaru-theme (19.04.3) disco; urgency=medium

  * gbp.conf: Update branch for ubuntu/disco
  * Sync Yaru with changes in GNOME Shell 3.32.1
    - Fixes switches in VPN submenu (LP: #1829699)
    - Fixes region screenshots (Shift + Print Screen) not displaying the
      region properly (LP: #1830003)
    - Fixes 1px gap next to some lists (e.g. gnome-control-center's users
      panel) (LP: #1830203)
    - Fixes clock on lock screen not being very readable with very bright
      backgrounds (LP: #1830335)

 -- Iain Lane <email address hidden> Fri, 24 May 2019 09:36:47 +0100

Changed in yaru-theme (Ubuntu Eoan):
status: Triaged → Fix Released
Revision history for this message
Iain Lane (laney) wrote :

Verified with yaru-theme 19.04.3.

tags: added: verification-done verification-done-disco
removed: verification-needed verification-needed-disco
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 19.04.3

---------------
yaru-theme (19.04.3) disco; urgency=medium

  * gbp.conf: Update branch for ubuntu/disco
  * Sync Yaru with changes in GNOME Shell 3.32.1
    - Fixes switches in VPN submenu (LP: #1829699)
    - Fixes region screenshots (Shift + Print Screen) not displaying the
      region properly (LP: #1830003)
    - Fixes 1px gap next to some lists (e.g. gnome-control-center's users
      panel) (LP: #1830203)
    - Fixes clock on lock screen not being very readable with very bright
      backgrounds (LP: #1830335)

 -- Iain Lane <email address hidden> Fri, 24 May 2019 09:36:47 +0100

Changed in yaru-theme (Ubuntu Disco):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for yaru-theme has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.