Exclude group tutors and admins from showing under "Members without a submission to the group"

Bug #1831415 reported by Kristina Hoeppner
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Doris Tam

Bug Description

When you set up a group that allows submissions (need to have admin or staff permissions in Mahara), you see all group members.

However, it would be better not to show group tutors and admins as they usually do not need to submit portfolios.

Instead of making it a configurable option, it would be sufficient to simply not show group tutors and admins.

Group tutors only come into play when a group is set up as "course" group. Thus, both sets of groups will need to be tested.

They still need to show up under those people that have submitted portfolios if they do do so at some stage.

1. Create a standard group that allows submissions and set the group settings to "controlled".
2. Add 10 people to the group.
3. Make one of them a group admin.
4. Go to the group homepage and see who is listed under "Members without a submission to the group".
Expected result: You only see the regular group members.
Actual result: You also see the 2 group admins.

5. Change the group settings to "course" group, which now allows you to set up a group tutor.
6. Change the role of a regular group member to that of a tutor.
7. Go to the group homepage and see who is listed under "Members without a submission to the group".
Expected result: You only see the regular group members.
Actual result: You also see the 2 group admins and the tutor.

tags: added: groups
Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11487

Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
Changed in mahara:
milestone: none → 21.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11487
Committed: https://git.mahara.org/mahara/mahara/commit/f44a8f45ed1316dbb06516e959ba628fa321107d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f44a8f45ed1316dbb06516e959ba628fa321107d
Author: Doris Tam <email address hidden>
Date: Thu Dec 3 16:22:32 2020 +1300

Bug 1831415: Add condition in the query for role of people who have not submitted pages in group

Added a condition for the role to be 'member' so that admins and tutors do not show up
in the 'members without a submission to the group' list.

Modified method documentation comments to match.

Change-Id: Ie63483d36e26766800ecc65b3802d8e9c712c37b

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.