Ubuntu
linux-raspi2 package

bcm2835-sdhost: Lots of Compile warnings

Bug #1847432 reported by Juerg Haefliger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-raspi2 (Ubuntu)
New
Undecided
Unassigned
Bionic
Fix Released
Low
Juerg Haefliger

Bug Description

[Impact]

Compiling Bionic 4.15 linux-raspi2 yields:

In file included from ./include/linux/kernel.h:14:0,
                 from ./include/linux/delay.h:22,
                 from drivers/mmc/host/bcm2835-sdhost.c:35:
drivers/mmc/host/bcm2835-sdhost.c: In function 'log_init':
./include/linux/kern_levels.h:5:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
 #define KERN_SOH "\001" /* ASCII Start Of Header */
                  ^
./include/linux/printk.h:309:9: note: in definition of macro 'pr_printk_hash'
  printk(level pr_fmt(format), ##__VA_ARGS__)
         ^~~~~
./include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
 #define KERN_INFO KERN_SOH "6" /* informational */
                   ^~~~~~~~
./include/linux/printk.h:333:17: note: in expansion of macro 'KERN_INFO'
  pr_printk_hash(KERN_INFO, fmt, ##__VA_ARGS__)
                 ^~~~~~~~~
drivers/mmc/host/bcm2835-sdhost.c:249:3: note: in expansion of macro 'pr_info'
   pr_info("sdhost: log_buf @ %p (%x)\n",
   ^~~~~~~
drivers/mmc/host/bcm2835-sdhost.c:249:35: note: format string is defined here
   pr_info("sdhost: log_buf @ %p (%x)\n",
                                  ~^
                                  %llx
drivers/mmc/host/bcm2835-sdhost.c: In function 'bcm2835_sdhost_dma_complete':
drivers/mmc/host/bcm2835-sdhost.c:530:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  log_event("DMA<", (u32)host->data, bcm2835_sdhost_read(host, SDHSTS));
                    ^
[SNIP]

[Test Case]

Compile Bionic raspi2 kernel.

[Fix]

Backport commit 328c7a754fde ("mmc: bcm2835-sdhost: Fix warnings on arm64") from raspberry/linux rpi-4.19.y.

[Regression Potential]

Low. Trivial modifications isolated to bcm2835-sdhost.

See original description
Juerg Haefliger (juergh)
Changed in linux-raspi2 (Ubuntu Bionic):
importance: Undecided → Low
status: New → Confirmed
assignee: nobody → Juerg Haefliger (juergh)
Juerg Haefliger (juergh)
description: updated
Khaled El Mously (kmously)
Changed in linux-raspi2 (Ubuntu Bionic):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (42.4 KiB)

This bug was fixed in the package linux-raspi2 - 4.15.0-1053.57

---------------
linux-raspi2 (4.15.0-1053.57) bionic; urgency=medium

  * bionic/linux-raspi2: 4.15.0-1053.57 -proposed tracker (LP: #1854793)

  * Bionic update: upstream stable patchset 2019-11-21 (LP: #1853519)
    - raspi2: [Config] CONFIG_SGL_ALLOC=y

  * update ENA driver for DIMLIB dynamic interrupt moderation (LP: #1853180)
    - raspi2: [Config] disable CONFIG_DIMLIB

  * bcm2835-sdhost: Lots of Compile warnings (LP: #1847432)
    - mmc: bcm2835-sdhost: Fix warnings on arm64

  * Raspberry Pi 3B plus cpuinfo (LP: #1823151)
    - arch/arm64: Add Revision, Serial, Model to cpuinfo

  * Conflicting mmc modules built in (LP: #1762835)
    - [Config] raspi2: Remove upstream mmc modules

  [ Ubuntu: 4.15.0-73.82 ]

  * bionic/linux: 4.15.0-73.82 -proposed tracker (LP: #1854819)
  * CVE-2019-14901
    - SAUCE: mwifiex: Fix heap overflow in mmwifiex_process_tdls_action_frame()
  * CVE-2019-14896 // CVE-2019-14897
    - SAUCE: libertas: Fix two buffer overflows at parsing bss descriptor
  * CVE-2019-14895
    - SAUCE: mwifiex: fix possible heap overflow in mwifiex_process_country_ie()
  * CVE-2019-18660: patches for Ubuntu (LP: #1853142) // CVE-2019-18660
    - powerpc/64s: support nospectre_v2 cmdline option
    - powerpc/book3s64: Fix link stack flush on context switch
    - KVM: PPC: Book3S HV: Flush link stack on guest exit to host kernel
  * Please add patch fixing RK818 ID detection (LP: #1853192)
    - SAUCE: mfd: rk808: Fix RK818 ID template
  * [SRU][B/OEM-B/OEM-OSP1/D] Enable new Elan touchpads which are not in current
    whitelist (LP: #1853246)
    - HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630
    - Input: elan_i2c - export the device id whitelist
    - HID: quirks: Refactor ELAN 400 and 401 handling
  * Lenovo dock MAC Address pass through doesn't work in Ubuntu (LP: #1827961)
    - r8152: Add macpassthru support for ThinkPad Thunderbolt 3 Dock Gen 2
  * s390/dasd: reduce the default queue depth and nr of hardware queues
    (LP: #1852257)
    - s390/dasd: reduce the default queue depth and nr of hardware queues
  * External microphone can't work on some dell machines with the codec alc256
    or alc236 (LP: #1853791)
    - SAUCE: ALSA: hda/realtek - Move some alc256 pintbls to fallback table
    - SAUCE: ALSA: hda/realtek - Move some alc236 pintbls to fallback table
  * Memory leak in net/xfrm/xfrm_state.c - 8 pages per ipsec connection
    (LP: #1853197)
    - xfrm: Fix memleak on xfrm state destroy
  * CVE-2019-19083
    - drm/amd/display: memory leak
  * update ENA driver for DIMLIB dynamic interrupt moderation (LP: #1853180)
    - net: ena: add intr_moder_rx_interval to struct ena_com_dev and use it
    - net: ena: switch to dim algorithm for rx adaptive interrupt moderation
    - net: ena: reimplement set/get_coalesce()
    - net: ena: enable the interrupt_moderation in driver_supported_features
    - net: ena: remove code duplication in
      ena_com_update_nonadaptive_moderation_interval _*()
    - net: ena: remove old adaptive interrupt moderation code from ena_netdev
    - net: ena: remove ena_restore_ethtool_params() and relevant fields
    ...

Changed in linux-raspi2 (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.