stress-ng --timer-slack option should be a zero arg option, it currently skips over the next arg
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
stress-ng (Ubuntu) |
Fix Released
|
Medium
|
Colin Ian King | ||
Xenial |
Won't Fix
|
Medium
|
Colin Ian King | ||
Bionic |
Fix Released
|
Medium
|
Colin Ian King | ||
Disco |
Fix Released
|
Medium
|
Colin Ian King | ||
Eoan |
Fix Released
|
Medium
|
Colin Ian King |
Bug Description
== SRU [Bionic]
stress-ng --timer 1 --timer-freq 100000 --timer-slack -t 1 runs for a whole day and not 1 second. The timer-slack option eats the -t1 arg because it is defined as having an arg when in fact it is a zero arg option.
== Fix ==
Upstream fix (in Focal):
commit e044133ed6ebdba
Author: Colin Ian King <email address hidden>
Date: Mon Nov 25 12:05:30 2019 +0000
Fix --timer-slack from consuming the following arg (LP: #1853832)
== Test ==
stress-ng --timer 1 --timer-freq 100000 --timer-slack -t 1
Without the fix, this will run by default for 24 hours. With the fix the -t option is parsed and it will run for 1 second as intended.
== Regression Potential ==
This is a one line arg parsing change so change set is really limited to this one --timer-slack option. Users may find the behaviour now changes because it no longer consumes the next arg and hence the next arg works and hence changes functionality.
Changed in stress-ng: | |
importance: | Undecided → Medium |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in stress-ng: | |
status: | Fix Committed → Fix Released |
affects: | stress-ng → stress-ng (Ubuntu) |
description: | updated |
Changed in stress-ng (Ubuntu Eoan): | |
importance: | Undecided → Medium |
status: | New → In Progress |
description: | updated |
description: | updated |
summary: |
- stress-ng --timer-slack option should be a zero arg option, it current - eats the next arg + stress-ng --timer-slack option should be a zero arg option, it currently + skips over the next arg |
tags: | removed: verification-needed |
tags: |
added: verification-done removed: verification-needed |
tags: |
added: verification-needed removed: verification-done |
tags: |
added: verification-needed-xenial removed: verification-failed-xenial |
tags: |
added: verification-needed-bionic removed: verification-done-bionic |
Fix committed: https:/ /kernel. ubuntu. com/git/ cking/stress- ng.git/ commit/ ?id=e044133ed6e bdbac16775d8ae0 d130bc2dac96ea