Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1855303

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

There are many many bugs fixed in the proposed update to 19.04. We are not intending to supply all the logs for every fix we've already resolved.

This request was submitted after discussions wiht Jeff Lane.

Marking Confirmed.

Jeff,

I just realized I updated the wrong bug...here's the list of additional patches we'll need to include to update 20.04 to the latest upstream for lpfc. There's one additional kernel patch we need you to include below please.

thx
Laurie
--------------------

Here is the list of additional patch commit ids that would be used to update from 12.6.0.2 (end of list in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303) to 12.6.0.3 and 12.6.0.4 and to add FPIN/mpio support:
scsi: lpfc: Fix incomplete NVME discovery when target
commit 3ec5ec408ca633e17d3483e8b806c9fa447e19cc

scsi: lpfc: Fix: Rework setting of fdmi symbolic node name registration
commit d4e9ddd5ae8f26c521692283c7cbedc7e9881529

scsi: lpfc: Fix missing check for CSF in Write Object Mbox Rsp
commit a0c94c5ef874b214305cca965acc7edc27bb69a6

scsi: lpfc: Fix Fabric hostname registration if system hostname changes
commit 3712967ea7f2d3793ae2a39e9eae2df111d770b5

scsi: lpfc: Fix ras_log via debugfs
commit 25d4132f95c25e6f78a94666a1e067291272888a

scsi: lpfc: Fix disablement of FC-AL on lpe35000 models
commit 265fb8efca11eee1ffe8edd2bc0a9fbf31b6b84e

scsi: lpfc: Fix unmap of dpp bars affecting next driver load
commit b88d705fa037b222ecdd5de867132ae25403fe48

scsi: lpfc: Fix MDS Latency Diagnostics Err-drop rates
commit 78a7872570fbeed44e7362354619b403c6e6de1e

scsi: lpfc: Fix improper flag check for IO type
commit f44ccecf36581a2030313e979127013f9d455d3a

scsi: lpfc: Update lpfc version to 12.6.0.3
commit e627554eedcfac83bb2ba073adf711a13049273a

----

scsi: lpfc: Fix RQ buffer leakage when no IOCBs available
commit 9c75a0dee87b2bad80d381ad9fa8ef90847d3a1d

scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 error path
commit 89cc9dba63c91a6c796dc46342c1d57c82c9b0cd

scsi: lpfc: Fix broken Credit Recovery after driver load
commit 692fc8380ca0f9185e75e01a74357d2cf3083743

scsi: lpfc: Fix registration of ELS type support in fdmi
commit 0f74f70cb674e3b8712e896863ad85db4d193d46

scsi: lpfc: Fix release of hwq to clear the eq relationship
commit 01034e708a353fed29963d084c35d58785a317a6

scsi: lpfc: Fix compiler warning on frame size
commit 3cd50eac891db354e945bf9898726e163a19560e

scsi: lpfc: Fix coverity errors in fmdi attribute handling
commit 3ad04f4f0ad75ad4e7d886133f673d9fe20aa9c4

scsi: lpfc: Remove handler for obsolete ELS - Read Port Status (RPS)
commit 8d9fae72109e9921f52be342007b4c78490ea4fe

scsi: lpfc: Clean up hba max_lun_queue_depth checks
commit 20d674a4bf64acf54eadc7215ea32b88a3a7687e

scsi: lpfc: Update lpfc version to 12.6.0.4
commit 35817310d9e05e666dbd242750008dad33ed8992

scsi: lpfc: Copyright updates for 12.6.0.4 patches
commit fd6cc30f341fea14bac45bf1c5c9d10702c18a9d

---

This one--> scsi: fc: Update Descriptor definition and add RDF and Link Integrity FPINs
commit 73ec6d2748dc35db2b32cf3c182a27c4a0837b9b

scsi: lpfc: add RDF registration and Link Integrity FPIN logging
commit df3fe76658ed47617741819a501e2bd2ae446962

Hi Jeff,

Here is the patchset of lpfc that is required for focal. Some of the patches mentioned in this bug are already present in the focal tree and the remainings are part of this patchset. The patches were cut against the main focal tree.

Regards
Vignesh

Hi Vignesh,

As I've been working on this and I just noticed that several of these patches do not exist in the upstream kernel:

89cc9dba63c91a6c796dc46342c1d57c82c9b0cd
scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 error path

692fc8380ca0f9185e75e01a74357d2cf3083743
scsi: lpfc: Fix broken Credit Recovery after driver load

0f74f70cb674e3b8712e896863ad85db4d193d46
scsi: lpfc: Fix registration of ELS type support in fdmi

01034e708a353fed29963d084c35d58785a317a6
scsi: lpfc: Fix release of hwq to clear the eq relationship

3cd50eac891db354e945bf9898726e163a19560e
scsi: lpfc: Fix compiler warning on frame size

3ad04f4f0ad75ad4e7d886133f673d9fe20aa9c4
scsi: lpfc: Fix coverity errors in fmdi attribute handling

8d9fae72109e9921f52be342007b4c78490ea4fe
scsi: lpfc: Remove handler for obsolete ELS - Read Port Status (RPS)

20d674a4bf64acf54eadc7215ea32b88a3a7687e
scsi: lpfc: Clean up hba max_lun_queue_depth checks

35817310d9e05e666dbd242750008dad33ed8992
scsi: lpfc: Update lpfc version to 12.6.0.4

fd6cc30f341fea14bac45bf1c5c9d10702c18a9d
scsi: lpfc: Copyright updates for 12.6.0.4 patches

73ec6d2748dc35db2b32cf3c182a27c4a0837b9b
scsi: fc: Update Descriptor definition and add RDF and Link Integrity FPINs

df3fe76658ed47617741819a501e2bd2ae446962
scsi: lpfc: add RDF registration and Link Integrity FPIN logging

So I appreciate the patch set you've provided, but due to the number of patches, what I need to do is cherry-pick them from mainline and push a branch with cherry picks rather than 70+ patches that need to be reviewed/applied by the kernel team.

And because I can't find these in mainline at all (I've just checked all the proposed commit ids against the most recent updates to mainline) I can't cherry pick these. Do you know when they'll be accepted upstream?

I also checked against Linus tree and cant find those commit IDs there either.

Additionally, this one did not cleanly apply:
Additionally, this one does not cleanly apply when cherry-picked:
765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
warning triggered by lpfc_get_sgl_per_hdwq()

bladernr@galactica:~/development/kernels-ubuntu/focal$ cherrypick 765ab6cdac3b681952da0e22184bf6cf1ae41cf8
error: could not apply 765ab6cdac3b... scsi: lpfc: Fix a kernel warning triggered by lpfc_get_sgl_per_hdwq()
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
bladernr@galactica:~/development/kernels-ubuntu/focal$ git diff
diff --cc drivers/scsi/lpfc/lpfc_sli.c
index e660ee98ad8b,613fbf4a7da9..000000000000
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@@ -20687,7 -20668,7 +20687,11 @@@ lpfc_get_sgl_per_hdwq(struct lpfc_hba *
                /* allocate more */
                spin_unlock_irqrestore(&hdwq->hdwq_lock, iflags);
                tmp = kmalloc_node(sizeof(*tmp), GFP_ATOMIC,
++<<<<<<< HEAD
 + cpu_to_node(hdwq->io_wq->chann));
++=======
+ cpu_to_node(raw_smp_processor_id()));
++>>>>>>> 765ab6cdac3b... scsi: lpfc: Fix a kernel warning triggered by lpfc_get_sgl_per_hdwq()
                if (!tmp) {
                        lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
                                        "8353 error kmalloc memory for HDWQ "
@@@ -20830,7 -20811,7 +20834,11 @@@ lpfc_get_cmd_rsp_buf_per_hdwq(struct lp
                /* allocate more */
                spin_unlock_irqrestore(&hdwq->hdwq_lock, iflags);
                tmp = kmalloc_node(sizeof(*tmp), GFP_ATOMIC,
++<<<<<<< HEAD
 + cpu_to_node(hdwq->io_wq->chann));
++=======
+ cpu_to_node(raw_smp_processor_id()));
++>>>>>>> 765ab6cdac3b... scsi: lpfc: Fix a kernel warning triggered by lpfc_get_sgl_per_hdwq()
                if (!tmp) {
                        lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
                                        "8355 error kmalloc memory for HDWQ "

>So I appreciate the patch set you've provided, but due to the number of patches, what I need to do is >cherry-pick them from mainline and push a branch with cherry picks rather than 70+ patches that need to be >reviewed/applied by the kernel team.
>
>And because I can't find these in mainline at all (I've just checked all the proposed commit ids against the >most recent updates to mainline) I can't cherry pick these. Do you know when they'll be accepted upstream?
>
>I also checked against Linus tree and cant find those commit IDs there either.

Jeff,

All of those 72 patches are already accepted by the Kernel community and most of them are already pulled into linus.git except for the ones you listed. But, the ones you have listed are present in mkp/scsi.git.

Even when I was creating a patchset I went by searching those commit IDs, but couldn't find them either in linus.git or mkp/scsi.git. I guess those commit IDs were from local git. So, I found the equivalent commit IDs for those patches in mkp/scsi.git and cherry-picked them.

Ultimately, all 72 patches are already cherry-picked from either linus.git or mkp/scsi.git. The patchset has the cherry-pick reference in it.

I verified the patchset applies cleanly on the focal tree using:

#git am /<patches_directory>/*.patch

I thought executing this command is all you have to do it from your end.

Regarding comment 6:

>Additionally, this one does not cleanly apply when cherry-picked:
>765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
>warning triggered by lpfc_get_sgl_per_hdwq()

This commit is already pulled into the focal tree from upstream.

Jeff - is there a date by when we'll see a kernel we can run through our test group?

thank you and be well
Laurie

Hi Laurie,

Yes, here:
https://people.canonical.com/~jlane/lpfc-kernels/

Just uploaded fresh builds this morning after fixing a couple things.

Thanks, and I hope you are all doing well and staying healthy as well.

Jeff

On Mon, Mar 30, 2020 at 11:06 AM laurie barry <email address hidden> wrote:
>
> Jeff - is there a date by when we'll see a kernel we can run through our
> test group?
>
> thank you and be well
> Laurie
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1855303
>
> Title:
> Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Focal:
> In Progress
>
> Bug description:
> [IMPACT]
>
> This is related to bug
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856340
>
> both patch sets are needed to make up
> This is a massive number of updates by Broadcom to the lpfc driver that didn't make 5.4 in time. As 20.04 is an LTS release with expected hardware support for 5 years, we need to ensure as much hardware support lands as possible to support server vendors over the next couple years.
>
> Broadcom has updated the lpfc driver to version 12.6.0.2 in 5.5. The
> version in focal is 12.2.0.3 and missing several bug fixes and
> hardware support additions.
>
> Please update the driver in focal appropriately.
>
> [FIXES]
> eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
> last cpu id set
> 4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
> cpu for allocation
> 3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
> to 12.6.0.2
> 542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
> queues to be hdwq count
> bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
> for not present cpus
> d480e57809a043333a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
> lpfc_sli4_cleanup_poll_list()
> 6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
> lpfc_cmpl_els_rsp(): Null pointer dereferences
> 6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
> lpfc_get_scsi_buf_s3(): Null pointer dereferences
> 61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
> lpfc_cpumask_of_node_init()
> eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
> warning triggered by lpfc_sli4_enable_intr()
> 765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
> warning triggered by lpfc_get_sgl_per_hdwq()
> aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
> to 12.6.0.1
> 171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
> multiple adapter dumps
> dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
> model on AMD architectures
> 93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
> for CPU Offline/Online events
> b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
> message
> 69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-...

On Mon, Mar 23, 2020 at 6:41 AM Vignesh Gunasekaran
<email address hidden> wrote:
>
> >So I appreciate the patch set you've provided, but due to the number of patches, what I need to do is >cherry-pick them from mainline and push a branch with cherry picks rather than 70+ patches that need to be >reviewed/applied by the kernel team.
> >
> >And because I can't find these in mainline at all (I've just checked all the proposed commit ids against the >most recent updates to mainline) I can't cherry pick these. Do you know when they'll be accepted upstream?
> >
> >I also checked against Linus tree and cant find those commit IDs there either.
>
> Jeff,
>
> All of those 72 patches are already accepted by the Kernel community and
> most of them are already pulled into linus.git except for the ones you
> listed. But, the ones you have listed are present in mkp/scsi.git.

So as I mentioned in my reply to Laurie just now, I've built some
kernels freshly over the weekend and uploaded them.

However, I do have to tell you that I'm pretty sure they won't accept
packages from mkp/scsi.git, the general rule of thumb is that they're
only accepted into the Ubuntu kernel once they're accepted into the
Mainline kernel.
However, I'll submit them anyway and see what happens.

I still am not sure if they'll accept at all given that several do
touch common code rather than being driver specific, but we'll see how
everything lands.

>
> Even when I was creating a patchset I went by searching those commit
> IDs, but couldn't find them either in linus.git or mkp/scsi.git. I guess
> those commit IDs were from local git. So, I found the equivalent commit
> IDs for those patches in mkp/scsi.git and cherry-picked them.
>
> Ultimately, all 72 patches are already cherry-picked from either
> linus.git or mkp/scsi.git. The patchset has the cherry-pick reference in
> it.
>
>
> I verified the patchset applies cleanly on the focal tree using:
>
> #git am /<patches_directory>/*.patch
>
> I thought executing this command is all you have to do it from your end.

I needed to cherry pick each (or at least I was able to add what I
needed via 'git am') and add a signed-off line with my name and add a
bug link to the commit message for each patch. The tree I built just
now has all that, so it's good now.

> Regarding comment 6:
>
> >Additionally, this one does not cleanly apply when cherry-picked:
> >765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
> >warning triggered by lpfc_get_sgl_per_hdwq()
>
> This commit is already pulled into the focal tree from upstream.

Weird, I tried searching out tree for both that commit ID and by text
searching the subject and didn't find it... oh well, I've limited the
test kernels to just the 72 patches you provided in your tarball.
Thanks for that tarball and sorry for any confusion on my end (this
isn't something I routinely do, so I'm a bit cobwebby when I have to
do these).

--
Jeff Lane
Engineering Manager
IHV/OEM Alliances and Server Certification

"Entropy isn't what it used to be."

Hi Jeff,

I went back to check if those patches in comment #5 are pulled from the MKP tree into the Mainline tree and I noticed that those are landed now.

The SHA IDs of those commits in the Mainline kernel are as follows,

df3fe76658ed scsi: lpfc: add RDF registration and Link Integrity FPIN logging
73ec6d2748dc scsi: fc: Update Descriptor definition and add RDF and Link Integrity FPINs
145e5a8a5cbd scsi: lpfc: Copyright updates for 12.6.0.4 patches
ad6203f97526 scsi: lpfc: Update lpfc version to 12.6.0.4
f6770e7d2329 scsi: lpfc: Clean up hba max_lun_queue_depth checks
6cde2e3e2813 scsi: lpfc: Remove handler for obsolete ELS - Read Port Status (RPS)
4cb9e1ddaa14 scsi: lpfc: Fix coverity errors in fmdi attribute handling
a99c80742af4 scsi: lpfc: Fix compiler warning on frame size
821bc882acca scsi: lpfc: Fix release of hwq to clear the eq relationship
792f3b90be2a scsi: lpfc: Fix registration of ELS type support in fdmi
835214f5d5f5 scsi: lpfc: Fix broken Credit Recovery after driver load
0ab384a49c54 scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 error path

Could you pass on this info to your kernel team? So that all lpfc patches can be accepted.

Thanks
Vignesh

Oh thanks!

I got some guidance from the kernel team that everything was mostly
ok, but I needed to update the commits so the cherry pick showed the
source it came from since it was not mainline. I had started working
on updating all the commits, but, let me check what you've just
provided and I may not need to update anything (or update far less).
They did say that it shouldnt' be an issue getting these all in. So
I'll try to get that pushed again this afternoon or tomorrow.

On Fri, Apr 3, 2020 at 1:36 PM Vignesh Gunasekaran
<email address hidden> wrote:
>
> Hi Jeff,
>
> I went back to check if those patches in comment #5 are pulled from the
> MKP tree into the Mainline tree and I noticed that those are landed now.
>
> The SHA IDs of those commits in the Mainline kernel are as follows,
>
> df3fe76658ed scsi: lpfc: add RDF registration and Link Integrity FPIN logging
> 73ec6d2748dc scsi: fc: Update Descriptor definition and add RDF and Link Integrity FPINs
> 145e5a8a5cbd scsi: lpfc: Copyright updates for 12.6.0.4 patches
> ad6203f97526 scsi: lpfc: Update lpfc version to 12.6.0.4
> f6770e7d2329 scsi: lpfc: Clean up hba max_lun_queue_depth checks
> 6cde2e3e2813 scsi: lpfc: Remove handler for obsolete ELS - Read Port Status (RPS)
> 4cb9e1ddaa14 scsi: lpfc: Fix coverity errors in fmdi attribute handling
> a99c80742af4 scsi: lpfc: Fix compiler warning on frame size
> 821bc882acca scsi: lpfc: Fix release of hwq to clear the eq relationship
> 792f3b90be2a scsi: lpfc: Fix registration of ELS type support in fdmi
> 835214f5d5f5 scsi: lpfc: Fix broken Credit Recovery after driver load
> 0ab384a49c54 scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 error path
>
> Could you pass on this info to your kernel team? So that all lpfc
> patches can be accepted.
>
> Thanks
> Vignesh
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1855303
>
> Title:
> Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Focal:
> In Progress
>
> Bug description:
> [IMPACT]
>
> This is related to bug
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856340
>
> This is a significant number of updates by Broadcom to the lpfc driver
> that didn't make 5.4 in time. As 20.04 is an LTS release with
> expected hardware support for 5 years, we need to ensure as much
> hardware support lands as possible to support server vendors over the
> next couple years.
>
> Broadcom has updated the lpfc driver to version 12.6.0.4 in 5.5. The
> version in focal is 12.2.0.3 and missing several bug fixes and
> hardware support additions.
>
> Please update the driver in focal appropriately.
>
> [FIXES]
> eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
> last cpu id set
> 4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
> cpu for allocation
> 3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
> to 12.6.0.2
> 542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
> queues to ...

This bug was fixed in the package linux - 5.4.0-24.28

---------------
linux (5.4.0-24.28) focal; urgency=medium

  * focal/linux: 5.4.0-24.28 -proposed tracker (LP: #1871939)

  * getitimer returns it_value=0 erroneously (LP: #1349028)
    - [Config] CONTEXT_TRACKING_FORCE policy should be unset

  * 12d1:1038 Dual-Role OTG device on non-HNP port - unable to enumerate USB
    device on port 1 (LP: #1047527)
    - [Config] USB_OTG_FSM policy not needed

  * Add DCPD backlight support for HP CML system (LP: #1871589)
    - SAUCE: drm/i915: Force DPCD backlight mode for HP CML 2020 system

  * Backlight brightness cannot be adjusted using keys (LP: #1860303)
    - SAUCE drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible
      13t-aw100

  * CVE-2020-11494
    - slcan: Don't transmit uninitialized stack data in padding

  * Ubuntu Kernel Support for OpenPOWER NV Secure & Trusted Boot (LP: #1866909)
    - powerpc: Detect the secure boot mode of the system
    - powerpc/ima: Add support to initialize ima policy rules
    - powerpc: Detect the trusted boot state of the system
    - powerpc/ima: Define trusted boot policy
    - ima: Make process_buffer_measurement() generic
    - certs: Add wrapper function to check blacklisted binary hash
    - ima: Check against blacklisted hashes for files with modsig
    - powerpc/ima: Update ima arch policy to check for blacklist
    - powerpc/ima: Indicate kernel modules appended signatures are enforced
    - powerpc/powernv: Add OPAL API interface to access secure variable
    - powerpc: expose secure variables to userspace via sysfs
    - x86/efi: move common keyring handler functions to new file
    - powerpc: Load firmware trusted keys/hashes into kernel keyring
    - x86/efi: remove unused variables

  * [roce-0227]sync mainline kernel 5.6rc3 roce patchset into ubuntu HWE kernel
    branch (LP: #1864950)
    - RDMA/hns: Cleanups of magic numbers
    - RDMA/hns: Optimize eqe buffer allocation flow
    - RDMA/hns: Add the workqueue framework for flush cqe handler
    - RDMA/hns: Delayed flush cqe process with workqueue
    - RDMA/hns: fix spelling mistake: "attatch" -> "attach"
    - RDMA/hns: Initialize all fields of doorbells to zero
    - RDMA/hns: Treat revision HIP08_A as a special case
    - RDMA/hns: Use flush framework for the case in aeq
    - RDMA/hns: Stop doorbell update while qp state error
    - RDMA/hns: Optimize qp destroy flow
    - RDMA/hns: Optimize qp context create and destroy flow
    - RDMA/hns: Optimize qp number assign flow
    - RDMA/hns: Optimize qp buffer allocation flow
    - RDMA/hns: Optimize qp param setup flow
    - RDMA/hns: Optimize kernel qp wrid allocation flow
    - RDMA/hns: Optimize qp doorbell allocation flow
    - RDMA/hns: Check if depth of qp is 0 before configure

  * [hns3-0316]sync mainline kernel 5.6rc4 hns3 patchset into ubuntu HWE kernel
    branch (LP: #1867586)
    - net: hns3: modify an unsuitable print when setting unknown duplex to fibre
    - net: hns3: add enabled TC numbers and DWRR weight info in debugfs
    - net: hns3: add support for dump MAC ID and loopback status in debugfs
    - net: hns3: add missing help info for QS shaper...

On e7b1483ab857862aeee144eb9029611af834c65d (tag: Ubuntu-5.4.0-30.34), I had to revert 77d5805eafdb5c42bdfe78f058ad9c40ee1278b4 "scsi: lpfc: Fix broken Credit Recovery after driver load" to make our lpfc 8Gb cards work again.