[roce-0227]sync mainline kernel 5.6rc3 roce patchset into ubuntu HWE kernel branch

Bug #1864950 reported by Fred Kimmy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kunpeng920
Fix Released
Undecided
Unassigned
Ubuntu-18.04-hwe
Fix Released
Undecided
Ike Panhc
Ubuntu-20.04
Fix Released
Undecided
Ike Panhc
Upstream-kernel
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Fix Released
Undecided
Ike Panhc

Bug Description

[Bug Description]
roce patchset have merged into mainline 5.6rc2 kernel.

[Steps to Reproduce]
  1)
  2)
  3)

[Actual Results]

[Expected Results]

[Reproducibility]

[Additional information]
  (Firmware version, kernel version, affected hardware, etc. if required):

[Resolution]
RDMA/hns: Optimize eqe buffer allocation flow
RDMA/hns: Cleanups of magic numbers
RDMA/hns: fix spelling mistake: "attatch" -> "attach"
RDMA/hns: Delayed flush cqe process with workqueue
RDMA/hns: Add the workqueue framework for flush cqe handler
RDMA/hns: Initialize all fields of doorbells to zero
RDMA/hns: Optimize qp doorbell allocation flow
RDMA/hns: Optimize kernel qp wrid allocation flow
RDMA/hns: Optimize qp param setup flow
RDMA/hns: Optimize qp buffer allocation flow
RDMA/hns: Optimize qp number assign flow
RDMA/hns: Optimize qp context create and destroy flow
RDMA/hns: Optimize qp destroy flow
RDMA/hns: Stop doorbell update while qp state error
RDMA/hns: Use flush framework for the case in aeq
RDMA/hns: Treat revision HIP08_A as a special case

https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=wip/jgg-for-next

RDMA/hns: Treat revision HIP08_A as a special case

https://www.spinics.net/lists/linux-rdma/msg89428.html

RDMA/hns: Support to set mininum depth of qp to 0
https://patchwork.kernel.org/patch/11415067/

CVE References

Revision history for this message
Ike Panhc (ikepanhc) wrote :

Only one patch found in mainline kernel for v5.6-rc4

10dcc7448e9e RDMA/hns: fix spelling mistake "attatch" -> "attach"

Changed in kunpeng920:
status: New → Incomplete
summary: - [hns3-0227]sync mainline kernel 5.6rc2 roce patchset into ubuntu HWE
+ [roce-0227]sync mainline kernel 5.6rc2 roce patchset into ubuntu HWE
kernel branch
Revision history for this message
Fred Kimmy (kongzizaixian) wrote : Re: [roce-0227]sync mainline kernel 5.6rc2 roce patchset into ubuntu HWE kernel branch

@IKE
can you backport this roce patchset into ubuntu 18.04.5 (20.04) kernel version? thank you.

description: updated
Changed in kunpeng920:
status: Incomplete → New
summary: - [roce-0227]sync mainline kernel 5.6rc2 roce patchset into ubuntu HWE
+ [roce-0227]sync mainline kernel 5.6rc3 roce patchset into ubuntu HWE
kernel branch
Revision history for this message
Ike Panhc (ikepanhc) wrote :

@Xinwei,

Those patches are expected to hit mainline kernel on 5.7 merge window. I will proceed after they hit mainline.

Changed in kunpeng920:
status: New → Incomplete
Revision history for this message
Fred Kimmy (kongzizaixian) wrote :

this aboving patchset will slove flush CQE error for roce modules. it be tiggered when QP is detected to be in errored stateduring various legs like post send, post receive etc.

Revision history for this message
Ike Panhc (ikepanhc) wrote :

Could you pick up those fixes and prepare the test case for me to reproduce?

Some of the patches are saying "Optimize" and they do not look like a fix for error.

Ike Panhc (ikepanhc)
tags: added: ikeradar
Revision history for this message
Fred Kimmy (kongzizaixian) wrote :

@ike
Can you push this critical patchset into ubuntu focal kernel.

RDMA/hns: Support to set mininum depth of qp to 0
RDMA/hns: Treat revision HIP08_A as a special case
RDMA/hns: Delayed flush cqe process with workqueue
RDMA/hns: Add the workqueue framework for flush cqe handler
RDMA/hns: Stop doorbell update while qp state error
RDMA/hns: Use flush framework for the case in aeq

Revision history for this message
Ike Panhc (ikepanhc) wrote :

There are several feedback for "RDMA/hns: Support to set mininum depth of qp to 0" and the patch are not ACKed. I believe we shall wait until it has better status.

Revision history for this message
Fred Kimmy (kongzizaixian) wrote :

the patch have been acked as following:
RDMA/hns: Check if depth of qp is 0 before configure
https://www.spinics.net/lists/linux-rdma/msg89826.html

Revision history for this message
Ike Panhc (ikepanhc) wrote :

Subject: RDMA/hns: Treat revision HIP08_A as a special case

Set revisions that equal to or higher than HIP08_B as default to maintain
backward compatibility.

This patch is more like an extension on hardware ID then a fix. I will handle this patch during SRU cycle.

Revision history for this message
Ike Panhc (ikepanhc) wrote : Re: [Bug 1864950] Re: [roce-0227]sync mainline kernel 5.6rc3 roce patchset into ubuntu HWE kernel branch

On 3/26/20 2:02 PM, Fred Kimmy wrote:
> the patch have been acked as following:
> RDMA/hns: Check if depth of qp is 0 before configure
> https://www.spinics.net/lists/linux-rdma/msg89826.html
>

This patch is highly depends on "RDMA/hns: Optimize qp param setup flow". I will process after these patches landed on upstream kernel.

Revision history for this message
Ike Panhc (ikepanhc) wrote :

5 patches can be cherry-picked cleanly and in my branch for testing.

RDMA/hns: Stop doorbell update while qp state error
RDMA/hns: Use flush framework for the case in aeq
RDMA/hns: Initialize all fields of doorbells to zero
RDMA/hns: Delayed flush cqe process with workqueue
RDMA/hns: Add the workqueue framework for flush cqe handler

Please refer to my git branch for reference

https://kernel.ubuntu.com/git/ikepanhc/public.git/log/?h=kunpeng920_wip

Changed in linux (Ubuntu):
status: New → In Progress
assignee: nobody → Ike Panhc (ikepanhc)
Revision history for this message
Ike Panhc (ikepanhc) wrote :

All patches has been merged into mainline kernel.

Changed in kunpeng920:
status: Incomplete → In Progress
Revision history for this message
Ike Panhc (ikepanhc) wrote :
Revision history for this message
Ike Panhc (ikepanhc) wrote :

Patches has been applied to focal/master-next

https://lists.ubuntu.com/archives/kernel-team/2020-April/108836.html

Changed in kunpeng920:
status: In Progress → Fix Committed
Ike Panhc (ikepanhc)
tags: removed: ikeradar
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (35.2 KiB)

This bug was fixed in the package linux - 5.4.0-24.28

---------------
linux (5.4.0-24.28) focal; urgency=medium

  * focal/linux: 5.4.0-24.28 -proposed tracker (LP: #1871939)

  * getitimer returns it_value=0 erroneously (LP: #1349028)
    - [Config] CONTEXT_TRACKING_FORCE policy should be unset

  * 12d1:1038 Dual-Role OTG device on non-HNP port - unable to enumerate USB
    device on port 1 (LP: #1047527)
    - [Config] USB_OTG_FSM policy not needed

  * Add DCPD backlight support for HP CML system (LP: #1871589)
    - SAUCE: drm/i915: Force DPCD backlight mode for HP CML 2020 system

  * Backlight brightness cannot be adjusted using keys (LP: #1860303)
    - SAUCE drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible
      13t-aw100

  * CVE-2020-11494
    - slcan: Don't transmit uninitialized stack data in padding

  * Ubuntu Kernel Support for OpenPOWER NV Secure & Trusted Boot (LP: #1866909)
    - powerpc: Detect the secure boot mode of the system
    - powerpc/ima: Add support to initialize ima policy rules
    - powerpc: Detect the trusted boot state of the system
    - powerpc/ima: Define trusted boot policy
    - ima: Make process_buffer_measurement() generic
    - certs: Add wrapper function to check blacklisted binary hash
    - ima: Check against blacklisted hashes for files with modsig
    - powerpc/ima: Update ima arch policy to check for blacklist
    - powerpc/ima: Indicate kernel modules appended signatures are enforced
    - powerpc/powernv: Add OPAL API interface to access secure variable
    - powerpc: expose secure variables to userspace via sysfs
    - x86/efi: move common keyring handler functions to new file
    - powerpc: Load firmware trusted keys/hashes into kernel keyring
    - x86/efi: remove unused variables

  * [roce-0227]sync mainline kernel 5.6rc3 roce patchset into ubuntu HWE kernel
    branch (LP: #1864950)
    - RDMA/hns: Cleanups of magic numbers
    - RDMA/hns: Optimize eqe buffer allocation flow
    - RDMA/hns: Add the workqueue framework for flush cqe handler
    - RDMA/hns: Delayed flush cqe process with workqueue
    - RDMA/hns: fix spelling mistake: "attatch" -> "attach"
    - RDMA/hns: Initialize all fields of doorbells to zero
    - RDMA/hns: Treat revision HIP08_A as a special case
    - RDMA/hns: Use flush framework for the case in aeq
    - RDMA/hns: Stop doorbell update while qp state error
    - RDMA/hns: Optimize qp destroy flow
    - RDMA/hns: Optimize qp context create and destroy flow
    - RDMA/hns: Optimize qp number assign flow
    - RDMA/hns: Optimize qp buffer allocation flow
    - RDMA/hns: Optimize qp param setup flow
    - RDMA/hns: Optimize kernel qp wrid allocation flow
    - RDMA/hns: Optimize qp doorbell allocation flow
    - RDMA/hns: Check if depth of qp is 0 before configure

  * [hns3-0316]sync mainline kernel 5.6rc4 hns3 patchset into ubuntu HWE kernel
    branch (LP: #1867586)
    - net: hns3: modify an unsuitable print when setting unknown duplex to fibre
    - net: hns3: add enabled TC numbers and DWRR weight info in debugfs
    - net: hns3: add support for dump MAC ID and loopback status in debugfs
    - net: hns3: add missing help info for QS shaper...

Changed in linux (Ubuntu):
status: In Progress → Fix Released
Ike Panhc (ikepanhc)
Changed in kunpeng920:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.