Mahara

Arrow bar in Modern and Ocean not correct wen hovering over non-active tab

Bug #1860368 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Evonne Cheung
Mahara 20.04.0
19.10
Fix Released
High
Unassigned
Mahara 19.10.2

Bug Description

In Modern and Ocean theme the group arrow bar has white text on white button when hovering over the non-active tab and therefore can't read it.

For modern theme I think it is because of the combination of

https://git.mahara.org/mahara/mahara/blob/master/htdocs/theme/raw/sass/components/_arrow-bar.scss#L68

and Modern's theme setting both the hover and background colour to the same thing

$arrow-link-hover-color: #FFFFFF;
$arrow-link-background-color: #fff;

Not sure why Ocean theme is not working right

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Evonne Cheung (evonne)
milestone: none → 20.04.0
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10723

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10723
Committed: https://git.mahara.org/mahara/mahara/commit/0759097a4283fbc0680cc0dcbfa4e63b4a06fcfb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0759097a4283fbc0680cc0dcbfa4e63b4a06fcfb
Author: Evonne <email address hidden>
Date: Tue Jan 21 10:50:41 2020 +1300

Bug 1860368 Hover states of Modern and Ocean theme arrow tab

Adjusted variables so hover states within arrow tabs are not
white on white.

behatnotneeded

Change-Id: Ibfb2c6743427cf9f571376ef95329454f9eb73db

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10727

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10727
Committed: https://git.mahara.org/mahara/mahara/commit/38a8ad495e5e39f080e34e135054066b0e7665c0
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 38a8ad495e5e39f080e34e135054066b0e7665c0
Author: Evonne <email address hidden>
Date: Tue Jan 21 10:50:41 2020 +1300

Bug 1860368 Hover states of Modern and Ocean theme arrow tab

Adjusted variables so hover states within arrow tabs are not
white on white.

behatnotneeded

Change-Id: Ibfb2c6743427cf9f571376ef95329454f9eb73db
(cherry picked from commit 0759097a4283fbc0680cc0dcbfa4e63b4a06fcfb)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/20.04
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.