Mahara

Security Upgrade SimpleSAML 1.17.7 to 1.18.4

Bug #1865400 reported by Lisa Seeto
256
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Lisa Seeto
Mahara 20.04.0
18.10
Fix Released
High
Unassigned
Mahara 18.10.5
19.04
Fix Released
High
Unassigned
Mahara 19.04.4
19.10
Fix Released
High
Unassigned
Mahara 19.10.2

Bug Description

From https://simplesamlphp.org:

Background

SimpleSAMLphp allows users to report errors and failures to the system administrators via a web form. This web form gathers some contextual information automatically, but it also allows the user to provide their email address for follow-ups and a free-text explanation of what happened. Once submitted, the report is sent as an email to the administrative email address configured in the software.
Description

The www/erroreport.php script allows error reports to be submitted and sent to the system administrator. Starting with SimpleSAMLphp 1.18.0, a new SimpleSAML\Utils\EMail class was introduced to handle sending emails, implemented as a wrapper of an external dependency.

This new wrapper allows us to use Twig templates in order to create the email sent with an error report. Since Twig provides automatic escaping of variables, manual escaping of the free-text field in www/errorreport.php was removed to avoid double escaping. However, for those not using the new user interface yet, an email template is hardcoded into the class itself in plain PHP. Since no escaping is provided in this template, it is then possible to inject HTML inside the template by manually crafting the contents of the free-text field.
Affected versions

SimpleSAMLphp versions 1.18.0 to 1.18.3, both inclusive.

We will need to upgrade to version 1.18.4

Revision history for this message
Robert Lyon (robertl-9) wrote :

https://reviews.mahara.org/#/c/10789/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10789
Committed: https://git.mahara.org/mahara/mahara/commit/389ce48e6e37492e28a1ccd7b24beea23ca45627
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 389ce48e6e37492e28a1ccd7b24beea23ca45627
Author: Lisa Seeto <email address hidden>
Date: Mon Mar 2 14:14:34 2020 +1300

Bug 1865400: Security Upgrade SimpleSAML 1.17.7 to 1.18.4

- upgraded to version 1.18.4

Change-Id: Ic76de9cef3a61bb71e056582b8dd1dc2aeb3571b
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10802

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10802
Committed: https://git.mahara.org/mahara/mahara/commit/b2ac960eaab2fe8cb1858be6e7e3ea89f4205c32
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit b2ac960eaab2fe8cb1858be6e7e3ea89f4205c32
Author: Lisa Seeto <email address hidden>
Date: Mon Mar 2 14:14:34 2020 +1300

Bug 1865400: Security Upgrade SimpleSAML 1.17.7 to 1.18.4

- upgraded to version 1.18.4

Change-Id: Ic76de9cef3a61bb71e056582b8dd1dc2aeb3571b
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 389ce48e6e37492e28a1ccd7b24beea23ca45627)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10804

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10805

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10804
Committed: https://git.mahara.org/mahara/mahara/commit/66abb9bbcca57a63ed5ef2658c2f9882d0d4cd9c
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 66abb9bbcca57a63ed5ef2658c2f9882d0d4cd9c
Author: Lisa Seeto <email address hidden>
Date: Mon Mar 2 14:14:34 2020 +1300

Bug 1865400: Security Upgrade SimpleSAML 1.17.7 to 1.18.4

- upgraded to version 1.18.4

Change-Id: Ic76de9cef3a61bb71e056582b8dd1dc2aeb3571b
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 389ce48e6e37492e28a1ccd7b24beea23ca45627)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10805
Committed: https://git.mahara.org/mahara/mahara/commit/ab846aa74c126e82b065e19b8e2fc04e282b0282
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit ab846aa74c126e82b065e19b8e2fc04e282b0282
Author: Lisa Seeto <email address hidden>
Date: Mon Mar 2 14:14:34 2020 +1300

Bug 1865400: Security Upgrade SimpleSAML 1.17.7 to 1.18.4

- upgraded to version 1.18.4

Change-Id: Ic76de9cef3a61bb71e056582b8dd1dc2aeb3571b
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 389ce48e6e37492e28a1ccd7b24beea23ca45627)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/20.04
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.