HAProxy monitor VIP precheck fails if haproxy running remotely

Bug #1866617 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Mark Goddard
Stein
Fix Released
Medium
Mark Goddard
Train
Fix Released
Medium
Mark Goddard
Ussuri
Fix Released
Medium
Mark Goddard

Bug Description

If haproxy is running somewhere in the cluster and listening on the VIP, but not running locally, then the following precheck may fail:

TASK [haproxy : Checking free port for HAProxy monitor (vip interface)]

msg: Timeout when waiting for 192.0.2.10:61313 to stop.

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/711905

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/711924

Changed in kolla-ansible:
assignee: nobody → Mark Goddard (mgoddard)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/711924
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=93a4dcc1b97b1d7bbd3b91cc9c4bd4617ec6f9ba
Submitter: Zuul
Branch: master

commit 93a4dcc1b97b1d7bbd3b91cc9c4bd4617ec6f9ba
Author: Mark Goddard <email address hidden>
Date: Mon Mar 9 11:27:25 2020 +0000

    Fix HAProxy monitor VIP precheck

    If haproxy is running somewhere in the cluster and listening on the VIP,
    but not running locally, then the following precheck may fail:

       TASK [haproxy : Checking free port for HAProxy monitor (vip interface)]

       msg: Timeout when waiting for 192.0.2.10:61313 to stop.

    This change fixes the issue by skipping the check if HAProxy is running
    on any host.

    Change-Id: I831eb2f700ef3fcf65b7e08382c3b4fcc4ce8d8d
    Closes-Bug: #1866617

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/712300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/712441

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/711905
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=fa16b8548939fba8243e178331ed309821594252
Submitter: Zuul
Branch: stable/train

commit fa16b8548939fba8243e178331ed309821594252
Author: Mark Goddard <email address hidden>
Date: Mon Mar 9 11:27:25 2020 +0000

    Fix HAProxy monitor VIP precheck

    If haproxy is running somewhere in the cluster and listening on the VIP,
    but not running locally, then the following precheck may fail:

       TASK [haproxy : Checking free port for HAProxy monitor (vip interface)]

       msg: Timeout when waiting for 192.0.2.10:61313 to stop.

    This change fixes the issue by skipping the check if HAProxy is running
    on any host.

    Change-Id: I831eb2f700ef3fcf65b7e08382c3b4fcc4ce8d8d
    Closes-Bug: #1866617
    (cherry picked from commit 93a4dcc1b97b1d7bbd3b91cc9c4bd4617ec6f9ba)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/712300
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=426b7f4b22240a80d5f3c1f96542af5ac64c1686
Submitter: Zuul
Branch: stable/stein

commit 426b7f4b22240a80d5f3c1f96542af5ac64c1686
Author: Mark Goddard <email address hidden>
Date: Mon Mar 9 11:27:25 2020 +0000

    Fix HAProxy monitor VIP precheck

    If haproxy is running somewhere in the cluster and listening on the VIP,
    but not running locally, then the following precheck may fail:

       TASK [haproxy : Checking free port for HAProxy monitor (vip interface)]

       msg: Timeout when waiting for 192.0.2.10:61313 to stop.

    This change fixes the issue by skipping the check if HAProxy is running
    on any host.

    Change-Id: I831eb2f700ef3fcf65b7e08382c3b4fcc4ce8d8d
    Closes-Bug: #1866617
    (cherry picked from commit 93a4dcc1b97b1d7bbd3b91cc9c4bd4617ec6f9ba)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.opendev.org/712441
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d6ecbb894c1096af823cc080fa6b19edb39d3e33
Submitter: Zuul
Branch: stable/rocky

commit d6ecbb894c1096af823cc080fa6b19edb39d3e33
Author: Mark Goddard <email address hidden>
Date: Mon Mar 9 11:27:25 2020 +0000

    Fix HAProxy monitor VIP precheck

    If haproxy is running somewhere in the cluster and listening on the VIP,
    but not running locally, then the following precheck may fail:

       TASK [haproxy : Checking free port for HAProxy monitor (vip interface)]

       msg: Timeout when waiting for 192.0.2.10:61313 to stop.

    This change fixes the issue by skipping the check if HAProxy is running
    on any host.

    Change-Id: I831eb2f700ef3fcf65b7e08382c3b4fcc4ce8d8d
    Closes-Bug: #1866617
    (cherry picked from commit 93a4dcc1b97b1d7bbd3b91cc9c4bd4617ec6f9ba)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.2.1

This issue was fixed in the openstack/kolla-ansible 7.2.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.