FFe: libmaxminddb update to 1.4.2 (MIR requirement)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libmaxminddb (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Hello,
I would like to update libmaxminddb to a new upstream version of 1.4.2, going ahead of debian. This is a requirement[4] for its own MIR (#1861101) which will unblock fixing bind9's bug #1866875.
The upstream release notes for libmaxminddb 1.4.2 can be seen at [3], and are basically the same as for 1.4.0 minus the release bugs (as 1.4.0 and 1.4.1 were broken releases):
Of interest to the update, as requested in the MIR[4], is this fix:
"""
Fix a memory leak that occurred when freeing an MMDB_s where the
database had no languages defined in the metadata. If you are using an
official MaxMind database, this leak does not affect you. Pull request
by Kókai Péter. GitHub #180.
"""
This is the diff[5] between 1.3.2 (current release in ubuntu and debian) and 1.4.2.
A debdiff is attached, produced from the branch at [6]. I might still add review requests.
A PPA with test builds is available at [7]. No rebuild was needed for bind9, and as the soname remains the same, the same is expected for the other reverse dependencies.
1. https:/
2. https:/
3. https:/
4. https:/
5. https:/
6. https:/
7. https:/
Related branches
- Christian Ehrhardt (community): Approve
- Canonical Server: Pending requested
- Canonical Server MOTU reviewers: Pending requested
-
Diff: 50835 lines (+47686/-301)71 files modifiedChanges.md (+38/-0)
Makefile.am (+6/-2)
Makefile.in (+1024/-0)
README.md (+18/-11)
aclocal.m4 (+10475/-0)
bin/Makefile.in (+634/-0)
bin/mmdblookup.c (+66/-19)
compile (+347/-0)
config.guess (+1480/-0)
config.h.in (+192/-0)
config.sub (+1801/-0)
configure (+15620/-0)
configure.ac (+7/-1)
debian/changelog (+16/-0)
debian/control (+3/-4)
debian/libmaxminddb0.install (+1/-0)
debian/patches/series (+0/-1)
debian/rules (+2/-9)
depcomp (+791/-0)
dev/null (+0/-2)
doc/libmaxminddb.md (+14/-6)
include/maxminddb.h (+51/-37)
install-sh (+508/-0)
ltmain.sh (+11156/-0)
man/man1/mmdblookup.1 (+119/-0)
man/man3/MMDB_aget_value.3 (+1/-0)
man/man3/MMDB_close.3 (+1/-0)
man/man3/MMDB_dump_entry_data_list.3 (+1/-0)
man/man3/MMDB_free_entry_data_list.3 (+1/-0)
man/man3/MMDB_get_entry_data_list.3 (+1/-0)
man/man3/MMDB_get_metadata_as_entry_data_list.3 (+1/-0)
man/man3/MMDB_get_value.3 (+1/-0)
man/man3/MMDB_lib_version.3 (+1/-0)
man/man3/MMDB_lookup_sockaddr.3 (+1/-0)
man/man3/MMDB_lookup_string.3 (+1/-0)
man/man3/MMDB_open.3 (+1/-0)
man/man3/MMDB_read_node.3 (+1/-0)
man/man3/MMDB_strerror.3 (+1/-0)
man/man3/MMDB_vget_value.3 (+1/-0)
man/man3/defined.3 (+1/-0)
man/man3/libmaxminddb.3 (+1054/-0)
missing (+215/-0)
projects/VS12-tests/bad_pointers.vcxproj (+1/-1)
projects/VS12-tests/basic_lookup.vcxproj (+1/-1)
projects/VS12-tests/data_entry_list.vcxproj (+1/-1)
projects/VS12-tests/data_types.vcxproj (+1/-1)
projects/VS12-tests/dump.vcxproj (+1/-1)
projects/VS12-tests/get_value.vcxproj (+1/-1)
projects/VS12-tests/get_value_pointer_bug.vcxproj (+1/-1)
projects/VS12-tests/ipv4_start_cache.vcxproj (+1/-1)
projects/VS12-tests/ipv6_lookup_in_ipv4.vcxproj (+1/-1)
projects/VS12-tests/maxminddb_test_helper.vcxproj (+1/-1)
projects/VS12-tests/metadata.vcxproj (+1/-1)
projects/VS12-tests/metadata_pointers.vcxproj (+1/-1)
projects/VS12-tests/no_map_get_value.vcxproj (+1/-1)
projects/VS12-tests/read_node.vcxproj (+1/-1)
projects/VS12-tests/shared.vcxproj (+1/-1)
projects/VS12-tests/threads.vcxproj (+1/-1)
projects/VS12-tests/version.vcxproj (+1/-1)
src/Makefile.in (+871/-0)
src/maxminddb.c (+101/-128)
t/Makefile.am (+6/-2)
t/Makefile.in (+938/-0)
t/basic_lookup_t.c (+2/-2)
t/data_types_t.c (+2/-2)
t/dump_t.c (+1/-1)
t/get_value_pointer_bug_t.c (+2/-2)
t/get_value_t.c (+66/-2)
t/maxminddb_test_helper.c (+2/-25)
t/maxminddb_test_helper.h (+24/-27)
t/threads_t.c (+1/-1)
Ok, since this is required for the MIR to happen and that the MIR itself already got a +1, I'll approve this FFe. I was a bit worried since those versions were apparently tagged "DO NOT USE" by upstream, but I trust the MIR team's judgment here.
Please proceed.