add lshw cmd into sosreport's hardware plugin

debdiff for focal lshw command patch

build #2 for lshw command

The attachment "fix_1871494.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Thanks Heather for your Ubuntu contribution for Focal.

Since this change is not release critical, I'll put the sponsoring on hold while Focal is currently transitionning from devel to stable.

I'll sponsor it as soon as I can.

Meanwhile, could you please produce the debdiff(s) for the stable release: Eoan/Bionic/Xenial ?

- Eric

Yeah that sounds good. Thanks.

Heather, can you please produce a 'groovy' 20.10 debdiff ?

Thanks

attached thanks!

Uploaded in groovy.

This bug was fixed in the package sosreport - 3.9-1ubuntu3

---------------
sosreport (3.9-1ubuntu3) groovy; urgency=low

  * d/p/0003-lshw-command.patch: (LP: #1871494)
    - Add `lshw` command to hardware plugin

  [Eric Desrochers]
  * d/p/0004-lds-substitute-oidc-conf.patch:
    - landscape substitute oidc conf
      in service file (LP: #1874526)

 -- Heather Lemon <email address hidden> Mon, 27 Apr 2020 09:33:16 -0600

Hello Eric, or anyone else affected,

Accepted sosreport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/3.9-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Eric, or anyone else affected,

Accepted sosreport into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/3.9-1ubuntu0.19.10.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Eric, or anyone else affected,

Accepted sosreport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/3.9-1ubuntu0.18.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[VERIFICATION EOAN]

This was tested using the following proposed pkg:
sosreport 3.9-1ubuntu0.19.10.3

I confirmed the sosreport's hw plugin collect 'lshw' command as root,
and its content is accurate.

# lsb_release -cs
eoan

# sosreport -a
# cd /tmp
# tar Jxvf sosreport*.tar.xz
# sudo lshw | tee /tmp/lshw_not_from_sosreport.eoan

# diff -u /tmp/lshw_not_from_sosreport.eoan /path_to_sosreport/sos_commands/hardware/lshw
17c17
< size: 2487MHz
---
> size: 3289MHz

The "size:" is dynamic so it keeps changing at each lshw run, the rest remain identical.
No content missing/altered/... during the lshw sosreport collection.

[VERIFICATION FOCAL]

This was tested using the following proposed pkg:
sosreport 3.9-1ubuntu2.1

I confirmed the sosreport's hw plugin collect 'lshw' command as root,
and its content is accurate.

# lsb_release -cs
focal

# sosreport -a
# cd /tmp
# tar Jxvf sosreport*.tar.xz
# sudo lshw | tee /tmp/lshw_not_from_sosreport.focal

# diff -u /tmp/lshw_not_from_sosreport.focal /path_to_sosreport/sos_commands/hardware/lshw
17c17
< size: 2545MHz
---
> size: 3240MHz

The "size:" is dynamic so it keeps changing at each lshw run, the rest remain identical.
No content missing/altered/... during the lshw sosreport collection.

[VERIFICATION BIONIC]

This was tested using the following proposed pkg:
sosreport 3.9-1ubuntu0.18.04.3

I confirmed the sosreport's hw plugin collect 'lshw' command as root,
and its content is accurate.

# lsb_release -cs
focal

# sosreport -a
# cd /tmp
# tar Jxvf sosreport*.tar.xz
# sudo lshw | tee /tmp/lshw_not_from_sosreport.bionic

# diff -u /tmp/lshw_not_from_sosreport.bionic /path_to_sosreport/sos_commands/hardware/lshw
17c17
< size: 2869MHz
---
> size: 3200MHz

The "size:" is dynamic so it keeps changing at each lshw run, the rest remain identical.
No content missing/altered/... during the lshw sosreport collection.

This bug was fixed in the package sosreport - 3.9-1ubuntu2.1

---------------
sosreport (3.9-1ubuntu2.1) focal; urgency=low

  * d/p/0003-lshw-command.patch: (LP: #1871494)
    - Add `lshw` command to hardware plugin

  [Eric Desrochers]
  * d/p/0004-lds-substitute-oidc-conf.patch:
    - landscape substitute oidc conf
      in service file (LP: #1874526)

 -- Heather Lemon <email address hidden> Mon, 27 Apr 2020 09:33:16 -0600

The verification of the Stable Release Update for sosreport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package sosreport - 3.9-1ubuntu0.19.10.3

---------------
sosreport (3.9-1ubuntu0.19.10.3) eoan; urgency=medium

  * d/p/0003-lshw-command.patch: (LP: #1871494)
    - Add `lshw` command to hardware plugin

  [Eric Desrochers]
  * d/p/0004-lds-substitute-oidc-conf.patch:
    - landscape substitute oidc conf
      in service file (LP: #1874526)

  [Eric Desrochers]
  * d/tests/{control,simple.sh}: (LP: #1865212)
    - Add testsuite "simple.sh". A port of the travis tests to bash
      provided by upstream.

 -- Heather Lemon <email address hidden> Wed, 29 Apr 2020 13:47:47 +0000

This bug was fixed in the package sosreport - 3.9-1ubuntu0.18.04.3

---------------
sosreport (3.9-1ubuntu0.18.04.3) bionic; urgency=medium

  * d/p/0003-lshw-command.patch: (LP: #1871494)
    - Add `lshw` command to hardware plugin

  [Eric Desrochers]
  * d/p/0004-lds-substitute-oidc-conf.patch:
    - landscape substitute oidc conf
      in service file (LP: #1874526)

  [Eric Desrochers]
  * d/tests/{control,simple.sh}: (LP: #1865212)
    - Add testsuite "simple.sh". A port of the travis tests to bash
      provided by upstream.

 -- Heather Lemon <email address hidden> Wed, 29 Apr 2020 14:04:05 +0000

Sponsored for Xenial.

It is now waiting for SRU verification team approval for the package to start building in xenial-proposed for the testing phase.

Thanks for your contribution Heather !

Hello Eric, or anyone else affected,

Accepted sosreport into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/3.9-1ubuntu0.16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[VERIFICATION XENIAL]

Testing using
Tested using focal sosreport: sosreport_3.9-1ubuntu0.16.04.2

# installed sosreport from proposed
$ pull-lp-source sosreport xenial-proposed
# cd into sosreport and run command
$ sudo ./sosreport -o hardware --config sos.conf
# untar tar created from sosreport
$ tar -xvf <name of tar file>
# find `lshw` command output
$ cd /tmp/<name of tar file>/sos_commands/hardware
# verify output of lshw command
$ less lshw
# verified command ran and its output was saved to lshw file

@Heather Lemon (hypothetical-lemon)

Thanks for your verification.

Could you please do the test one more time but this time using the binary package (and not testing the code from the source package) ?

Using the binary package will implictly allow one to conclude that the package is installable (including their dependencies), that the binaries are executed as expected, configuration (sos.conf) is in place, .... Basically, the test result will be closer to reality where users will install the sosreport binary package. They won't run sosreport from the source package.

Your test concludes the code works (without the packaging layer)

What we want to know is if the package of sosreport (binary package) works and do what we expect it to do.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.

- Eric

[VERIFICATION XENIAL]

Tested using sosreport: sosreport_3.9-1ubuntu0.16.04.2

# installed sosreport from proposed
$ sudo apt-get install sosreport/xenial-proposed
# run sosreport
$ sudo sosreport -o hardware
# untar tar created from sosreport
$ sudo tar -xvf <name of tar file>
# find `lshw` command output
$ cd /tmp/<name of tar file>/sos_commands/hardware
# verify output of lshw command
$ less lshw
# verified command ran and its output was saved to lshw file

- Thanks for catching that Eric!

This bug was fixed in the package sosreport - 3.9-1ubuntu0.16.04.2

---------------
sosreport (3.9-1ubuntu0.16.04.2) xenial; urgency=low

  * d/p/0002-lshw-command.patch (LP: #1871494)
    - Add `lshw` command to hardware plugin

 -- Heather Lemon <email address hidden> Wed, 22 Apr 2020 09:32:27 -0600