Trash-applet : when emptying, follows link when link and source are on different partitions
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| budgie-extras (Ubuntu) |
Fix Released
|
High
|
fossfreedom | ||
| Eoan |
Fix Released
|
High
|
fossfreedom | ||
| Focal |
Fix Released
|
High
|
fossfreedom | ||
Bug Description
[Impact]
* Budgie Trash Applet is an optional applet a user can add to their desktop.
* The applet has a feature to empty the current local drive trash can.
* Where users have folders located on additional hard-drives some people
access those folders via a symbolic link.
If the user deletes the symbolic link to a folder located on another
drive/partition, the trash-can appears full i.e. ready to be emptied.
Emptying the trash can will delete the symbolic link - but more importantly will delete everything that the symbolic link was pointing to.
* This upload ensures that the trash-can empty code respects the "do not follow symbolic link" GLIB File request so that it only processes the symbolic link.
* There is no impact on other desktop interfaces - this applet only works on the budgie-desktop
[Test Case]
* Requests a symbolic link to a folder located on another hard-drive or partition.
* In that folder include test files.
* Delete the symbolic link
* Choose the applet empty trash can option
* Examine if the symbolic link has been removed - yes is success
* Examine the folder and its contents that the symbolic link was originally pointing to - the folder and its contents are NOT deleted. This denotes success
[Regression Potential]
* There are multiple ways symbolic links can be used - nested within folders pointing to various other places. There is a regression potential that not all symbolic link use cases have been caught.
* However saying that - the basic use-case outlined here has been tested by the OP via a test PPA on 19.10. This is an SRU to formalise what has already been tested and proven to work.
* For budgie, emptying the trash-can via Nemo works as an alternative solution - the trash-can is an optional feature that can be removed if causing additional detrimental issues.
* Testers MUST have good backups of their system to ensure if any regressions can be mitigated through restores.
* There is no regression potential for other desktop interfaces - the applet is only applicable to budgie.
* It is an optional feature to the desktop and thus users who do not use
the applet will not be exposed to any potential regression in this area.
[Other Info]
* N/A
-----
Original description
See https:/
hi,
confirmation needed.
I suspect trash applet to delete not only symlink but also source file or folder to that link.
create a symlink to a folder containing many things.
Put it in trash.
Use trash-applet to empty trash → original folder and its content are deleted.
Create another symlink.
Put it in trash.
Use Nemo to empty trash → only link is deleted, and not original source.
Does anyone confirm ? If so, that sounds like a bug as I don’t expect source to be deleted when deleting a link.
ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: budgie-trash-applet 0.10.1-0ubuntu3
ProcVersionSign
Uname: Linux 5.3.0-46-generic x86_64
ApportVersion: 2.20.11-0ubuntu8.8
Architecture: amd64
CurrentDesktop: Budgie:GNOME
Date: Sat Apr 11 16:30:47 2020
InstallationDate: Installed on 2020-03-22 (19 days ago)
InstallationMedia: Ubuntu-Budgie 19.10 "Eoan Ermine" - Release amd64 (20191017)
SourcePackage: budgie-extras
UpgradeStatus: No upgrade log present (probably fresh install)
| Coeur Noir (coeur-noir) wrote | #1 |
| Changed in budgie-extras (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → fossfreedom (fossfreedom) |
| Changed in budgie-extras (Ubuntu Eoan): | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → fossfreedom (fossfreedom) |
| Coeur Noir (coeur-noir) wrote | #2 |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in budgie-extras (Ubuntu Focal): | |
| status: | In Progress → Fix Released |
| description: | updated |
| Changed in budgie-extras (Ubuntu Bionic): | |
| status: | New → Invalid |
| Brian Murray (brian-murray) wrote Please test proposed package | #5 |
| Changed in budgie-extras (Ubuntu Eoan): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed verification-needed-eoan |
| Coeur Noir (coeur-noir) wrote | #6 |
| fossfreedom (fossfreedom) wrote | #7 |
| tags: |
added: verification-done verification-done-eoan removed: verification-needed verification-needed-eoan |
| no longer affects: | budgie-extras (Ubuntu Bionic) |
| Łukasz Zemczak (sil2100) wrote Update Released | #8 |
| Launchpad Janitor (janitor) wrote | #9 |
| Changed in budgie-extras (Ubuntu Eoan): | |
| status: | Fix Committed → Fix Released |
Sorry for suggesting more work but as 18.04 is LTS supported until 2021 I guess, Bionic may be added ?