gnome-clocks crashed with SIGSEGV in g_date_time_to_timezone()

Bug #1873077 reported by Fabio Duran Verdugo
62
This bug affects 8 people
Affects Status Importance Assigned to Milestone
GNOME Clocks
Fix Released
Unknown
gnome-clocks (Ubuntu)
Fix Released
High
Unassigned
Focal
Fix Released
Medium
Unassigned

Bug Description

* Impact
The clocks software segfault on some locations

* Test case
- set the timezone ot Ambler (Alaska), clocks shouldn't segfault

the reports on e.u.c should also stop with the update
https://errors.ubuntu.com/problem/cdecc860143394fca4bd7a1eb2650a0865dcc9a2

* Regression potential
Check that the day start/end value look right

-----------------

after view the world clock

ProblemType: Crash
DistroRelease: Ubuntu 20.04
Package: gnome-clocks 3.36.0-1
ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
Uname: Linux 5.4.0-21-generic x86_64
ApportVersion: 2.20.11-0ubuntu26
Architecture: amd64
CasperMD5CheckResult: skip
CrashCounter: 1
CurrentDesktop: GNOME
Date: Wed Apr 15 16:37:26 2020
ExecutablePath: /usr/bin/gnome-clocks
ExecutableTimestamp: 1583690450
InstallationDate: Installed on 2020-03-20 (26 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Alpha amd64 (20200309)
ProcCmdline: /usr/bin/gnome-clocks --gapplication-service
ProcCwd: /home/fabio
SegvAnalysis:
 Segfault happened at: 0x7f35030f3300 <g_date_time_to_timezone+16>: mov 0x10(%rdi),%esi
 PC (0x7f35030f3300) ok
 source "0x10(%rdi)" (0x00000010) not located in a known VMA region (needed readable region)!
 destination "%esi" ok
SegvReason: reading NULL VMA
Signal: 11
SourcePackage: gnome-clocks
StacktraceTop:
 g_date_time_to_instant (datetime=0x0) at ../../../glib/gdatetime.c:2709
 g_date_time_to_timezone (datetime=datetime@entry=0x0, tz=0x561a2dbb4220) at ../../../glib/gdatetime.c:2709
 clocks_world_item_calculate_riseset (self=0x561a2d9f6620 [ClocksWorldItem]) at src/25a6634@@gnome-clocks@exe/world.c:1341
 clocks_world_item_real_tick (self=0x561a2d9f6620 [ClocksWorldItem]) at src/25a6634@@gnome-clocks@exe/world.c:2068
 <emit signal ??? on instance 0x561a2d9f6620 [ClocksWorldItem]> (instance=instance@entry=0x561a2d9f6620, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3554
Title: gnome-clocks crashed with SIGSEGV in g_date_time_to_instant()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip libvirt lpadmin lxd plugdev sambashare sudo
separator:

Revision history for this message
Fabio Duran Verdugo (fabioduran) wrote :
information type: Private → Public
Revision history for this message
Apport retracing service (apport) wrote :

StacktraceTop:
 g_date_time_to_timezone () from /tmp/apport_sandbox_hd9rilqt/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6400.1
 clocks_world_item_calculate_riseset (self=0x561a2d9f6620) at src/25a6634@@gnome-clocks@exe/world.c:1341
 clocks_world_item_real_tick (self=0x561a2d9f6620) at src/25a6634@@gnome-clocks@exe/world.c:2068
 g_closure_invoke () from /tmp/apport_sandbox_hd9rilqt/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.6400.1
 signal_emit_unlocked_R () from /tmp/apport_sandbox_hd9rilqt/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.6400.1

Revision history for this message
Apport retracing service (apport) wrote : Stacktrace.txt
Revision history for this message
Apport retracing service (apport) wrote : StacktraceSource.txt
Revision history for this message
Apport retracing service (apport) wrote : ThreadStacktrace.txt
Changed in gnome-clocks (Ubuntu):
importance: Undecided → Medium
summary: - gnome-clocks crashed with SIGSEGV in g_date_time_to_instant()
+ gnome-clocks crashed with SIGSEGV in g_date_time_to_timezone()
tags: removed: need-amd64-retrace
Changed in gnome-clocks (Ubuntu):
importance: Medium → High
status: New → Fix Committed
description: updated
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thank you for submitting this SRU Seb! I will accept it, but I must say that I am not a great fan of multi-patches patch files as you provided, it makes reviewing the changes harder. And dpkg-source doesn't like it as well: "diff 'gnome-clocks-3.36.0/debian/patches/git_twilight_segfault.patch' patches file gnome-clocks-3.36.0/src/twilight.c more than once".

Please be sure to either provide a single patch with all the needed patch-changes or separate patch files per patch-set next time.

Changed in gnome-clocks (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Fabio, or anyone else affected,

Accepted gnome-clocks into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-clocks/3.36.0-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
fcole90 (fcole90) wrote :

Hi, I installed the proposed version from here: http://launchpadlibrarian.net/478194856/gnome-clocks_3.36.0-1ubuntu0.1_amd64.deb

Everything works for me.

Revision history for this message
fcole90 (fcole90) wrote :

I tried Helsinki, Stockholm and Cagliari time zones, set a timer, tried stopwatch and timer. No issues.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
fcole90 (fcole90) wrote :

Also, timezones correctly appear in the Shell, when clicking on the time.

Revision history for this message
Mordi (mrdc76) wrote :

http://launchpadlibrarian.net/478194856/gnome-clocks_3.36.0-1ubuntu0.1_amd64.deb fixes this bug for me. Tested world clock, timer and stop watch.

Revision history for this message
Helio Victor (userhv) wrote :

http://launchpadlibrarian.net/478194856/gnome-clocks_3.36.0-1ubuntu0.1_amd64.deb corrected for me too. He reopened the application normally.

Revision history for this message
Fabio Duran Verdugo (fabioduran) wrote :

Yes! Fixes this bug for me too.

Mathew Hodson (mhodson)
tags: removed: verification-needed
Mathew Hodson (mhodson)
Changed in gnome-clocks (Ubuntu Focal):
importance: Undecided → Medium
Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in gnome-clocks (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-clocks - 3.36.0-1ubuntu0.1

---------------
gnome-clocks (3.36.0-1ubuntu0.1) focal; urgency=medium

  * debian/patches/git_twilight_segfault.patch:
    - backport a segfault fix from upstream in case where the twilight
      start can't be determined (lp: #1873077)

 -- Sebastien Bacher <email address hidden> Tue, 28 Apr 2020 11:31:23 +0200

Changed in gnome-clocks (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-clocks has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

There's a possible regression, please see bug 1878361.

Revision history for this message
Nishan Singh Mann (nishan-singh-mann) wrote :

Hi, `gnome-clocks --version`` shows Clocks 3.36.0 and I'm still experiencing segfault. I think that is the latest version with the fix that is working for some people above?

Changed in gnome-clocks:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.