Mahara

'Publish' button in peer assessment block dosn't have primary brand colour applied in theme 'Default'

Bug #1874961 reported by Kristina Hoeppner on 2020-04-25

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Unassigned	Mahara 20.04.0

Bug Description

When there is a peer assessment block on a page and a peer assessor is adding a peer assessment, the 'Publish' button doesn't have the primary brand colour applied in the 'Default' theme (see screenshot).

Steps to replicate:

1. As PersonA add a page with a peer assessment block.
2. Make the page available to PersonB and set PersonB as 'Peer assessor'.
3. Log in as PersonB and navigate to the page.
4. Click the 'Add a peer assessment' link.
Expected result: The 'Publish' button is displayed in the primary brand colour of the theme.
Actual result: The correct colour is missing in the 'Default' theme.

This is not a problem in any of the other themes.

Tags:

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2020-04-25:

peer_assessment_publish_button.png Edit (48.8 KiB, image/png)

tags:

added: front-end

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-04-27: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10934

Kristina Hoeppner (kris-hoeppner) on 2020-04-27

Changed in mahara:
status:	Confirmed → In Progress

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-04-28: A change has been merged

Reviewed: https://reviews.mahara.org/10934
Committed: https://git.mahara.org/mahara/mahara/commit/a0b379ed9d8c98bff510646823e505ffe1d1ead5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a0b379ed9d8c98bff510646823e505ffe1d1ead5
Author: Evonne <email address hidden>
Date: Tue Apr 28 08:56:06 2020 +1200

Bug 1874961 'Publish' button in peer assessment block Default theme

Previous fix corrected some variables, which in turn Default theme's
old styles overrode. 'Publish' button in peer assessment block now
has primary brand colour applied in Default theme.

behatnotneeded

Change-Id: Ie1e4e4eddeec38c839a5ca0d5a044cc80f9061fe

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-04-28: A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10938

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-04-28: A change has been merged

Reviewed: https://reviews.mahara.org/10938
Committed: https://git.mahara.org/mahara/mahara/commit/c207051651d9c9ed1bd36eb41fd96691b0201283
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit c207051651d9c9ed1bd36eb41fd96691b0201283
Author: Evonne <email address hidden>
Date: Tue Apr 28 08:56:06 2020 +1200

Bug 1874961 'Publish' button in peer assessment block Default theme

Previous fix corrected some variables, which in turn Default theme's
old styles overrode. 'Publish' button in peer assessment block now
has primary brand colour applied in Default theme.

behatnotneeded

Change-Id: Ie1e4e4eddeec38c839a5ca0d5a044cc80f9061fe
(cherry picked from commit a0b379ed9d8c98bff510646823e505ffe1d1ead5)

Robert Lyon (robertl-9) on 2020-04-28