[SRU] FSVS - not able to commit changes to remote HTTP SVN repo

Tried fsvs-1.2.9 - same effect. I guess something changed in subversion libraries.

Sorry, I only just now stumbled upon the launchpad bugs.

If that still persists, would you please send a debug log? Just run the same "fsvs" command with "-d", and redirect into a file. Thank you!

This bug probably still exists. I`m moving my 18.04 machines to 20.04 and I`m migrating to etckeeper (because of this bug). I currently don`t have any 20.04 machine with fsvs to generate this report and to confirm this bug still exists.

I`ve checked my old notes and found this may be connected to this bug: https://svn.haxx.se/dev/archive-2018-01/0057.shtml But I`m not 100% sure.

I think I found the problem -- a double-open.

https://github.com/phmarek/fsvs/commit/f39cc00b3200bcd7874faf4de15479dfa3e6762a

No idea how the code got duplicated here, though - and the old (svn) history is lost...

This has been fixed in v1.2.11 and so Noble is fixed. But Focal, Jammy, Lunar and Mantic are still affected. I will try to reproduce locally and open SRU for it.

I can reproduce the problem now and this is still seen on noble.

# dpkg -l | grep fsvs
ii fsvs 1.2.11-1 amd64 Full system versioning with metadata support

# fsvs commit -mstart
Authentication realm: <http://localhost:80> SVN reposity
Password for 'root': ****

Committing to http://localhost/svn/test
N... 13 .bash_history
N... 220 .bash_logout
N... 3771 .bashrc
N... dir .cache
N... 0 .cache/motd.legal-displayed
N... 807 .profile
N... dir .ssh
N... 0 .ssh/authorized_keys
N... 0 .sudo_as_admin_successful

An error occurred: The filesystem editor completion process was not followed (160050)
  in ci__work: editor->close_edit: Closing editor with directories or files open

I can not add upstream link to the bug, but I have now opened an issue at https://github.com/phmarek/fsvs/issues/18

Tagged 1.2.12.

debdiff attached for Mantic.

Uploaded to the Mantic queue; Sudip indicated there will be diffs for the rest of the releases sometime today.

Thanks for your help!

Removing ubuntu-sponsors until the new diffs come in, feel free to re-subscribe, or just ping me on IRC :)

debdiff for Lunar.

debdiff for Jammy.

debdiff for Focal.

> + * Apply upstream patch to close root_baton. (LP: #1875642)

The changelog entries of SRUs are exposed to users in e.g. the UI of update-manager. They should explain the changes in terms that users can understand.

As an Ubuntu developer, *I* don't know what this changelog means.

Please reupload with a changelog entry that's appropriate for an SRU.

Also, it's questionable to me whether this is something that warrants an SRU at all. The bug report is marked importance: medium; has been open for almost 4 years; and is for a package that uses subversion which is effectively obsolete?

An upload of fsvs to mantic-proposed has been rejected from the upload queue for the following reason: "inappropriate changelog entry for an SRU".

New debdiff for Mantic attached.

New debdiff for Jammy.

New debdiff for Focal.

I have not attached a debdiff for Lunar as it will be EOL in next few days and will not have 7 days time to propagate from proposed. But I can upload the debdiff if needed.

To answer the questions raised by Steve about this SRU, I think this issue should be fixed by a SRU.
My reasons:
1. fsvs has an active upstream who does look for bugs and actively fixes them.
2. subversion is still used and (surprisingly) Noble has a new micro release.
3. Ubuntu still ships SVN so applications which intefaces with SVN should be fixed.
4. imho, its a bad impression if a distro ships software with a known RC bug in a LTS release.

I largely agree with Sudip's analysis that, while subversion is certainly old and probably isn't a good choice for *new* projects, there're still plenty of installations out there and it's not good if users are upgrading and finding their installation breaks. Hence, it's worth fixing. Unfortunately I don't think Steve's point about the changelog being comprehensible to ordinary users is addressed. Previously the message was:

* Apply upstream patch to close root_baton

Now the message is:

* SVN will not commit changes for a http-URL if the root_baton is still open.
  Apply upstream patch to close root_baton properly

But in both cases I'm left with the question ... "what's a baton?!" (and apparently I'm not the first to ask this about SVN's code [1]). I'd suggest maybe changing this to something like:

* SVN fails to commit changes to http-URLs due to unclosed handle

Maybe "handles" is still a bit opaquely coder-speak, but it's a rather more common term than "batons" and seems to be vaguely analogous to batons in SVN (at least from my reading of [1])?

[1]: https://svn.haxx.se/dev/archive-2002-07/0396.shtml

Thanks Dave for the changelog idea. So, another attempt now.

Removed old debdiff and attaching new debdiff for Manctic.

Removed old debdiff and attaching new debdiff for Jammy.

Removed old debdiff and attaching new debdiff for Focal.

The new changelog entry LGTM.

I wonder why the jammy version is 1.2.9-2ubuntu0.22.04.3.1 instead of 1.2.9-2ubuntu0.22.04.1, following the same structure as the one in mantic.

I messed up again. :(

Fixed version in debdiff attached.

All sponsored, thank you

Hello Dariusz, or anyone else affected,

Accepted fsvs into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fsvs/1.2.9-2ubuntu0.23.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Dariusz, or anyone else affected,

Accepted fsvs into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fsvs/1.2.9-2ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Dariusz, or anyone else affected,

Accepted fsvs into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fsvs/1.2.7-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I can confirm that the fsvs package in mantic-proposed has fixed the bug for me.

Test done:
Installed fsvs from mantic-proposed.
Followed the testplan to setup apache2 and svn.
The final step "fsvs commit -mstart" has worked and gave me the output:

committed revision 1 on 2024-02-09T19:28:36.287137Z as root

Test result: the errors with fsvs has been fixed.

Package tested:

$ $ apt-cache policy fsvs
fsvs:
  Installed: 1.2.9-2ubuntu0.23.10.1
  Candidate: 1.2.9-2ubuntu0.23.10.1
  Version table:
 *** 1.2.9-2ubuntu0.23.10.1 100
        100 http://us.archive.ubuntu.com/ubuntu mantic-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     1.2.9-2 500
        500 http://us.archive.ubuntu.com/ubuntu mantic/universe amd64 Packages

I can confirm that the fsvs package in jammy-proposed has fixed the bug for me.

Test done:
Installed fsvs from jammy-proposed.
Followed the testplan to setup apache2 and svn.
The final step "fsvs commit -mstart" has worked and gave me the output:

committed revision 1 on 2024-02-09T19:38:32.165275Z as root

Test result: the errors with fsvs has been fixed.

Package tested:

$ apt-cache policy fsvs
fsvs:
  Installed: 1.2.9-2ubuntu0.22.04.1
  Candidate: 1.2.9-2ubuntu0.22.04.1
  Version table:
 *** 1.2.9-2ubuntu0.22.04.1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     1.2.9-2 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages

I can confirm that the fsvs package in focal-proposed has fixed the bug for me.

Test done:
Installed fsvs from focal-proposed.
Followed the testplan to setup apache2 and svn.
The final step "fsvs commit -mstart" has worked and gave me the output:

committed revision 1 on 2024-02-09T19:48:46.716801Z as root

Test result: the errors with fsvs has been fixed.

Package tested:

$ apt-cache policy fsvs
fsvs:
  Installed: 1.2.7-1ubuntu0.1
  Candidate: 1.2.7-1ubuntu0.1
  Version table:
 *** 1.2.7-1ubuntu0.1 500
        500 http://gb.archive.ubuntu.com/ubuntu focal-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     1.2.7-1build2 500
        500 http://gb.archive.ubuntu.com/ubuntu focal/universe amd64 Packages

This bug was fixed in the package fsvs - 1.2.9-2ubuntu0.23.10.1

---------------
fsvs (1.2.9-2ubuntu0.23.10.1) mantic; urgency=medium

  * SVN fails to commit changes to http-URLs due to unclosed handle.
    Apply upstream patch to close handle properly. (LP: #1875642)

 -- Sudip Mukherjee <email address hidden> Wed, 24 Jan 2024 12:44:02 +0000

The verification of the Stable Release Update for fsvs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package fsvs - 1.2.9-2ubuntu0.22.04.1

---------------
fsvs (1.2.9-2ubuntu0.22.04.1) jammy; urgency=medium

  * SVN fails to commit changes to http-URLs due to unclosed handle.
    Apply upstream patch to close handle properly. (LP: #1875642)

 -- Sudip Mukherjee <email address hidden> Wed, 24 Jan 2024 12:55:28 +0000

This bug was fixed in the package fsvs - 1.2.7-1ubuntu0.1

---------------
fsvs (1.2.7-1ubuntu0.1) focal; urgency=medium

  * SVN fails to commit changes to http-URLs due to unclosed handle.
    Apply upstream patch to close handle properly. (LP: #1875642)

 -- Sudip Mukherjee <email address hidden> Wed, 24 Jan 2024 13:01:36 +0000