Mahara

String missing for allow public views in Reports

Series 20.04
Bug #1879847

Bug #1879847 reported by Lisa Seeto on 2020-05-21

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Mahara
19.04	Fix Released	Medium	Unassigned	Mahara 19.04.6
19.10	Fix Released	Medium	Unassigned	Mahara 19.10.4
20.04	Fix Released	Medium	Unassigned	Mahara 20.04.1
20.10	Fix Released	Medium	Unassigned	Mahara 20.10.0

Bug Description

There is a what looks like a missing string when making a report that shows "Content".
The missing string shows up as: [[allowpublicviews/statistics]] on the page.

Repo steps:
- Log in as site admin and go to Admin menu -> Reports
- Select to 'Configure Report' to open the "Report Configuration" modal.
- In the 'Report type' drop down select 'Content' the save.
Expected results:
- Text displays correctly
Actual results:
- [[allowpublicviews/statistics]] appears in column.

Tags:

Revision history for this message

Lisa Seeto (lisaseeto) wrote on 2020-05-21:

Screenshot_2020-05-21 All institutions - Mahara.png Edit (9.5 KiB, image/png)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-03: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11001

Revision history for this message

Robert Lyon (robertl-9) wrote on 2020-06-03:

Actual issue is there are a few rows in the Content report that should not be showing

The 'allowpublicviews', 'allowpublicprofiles', and 'newstats' rows are not statistical data that changes over time but are flags that tell us if those options are enabled / disabled.

Useful for when a site has allowed statistic data to be sent to Mahara.org

But not useful when displaying Content data on report page.

I've added a patch to hide these values from the report page

Changed in mahara:
milestone:	none → 20.10.0
importance:	Undecided → Medium
status:	New → In Progress

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08: A change has been merged

Reviewed: https://reviews.mahara.org/11001
Committed: https://git.mahara.org/mahara/mahara/commit/bc29aaa35acff3ff1a13ab6ba2ef65f4a9e4c965
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit bc29aaa35acff3ff1a13ab6ba2ef65f4a9e4c965
Author: Robert Lyon <email address hidden>
Date: Wed Jun 3 12:35:22 2020 +1200

Bug 1879847: Removing non-content from Content report

As we were including data flags with accumulative statistics

Also updated the modal label about the columns

Change-Id: Iec2427c67273e6e51016934010118e1e25e80724
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08: A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11011

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08:

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11012

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08: A change has been merged

Reviewed: https://reviews.mahara.org/11011
Committed: https://git.mahara.org/mahara/mahara/commit/7bedb139e86c73f43798481d246689ce071d5b96
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit 7bedb139e86c73f43798481d246689ce071d5b96
Author: Robert Lyon <email address hidden>
Date: Wed Jun 3 12:35:22 2020 +1200

Bug 1879847: Removing non-content from Content report

As we were including data flags with accumulative statistics

Also updated the modal label about the columns

Change-Id: Iec2427c67273e6e51016934010118e1e25e80724
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bc29aaa35acff3ff1a13ab6ba2ef65f4a9e4c965)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08:

Reviewed: https://reviews.mahara.org/11012
Committed: https://git.mahara.org/mahara/mahara/commit/414352c68d0382ca60b40ec3b698c3c931efd9b2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 414352c68d0382ca60b40ec3b698c3c931efd9b2
Author: Robert Lyon <email address hidden>
Date: Wed Jun 3 12:35:22 2020 +1200

Bug 1879847: Removing non-content from Content report

As we were including data flags with accumulative statistics

Also updated the modal label about the columns

Change-Id: Iec2427c67273e6e51016934010118e1e25e80724
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bc29aaa35acff3ff1a13ab6ba2ef65f4a9e4c965)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08: A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11013

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-06-08: A change has been merged

#10

Reviewed: https://reviews.mahara.org/11013
Committed: https://git.mahara.org/mahara/mahara/commit/8fb705c4415635773a008633935e70e91c0f2e06
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 8fb705c4415635773a008633935e70e91c0f2e06
Author: Robert Lyon <email address hidden>
Date: Wed Jun 3 12:35:22 2020 +1200

Bug 1879847: Removing non-content from Content report

As we were including data flags with accumulative statistics

Also updated the modal label about the columns

Change-Id: Iec2427c67273e6e51016934010118e1e25e80724
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bc29aaa35acff3ff1a13ab6ba2ef65f4a9e4c965)
(cherry picked from commit 414352c68d0382ca60b40ec3b698c3c931efd9b2)