[SRU] Update gnome-clocks to 3.36.2

Bug #1879917 reported by Amr Ibrahim
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-clocks (Debian)
Fix Released
Unknown
gnome-clocks (Ubuntu)
Fix Released
Low
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

gnome-clocks 3.36.2 is a bug-fix release as part of GNOME 3.36.

https://gitlab.gnome.org/GNOME/gnome-clocks/-/blob/gnome-3-36/NEWS.md

It fixes two crashes related to handling world clocks, fixes the timer start button, fixes spamming the log with criticals, and fixes the stopwatch view not being scrollable to the bottom.

World: Handle impossible places
Timer: Fix signal for updating the duration

[Test case]

- Make sure all the functions work, adding world clocks, alarm, stopwatch and timer.

- Make sure that the timer start button is now enabled after entering minutes and/or seconds via keyboard or clicking on the plus and minus buttons.

- Start a stopwatch then add many laps until the view becomes scrollable and it can be scrolled to the bottom. Also clearing the stopwatch view should be smooth now.

[Regression potential]

• libcanberra is added to the flatpak .json because it was removed from the GNOME SDK. This is required for building the flatpak and does not affect running the application.

• Two crashes are fixed by adding more explicit casts and null checks in many places, and enabling the vala (experimental) null checker. The regression could be that the package doesn’t build any more, and/or the application loses functionality. However, it builds fine in my PPA for all architectures in Focal, and all functionalities run well.
https://gitlab.gnome.org/GNOME/gnome-clocks/-/commit/3e3cf17843d5dd2e645c7d5458b77dde93d99c94

• A fix is applied to the world clocks by handling impossible places to fix a crash and avoid spamming the log with criticals.
https://gitlab.gnome.org/GNOME/gnome-clocks/-/commit/237d63e57568185b1763e788b6768c3331b40848

• A fix is applied to improve the handling of zones where twilight times can’t be calculated. This helps to fix the same bug mentioned above. The regression potential is the same as above.
https://gitlab.gnome.org/GNOME/gnome-clocks/-/merge_requests/92

• The timer start button was not enabled after entering minutes and/or seconds via keyboard (and changing focus via the tab key). This is now fixed.
https://gitlab.gnome.org/GNOME/gnome-clocks/-/commit/32c1a3345e0523caf2e4eaef054b1aa7785cd4ae

• There was a theme parsing error. This is fixed now by ignoring the not-found resources.
https://gitlab.gnome.org/GNOME/gnome-clocks/-/commit/814bccd1794f7ede4621f05490fde8fb0d74615b

• The stopwatch view was not scrollable to the bottom when many laps were added to the stopwatch view, and there was an animation glitch when clearing the view. This is now fixed.
https://gitlab.gnome.org/GNOME/gnome-clocks/-/commit/76655a8b60c584395922ce7627b75124d518aa1d

• Version 3.36.2 has been in Groovy since June 2020 without bugs.

[Other]

gnome-clocks 3.36.2 has been successfully built as a no-change backport from Groovy to Focal in my PPA:

https://launchpad.net/~amribrahim1987/+archive/ubuntu/ppa/+packages?field.name_filter=gnome-clocks&field.status_filter=published&field.series_filter=

------------------------------------------------------------------------

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: gnome-clocks 3.36.0-1ubuntu0.1
ProcVersionSignature: Ubuntu 5.4.0-31.35-generic 5.4.34
Uname: Linux 5.4.0-31-generic x86_64
ApportVersion: 2.20.11-0ubuntu27
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Thu May 21 12:06:51 2020
InstallationDate: Installed on 2020-04-26 (24 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-clocks
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :
Changed in gnome-clocks (Debian):
status: Unknown → New
Changed in gnome-clocks (Debian):
status: New → Fix Released
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

Please SRU gnome-clocks 3.36.2 to Focal.

description: updated
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've updated but some comments

- the regression potential section of the description should point out what features should be tested to ensure there is no regression rather state a risk level. The purpose is to have an idea of what section of code changed to know what to watch for potential new problems

- the update dismiss the changelog entry from the previous SRU, it's not problematic since that was a backport of a patch that is in the new version but it's usually recommended to base the update on the current SRU

Changed in gnome-clocks (Ubuntu):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Robie Basak (racb) wrote :

Please address seb128's comments above by providing an updated regression analysis. See https://wiki.ubuntu.com/StableReleaseUpdates#Procedure for what we expect here. If this is not done soon, this update is likely to get rejected.

Changed in gnome-clocks (Ubuntu):
status: Fix Committed → Incomplete
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

I updated the regression analysis. Please review again.

description: updated
Revision history for this message
punny coder (punnycoder) wrote :

The [Bug #1898411](https://bugs.launchpad.net/ubuntu/+source/gnome-clocks/+bug/1898411) that affects the current "gnome-clocks 3.36.0" cannot be reproduced on "gnome-clocks 3.36.2". This update appears to have fixed my issue with adding south pole time on the world clock.

I have checked via this ppa:
"deb http://ppa.launchpad.net/amribrahim1987/ppa/ubuntu focal main"

punny coder (punnycoder)
Changed in gnome-clocks (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Robie Basak (racb) wrote :

I see new build dependencies appstream-util <!nocheck> and desktop-file-utils <!nocheck> being added. But these haven't been mentioned in this bug. What's the purpose of adding these, and how will they affect the build?

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

According to the Debian maintainer, the new build-dependencies are needed to check the formatting of the files. That change was applied in 3.36.2 and forward in Debian and Ubuntu, so it was a packaging oversight in 3.36.0.
https://salsa.debian.org/gnome-team/gnome-clocks/-/commit/d482d40f614d42048646478ae08d5c22b14a9c06

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Amr, or anyone else affected,

Accepted gnome-clocks into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-clocks/3.36.2-1~ubuntu20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-clocks (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

I have been using gnome-clocks 3.36.2-1~ubuntu20.04.1 for quite some time now and all the functions work well, adding world clocks, alarm, stopwatch and timer. Gnome shell shows the world clocks just fine after adding them to gnome-clocks.

I confirm that the timer start button is now enabled after entering minutes and/or seconds via keyboard or clicking on the plus and minus buttons.

I confirm that the stopwatch view is scrollable after adding many laps and it can be scrolled to the bottom. Also clearing the stopwatch view is smooth now.

tags: added: verification-done-focal
removed: verification-needed verification-needed-focal
Changed in gnome-clocks (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-clocks has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-clocks - 3.36.2-1~ubuntu20.04.1

---------------
gnome-clocks (3.36.2-1~ubuntu20.04.1) focal; urgency=medium

  * No-change backport to focal (LP: #1879917)

gnome-clocks (3.36.2-1) unstable; urgency=medium

  * New upstream release (Closes: #961198)
  * Drop debian/patches/world-handle-null-datetime.patch, applied upstream
  * debian/control.in: Add appstream-util and desktop-file-utils to the BD

gnome-clocks (3.36.0-2) unstable; urgency=medium

  * Fix crash due to null datetime, patch from upstream

 -- Amr Ibrahim <email address hidden> Sat, 12 Sep 2020 18:12:18 +0200

Changed in gnome-clocks (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.