[Impact]
* ZSys user autosave feature was trying to save GDM users on systems that don’t have their GDM session teared down after logged in (nvidia binary driver).
* The saving was failing as no GDM dataset was created.This was only visible in logs:
mai 12 09:41:27 casanier zsysd[48398]: gdm
mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state for user \"gdm\":user \"gdm\" doesn't exist"
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main process exited, code=exited, status=1/FAILURE
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed with result 'exit-code'.
mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user state periodically.
[Test Case]
1. Install the new ZSys on a machine which gdm session doesn’t tear down
2. Wait for 5 minutes after boot so that the autosave user timer is triggered.
3. Check the logs: the timer isn’t ran for gdm user.
[Regression Potential]
* The fix is about adding ConditionUser=!@system to the systemd user autosave features, so that any user with UID < 1000 (which are the users we don’t create user datasets for) are not considered.
* The failure was silent for most of users who don’t look at the logs.
-----
From the log:
mai 12 09:41:27 casanier zsysd[48398]: gdm
mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state for user \"gdm\":user \"gdm\" doesn't exist"
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main process exited, code=exited, status=1/FAILURE
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed with result 'exit-code'.
mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user state periodically.
mai 12 09:42:27 casanier systemd[1]: zsysd.service: Succeeded.
We should avoid by default logging user ID < 1000 but root rather than outputting an error.
This bug was fixed in the package zsys - 0.5.0
---------------
zsys (0.5.0) groovy; urgency=medium
[ Jean-Baptiste Lallement ]
[ Didier Roche ]
* Fix infinite GC loop (LP: #1870461)
* Enhance timeout handling to avoid error rpc error: code = DeadlineExceeded
desc = context deadline exceeded while the daemon is doing work
(LP: #1875564)
* Stop taking automated or manual snapshot when there is less than 20% of
free disk space (LP: #1876334)
* Enable trim support for upgrading users (LP: #1881540)
* Only clean up previously linked user datasets when unlinked under USERDATA
(LP: #1881538)
* Strategy for deleted user datasets via a new hidden command called by
userdel (LP: #1870058)
* Get better auto snapshots message when integrated to apt (LP: #1875420)
* Update LastUsed on shutdown via a new hidden command service call
(LP: #1881536)
* Prevent segfault immediately after install when zfs kernel module isn't
loaded (LP: #1881541)
* Don’t try to autosave gdm user (and in general non system user), even if
systemd --user is started for them. (LP: #1881539)
* Prevent apt printing errors when zsys is removed without purge
(LP: #1881535)
* Some tests enhancements:
- new tests for all the above
- allow setting a different local socket for debugging/tests purposes only
- ascii order datasets in golden files
* Typos and messages fixes. Direct prints are not prefixed with INFO
anymore.
* Refreshed po and readme with the above.
-- Didier Roche <email address hidden> Mon, 01 Jun 2020 09:26:52 +0200