OpenStack Shared File Systems Service (Manila)

delete manage_error share will lead to quota error

Bug #1883506 reported by haixin on 2020-06-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	haixin	OpenStack Shared File Systems Service (Manila) wallaby-rc1

Bug Description

in manage share scheduler process, if failed to scheduler, the share size is 1, and have not commit quota usages, i think the
default share size is 1 is unreasonable, because we don't know the real size of the share in storage。so the default
size should be 0,then when admin force delete or unmange this manage_error share, will also quota cuts the usages, this is also unreasonable, this may lead to quota error.

in share mange layer，in function of manage_share(),if failed to get the real size of share, will raise, and also will not commit quota usages, then the size of share be set to 1. after admin force delete or umanage this share also lead to quota logic error.

in order to solve this problem, we should add to more status of share, they are STATUS_MANAGE_ERROR_DELETING:manage_error_deleting and
STATUS_MANAGE_ERROR_UNMANAGING:manage_error_unmanage_starting
when admin force delete or umanage the share,we shoud determine whether the status of share in above two, if in, we shoud skip quota usages cuts.

See original description

Tags:

haixin (haixin77) on 2020-06-15

Changed in manila:
assignee:	nobody → haixin (haixin77)

haixin (haixin77) on 2020-07-17

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-07-17: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/741588

Changed in manila:
status:	New → In Progress

Vida Haririan (vhariria) on 2020-08-20

Changed in manila:
importance:	Undecided → Medium
milestone:	none → victoria-rc1

Revision history for this message

Vida Haririan (vhariria) wrote on 2020-08-20:

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-08-20-15.00.log.html

OpenStack Infra (hudson-openstack) on 2020-09-15

Changed in manila:
assignee:	haixin (haixin77) → Brin Zhang (zhangbailin)

OpenStack Infra (hudson-openstack) on 2020-09-15

Changed in manila:
assignee:	Brin Zhang (zhangbailin) → haixin (haixin77)

Revision history for this message

Goutham Pacha Ravi (gouthamr) wrote on 2020-09-24:

Hey Haixin,

Thank you for reporting this bug, and for working on the bugfix patch (https://review.opendev.org/741588). Since it changes share states, I was hoping we could
get some reviewer attention on it - that's unfortunately not happened, and
we're closing the Victoria cycle today (09/24/2020) - so I'm retargeting this
bug to wallaby-1.

Changed in manila:
milestone:	victoria-rc1 → wallaby-1

Goutham Pacha Ravi (gouthamr) on 2020-12-10

Changed in manila:
milestone:	wallaby-1 → wallaby-2

Goutham Pacha Ravi (gouthamr) on 2021-01-22

Changed in manila:
milestone:	wallaby-2 → wallaby-3

Revision history for this message

Vida Haririan (vhariria) wrote on 2021-02-18:

Additional comments http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-02-18-15.00.log.html

Goutham Pacha Ravi (gouthamr) on 2021-03-16

tags:

added: wallaby-rc-bugsquash

Goutham Pacha Ravi (gouthamr) on 2021-03-21

Changed in manila:
milestone:	wallaby-3 → wallaby-rc1

Goutham Pacha Ravi (gouthamr) on 2021-03-26

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-03-26: Fix included in openstack/manila 12.0.0.0rc1

This issue was fixed in the openstack/manila 12.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-22: Fix merged to manila (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/manila/+/782733
Committed: https://opendev.org/openstack/manila/commit/19767c4f56c57fc3369e9f09c84a6fd0e32e562b
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 19767c4f56c57fc3369e9f09c84a6fd0e32e562b
Author: haixin <email address hidden>
Date: Fri Jul 17 15:18:44 2020 +0800

fix unmange share with manage_error status will lead to quota error

    if we failed to manage a share, we don't need to commit the quota usages. so
    we should skip quota usages cuts when delete or unmange the share with
    status of "error_manage". and the size of error_manage share should be
    zero.
    we should depends on manila-tempest with max_api_microversion is 2.57,
    below depends id is the is the latest version number before the 2.61
    upgrade.

Closes-Bug:#1883506

Change-Id: I5c81dd6780890c55c8c6a92491c3f4f507531fdb
(cherry picked from commit 73d0a74f3b7c93e0be8779c959b74bdb5b9fd57f)

tags:

added: in-stable-victoria

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-11-12: Fix included in openstack/manila 11.1.0

This issue was fixed in the openstack/manila 11.1.0 release.