Ubuntu
cadvisor package

containerd library package is not working with vendorized deps

Bug #1884663 reported by Lucas Kanashiro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cadvisor (Ubuntu)
Fix Released
Undecided
Unassigned
containerd (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Currently, version 0.35.0+ds1-4 FTBFS in Groovy because of a bug in the `golang-github-containerd-containerd-dev` package. The containerd library package provides all the dependencies vendorized and there is a namespace issue. I started a discussion here to figure out the best way to tackle this problem:

https://github.com/tianon/debian-containerd/issues/11

Lucas Kanashiro (lucaskanashiro)
summary: - Version 0.35.0+ds1-4 FTBFS in Groovy
+ cadvisor/0.35.0+ds1-4 FTBFS in Groovy
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote : Re: cadvisor/0.35.0+ds1-4 FTBFS in Groovy

The attached debdiff contains a workaround for this issue, it disables the containerd support. With this new version the package builds fine and autopkgtest passes.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Above is attached a cadvisor debdiff, I forgot to mention it.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

mwhudson gave a +1 for this cadvisor debdiff as a workaround for now:

"<mwhudson> kanashiro: yes, that debdiff is fine for now"

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

cadvisor is uploaded.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cadvisor - 0.35.0+ds1-4ubuntu1

---------------
cadvisor (0.35.0+ds1-4ubuntu1) groovy; urgency=medium

  * d/p/0008-disable-containerd.patch: golang-github-containerd-containerd-dev
    is not working due to the vendorized dependencies (LP: #1884663)
  * Add dependency on golang-github-opencontainers-go-digest-dev,
    golang-github-opencontainers-image-spec-dev, and
    golang-github-seandolphin-bqschema-dev. Those packages were indirectly
    provided by containerd.

 -- Lucas Kanashiro <email address hidden> Tue, 23 Jun 2020 15:50:56 -0300

Changed in cadvisor (Ubuntu):
status: New → Fix Released
Lucas Kanashiro (lucaskanashiro)
summary: - cadvisor/0.35.0+ds1-4 FTBFS in Groovy
+ containerd library package is not working with vendorized deps
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I forgot to mention this LP bug in the changelog but the vendor code in the golang-github-containerd-containerd-dev package was removed. It would never work with vendor code anyway. The fix is in version 1.3.6-0ubuntu1.

The side effect is that now packages which depends on the containerd library package now need to declare dependencies that were previously provided by the vendor code. At the moment just 2 source packages are impacted by this change in Groovy: cadvisor and golang-github-openshift-imagebuilder.

Attached you can find 2 debdiffs that will fix the FTBFS of those 2 packages when built with containerd 1.3.6-0ubuntu1.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

containerd/1.3.6-0ubuntu1 which fixes the library issue (take a look at comment #6) migrated to the release pocket.

Changed in containerd (Ubuntu):
status: New → Fix Released
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

At the moment cadvisor and golang-github-openshift-imagebuilder FTBFS, I am uploading the attached debdiffs to fix them.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.