OpenStack Compute (nova)

failures during driver.pre_live_migration remove source attachments during rollback

Bug #1889108 reported by Lee Yarwood
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Lee Yarwood
Queens
Fix Released
Undecided
Lee Yarwood
Rocky
Fix Released
Undecided
Lee Yarwood
Stein
Fix Released
Undecided
Lee Yarwood
Train
Fix Released
Undecided
Lee Yarwood
Ussuri
Fix Released
Undecided
Lee Yarwood

Bug Description

Description
===========

$subject, the initial rollback and removal of any destination volume attachments is then repeated for the source volume attachments, leaving the volumes connected on the host but listed as `available` in cinder.

Steps to reproduce
==================
Cause a failure during the call to driver.pre_live_migration with volumes attached.

Expected result
===============
Any volume attachments for the destination host are deleted during the rollback.

Actual result
=============
Both sets of volumes attachments for the destination *and* the source are removed.

Environment
===========
1. Exact version of OpenStack you are running. See the following
  list for all releases: http://docs.openstack.org/releases/

   eeeb964a5f65e6ac31dfb34b1256aaf95db5ba3a

2. Which hypervisor did you use?
   (For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...)
   What's the version of that?

   libvirt + KVM

2. Which storage type did you use?
   (For example: Ceph, LVM, GPFS, ...)
   What's the version of that?

   N/A

3. Which networking type did you use?
   (For example: nova-network, Neutron with OpenVSwitch, ...)

   N/A

Logs & Configs
==============

When live-migration fails with attached volume changed to active and still in nova
https://bugzilla.redhat.com/show_bug.cgi?id=1860914

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/743289

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/743319

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.opendev.org/743289
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4c970f499c31370495d84c91a10319d308d13fb9
Submitter: Zuul
Branch: master

commit 4c970f499c31370495d84c91a10319d308d13fb9
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 18:18:28 2020 +0100

    Add regression tests for bug #1889108

    Related-Bug: #1889108
    Change-Id: Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/744161

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/744162

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/743319
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2102f1834a6ac9fd870bfb457b28a2172f33e281
Submitter: Zuul
Branch: master

commit 2102f1834a6ac9fd870bfb457b28a2172f33e281
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 19:27:24 2020 +0100

    compute: Don't delete the original attachment during pre LM rollback

    I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
    migration with cinderv3 volume attachments during Queens. This initial
    support handled failures in pre_live_migration directly by removing any
    attachments created on the destination and reverting to the original
    attachment ids before re-raising the caught exception to the source
    compute. It also added rollback code within the main
    _rollback_live_migration method but missed that this would also be
    called during a pre_live_migration rollback.

    As a result after a failure in pre_live_migration
    _rollback_live_migration will attempt to delete the source host volume
    attachments referenced by the bdm before updating the bdms with the now
    non-existent attachment ids, leaving the volumes in an `available` state
    in Cinder as they have no attachment records associated with them
    anymore.

    This change aims to resolve this within _rollback_volume_bdms by
    ensuring that the current and original attachment_ids are not equal
    before requesting that the current attachment referenced by the bdm is
    deleted. When called after a failure in pre_live_migration this should
    result in no attempt being made to remove the original source host
    attachments from Cinder.

    Note that the following changes muddy the waters slightly here but
    introduced no actual changes to the logic within
    _rollback_live_migration:

    * I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
      handling in Rocky but isn't the source of the issue here.

    * Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
      _rollback_live_migration to use the provided source_bdms.

    * I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
      _rollback_live_migration, moving the logic into a self contained
      _rollback_volume_bdms method.

    Closes-Bug: #1889108
    Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/ussuri)

Reviewed: https://review.opendev.org/744161
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6db72002a65f30ac44b8df0a642b400ea272247e
Submitter: Zuul
Branch: stable/ussuri

commit 6db72002a65f30ac44b8df0a642b400ea272247e
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 18:18:28 2020 +0100

    Add regression tests for bug #1889108

    Related-Bug: #1889108
    Change-Id: Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562
    (cherry picked from commit 4c970f499c31370495d84c91a10319d308d13fb9)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ussuri)

Reviewed: https://review.opendev.org/744162
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=034b2fa8fea0e34fed95a2ba728e4387ce4e78de
Submitter: Zuul
Branch: stable/ussuri

commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 19:27:24 2020 +0100

    compute: Don't delete the original attachment during pre LM rollback

    I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
    migration with cinderv3 volume attachments during Queens. This initial
    support handled failures in pre_live_migration directly by removing any
    attachments created on the destination and reverting to the original
    attachment ids before re-raising the caught exception to the source
    compute. It also added rollback code within the main
    _rollback_live_migration method but missed that this would also be
    called during a pre_live_migration rollback.

    As a result after a failure in pre_live_migration
    _rollback_live_migration will attempt to delete the source host volume
    attachments referenced by the bdm before updating the bdms with the now
    non-existent attachment ids, leaving the volumes in an `available` state
    in Cinder as they have no attachment records associated with them
    anymore.

    This change aims to resolve this within _rollback_volume_bdms by
    ensuring that the current and original attachment_ids are not equal
    before requesting that the current attachment referenced by the bdm is
    deleted. When called after a failure in pre_live_migration this should
    result in no attempt being made to remove the original source host
    attachments from Cinder.

    Note that the following changes muddy the waters slightly here but
    introduced no actual changes to the logic within
    _rollback_live_migration:

    * I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
      handling in Rocky but isn't the source of the issue here.

    * Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
      _rollback_live_migration to use the provided source_bdms.

    * I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
      _rollback_live_migration, moving the logic into a self contained
      _rollback_volume_bdms method.

    Closes-Bug: #1889108
    Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085
    (cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/748494

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/748496

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/748513

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/748514

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/749226

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/749227

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/749232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/749233

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/train)

Reviewed: https://review.opendev.org/748494
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6a9bb79fc088f4f888373a6ab2c8a70f143aa20d
Submitter: Zuul
Branch: stable/train

commit 6a9bb79fc088f4f888373a6ab2c8a70f143aa20d
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 18:18:28 2020 +0100

    Add regression tests for bug #1889108

    NOTE(lyarwood): Various changes were required to get this to work on
    stable/train without backporting a considerable number of changes to the
    func tests including the following:

    - Adding TestVolAttachmentsDuringPreLiveMigration to super() as
      functional tests run against py27
    - Adding USE_NEUTRON=True
    - Adding api_major_version='v2.1'
    - Adding self.api to self._wait_for_state_change calls
    - Removing the use of _build_server and crafting the server creation
      request by hand
    - Removing the use of _live_migrate and crafting the live migration
      request by hand

    Related-Bug: #1889108
    Change-Id: Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562
    (cherry picked from commit 4c970f499c31370495d84c91a10319d308d13fb9)
    (cherry picked from commit 6db72002a65f30ac44b8df0a642b400ea272247e)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/train)

Reviewed: https://review.opendev.org/748496
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c6c3483a41c2a53bcfafdfe3475283b0379f7f1d
Submitter: Zuul
Branch: stable/train

commit c6c3483a41c2a53bcfafdfe3475283b0379f7f1d
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 19:27:24 2020 +0100

    compute: Don't delete the original attachment during pre LM rollback

    I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
    migration with cinderv3 volume attachments during Queens. This initial
    support handled failures in pre_live_migration directly by removing any
    attachments created on the destination and reverting to the original
    attachment ids before re-raising the caught exception to the source
    compute. It also added rollback code within the main
    _rollback_live_migration method but missed that this would also be
    called during a pre_live_migration rollback.

    As a result after a failure in pre_live_migration
    _rollback_live_migration will attempt to delete the source host volume
    attachments referenced by the bdm before updating the bdms with the now
    non-existent attachment ids, leaving the volumes in an `available` state
    in Cinder as they have no attachment records associated with them
    anymore.

    This change aims to resolve this within _rollback_volume_bdms by
    ensuring that the current and original attachment_ids are not equal
    before requesting that the current attachment referenced by the bdm is
    deleted. When called after a failure in pre_live_migration this should
    result in no attempt being made to remove the original source host
    attachments from Cinder.

    Note that the following changes muddy the waters slightly here but
    introduced no actual changes to the logic within
    _rollback_live_migration:

    * I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
      handling in Rocky but isn't the source of the issue here.

    * Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
      _rollback_live_migration to use the provided source_bdms.

    * I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
      _rollback_live_migration, moving the logic into a self contained
      _rollback_volume_bdms method.

    Closes-Bug: #1889108
    Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085
    (cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)
    (cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/748513
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=06d9d0d70542f2f9846ca8f40aef531cec0329a2
Submitter: Zuul
Branch: stable/stein

commit 06d9d0d70542f2f9846ca8f40aef531cec0329a2
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 18:18:28 2020 +0100

    Add regression tests for bug #1889108

    NOTE(lyarwood): The only required changes in stable/stein is the switch
    the original CinderFixtureNewAttachFlow fixture.

    Related-Bug: #1889108
    Change-Id: Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562
    (cherry picked from commit 4c970f499c31370495d84c91a10319d308d13fb9)
    (cherry picked from commit 6db72002a65f30ac44b8df0a642b400ea272247e)
    (cherry picked from commit 6a9bb79fc088f4f888373a6ab2c8a70f143aa20d)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/748514
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6007c41aa830e1d1e227a8c66285b2eb32fe9a7c
Submitter: Zuul
Branch: stable/stein

commit 6007c41aa830e1d1e227a8c66285b2eb32fe9a7c
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 19:27:24 2020 +0100

    compute: Don't delete the original attachment during pre LM rollback

    I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
    migration with cinderv3 volume attachments during Queens. This initial
    support handled failures in pre_live_migration directly by removing any
    attachments created on the destination and reverting to the original
    attachment ids before re-raising the caught exception to the source
    compute. It also added rollback code within the main
    _rollback_live_migration method but missed that this would also be
    called during a pre_live_migration rollback.

    As a result after a failure in pre_live_migration
    _rollback_live_migration will attempt to delete the source host volume
    attachments referenced by the bdm before updating the bdms with the now
    non-existent attachment ids, leaving the volumes in an `available` state
    in Cinder as they have no attachment records associated with them
    anymore.

    This change aims to resolve this within _rollback_volume_bdms by
    ensuring that the current and original attachment_ids are not equal
    before requesting that the current attachment referenced by the bdm is
    deleted. When called after a failure in pre_live_migration this should
    result in no attempt being made to remove the original source host
    attachments from Cinder.

    Note that the following changes muddy the waters slightly here but
    introduced no actual changes to the logic within
    _rollback_live_migration:

    * I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
      handling in Rocky but isn't the source of the issue here.

    * Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
      _rollback_live_migration to use the provided source_bdms.

    * I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
      _rollback_live_migration, moving the logic into a self contained
      _rollback_volume_bdms method.

    Closes-Bug: #1889108
    Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085
    (cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)
    (cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)
    (cherry picked from commit c6c3483a41c2a53bcfafdfe3475283b0379f7f1d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/rocky)

Reviewed: https://review.opendev.org/749226
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7b2662c85ca304d5d9cf026858ec4102a477c36e
Submitter: Zuul
Branch: stable/rocky

commit 7b2662c85ca304d5d9cf026858ec4102a477c36e
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 18:18:28 2020 +0100

    Add regression tests for bug #1889108

    Related-Bug: #1889108
    Change-Id: Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562
    (cherry picked from commit 4c970f499c31370495d84c91a10319d308d13fb9)
    (cherry picked from commit 6db72002a65f30ac44b8df0a642b400ea272247e)
    (cherry picked from commit 6a9bb79fc088f4f888373a6ab2c8a70f143aa20d)
    (cherry picked from commit 06d9d0d70542f2f9846ca8f40aef531cec0329a2)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/rocky)

Reviewed: https://review.opendev.org/749227
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b18e93a2a486cc91e3867cefd68d223359d14bed
Submitter: Zuul
Branch: stable/rocky

commit b18e93a2a486cc91e3867cefd68d223359d14bed
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 19:27:24 2020 +0100

    compute: Don't delete the original attachment during pre LM rollback

    I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
    migration with cinderv3 volume attachments during Queens. This initial
    support handled failures in pre_live_migration directly by removing any
    attachments created on the destination and reverting to the original
    attachment ids before re-raising the caught exception to the source
    compute. It also added rollback code within the main
    _rollback_live_migration method but missed that this would also be
    called during a pre_live_migration rollback.

    As a result after a failure in pre_live_migration
    _rollback_live_migration will attempt to delete the source host volume
    attachments referenced by the bdm before updating the bdms with the now
    non-existent attachment ids, leaving the volumes in an `available` state
    in Cinder as they have no attachment records associated with them
    anymore.

    This change aims to resolve this within _rollback_volume_bdms by
    ensuring that the current and original attachment_ids are not equal
    before requesting that the current attachment referenced by the bdm is
    deleted. When called after a failure in pre_live_migration this should
    result in no attempt being made to remove the original source host
    attachments from Cinder.

    Note that the following changes muddy the waters slightly here but
    introduced no actual changes to the logic within
    _rollback_live_migration:

    * I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
      handling in Rocky but isn't the source of the issue here.

    * Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
      _rollback_live_migration to use the provided source_bdms.

    * I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
      _rollback_live_migration, moving the logic into a self contained
      _rollback_volume_bdms method.

    Closes-Bug: #1889108
    Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085
    (cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)
    (cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)
    (cherry picked from commit c6c3483a41c2a53bcfafdfe3475283b0379f7f1d)
    (cherry picked from commit 6007c41aa830e1d1e227a8c66285b2eb32fe9a7c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/queens)

Reviewed: https://review.opendev.org/749232
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5a8d5e93c5b294345c7e02ace20e84f7aadf5a9e
Submitter: Zuul
Branch: stable/queens

commit 5a8d5e93c5b294345c7e02ace20e84f7aadf5a9e
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 18:18:28 2020 +0100

    Add regression tests for bug #1889108

    NOTE(lyarwood): nova.virt.fake.set_nodes() is required on stable/queens
    to avoid duplicate hostnames.

    Related-Bug: #1889108
    Change-Id: Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562
    (cherry picked from commit 4c970f499c31370495d84c91a10319d308d13fb9)
    (cherry picked from commit 6db72002a65f30ac44b8df0a642b400ea272247e)
    (cherry picked from commit 6a9bb79fc088f4f888373a6ab2c8a70f143aa20d)
    (cherry picked from commit 06d9d0d70542f2f9846ca8f40aef531cec0329a2)
    (cherry picked from commit 7b2662c85ca304d5d9cf026858ec4102a477c36e)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.opendev.org/749233
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=65a888fbaa8b4ee7c409e00ba069c5cc343c0f63
Submitter: Zuul
Branch: stable/queens

commit 65a888fbaa8b4ee7c409e00ba069c5cc343c0f63
Author: Lee Yarwood <email address hidden>
Date: Mon Jul 27 19:27:24 2020 +0100

    compute: Don't delete the original attachment during pre LM rollback

    I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
    migration with cinderv3 volume attachments during Queens. This initial
    support handled failures in pre_live_migration directly by removing any
    attachments created on the destination and reverting to the original
    attachment ids before re-raising the caught exception to the source
    compute. It also added rollback code within the main
    _rollback_live_migration method but missed that this would also be
    called during a pre_live_migration rollback.

    As a result after a failure in pre_live_migration
    _rollback_live_migration will attempt to delete the source host volume
    attachments referenced by the bdm before updating the bdms with the now
    non-existent attachment ids, leaving the volumes in an `available` state
    in Cinder as they have no attachment records associated with them
    anymore.

    This change aims to resolve this within _rollback_volume_bdms by
    ensuring that the current and original attachment_ids are not equal
    before requesting that the current attachment referenced by the bdm is
    deleted. When called after a failure in pre_live_migration this should
    result in no attempt being made to remove the original source host
    attachments from Cinder.

    Note that the following changes muddy the waters slightly here but
    introduced no actual changes to the logic within
    _rollback_live_migration:

    * I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
      handling in Rocky but isn't the source of the issue here.

    * Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
      _rollback_live_migration to use the provided source_bdms.

    * I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
      _rollback_live_migration, moving the logic into a self contained
      _rollback_volume_bdms method.

    Closes-Bug: #1889108
    Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085
    (cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)
    (cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)
    (cherry picked from commit c6c3483a41c2a53bcfafdfe3475283b0379f7f1d)
    (cherry picked from commit 6007c41aa830e1d1e227a8c66285b2eb32fe9a7c)
    (cherry picked from commit b18e93a2a486cc91e3867cefd68d223359d14bed)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova queens-eol

This issue was fixed in the openstack/nova queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova rocky-eol

This issue was fixed in the openstack/nova rocky-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.