Explicit dependency on python3-infinity isn't needed

Bug #1890561 reported by Iain Lane
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
intervals (Ubuntu)
Fix Released
Undecided
Chris MacNaughton

Bug Description

When reviewing the package for source NEW, I noticed there's a dependency on python3-infinity. Usually python3 packages get these from requires.txt automatically (via ${python3:Depends}).

I tried a test build with this dependency dropped [and DH_VERBOSE=1, to see the below] and it works correctly.

D: dh_python3 fs:260: package python3-intervals details = {'requires.txt': {'debian/python3-intervals/usr/lib/python3/dist-packages/intervals-0.9.0.egg-info/requires.txt'}, 'egg-info': set(), 'nsp.txt': set(), 'shebangs': set(), 'public_vers': {Version('3')}, 'private_dirs': {}, 'compile': True, 'ext_vers': set(), 'ext_no_version': set()}
D: dh_python3 depends:117: generating dependencies for package python3-intervals
D: dh_python3 pydist:142: trying to find dependency for infinity>=0.1.3 (python=None)
D: dh_python3 pydist:210: invoking dpkg -S *python3/*/[Ii][Nn][Ff][Ii][Nn][Ii][Tt][Yy]-?*\.egg-info
D: dh_python3 depends:275: D={'python3-infinity', 'python3:any'}; R=[]; S=[]; E=[], B=[]; RT=[]

On the next upload, please could you drop the python3-intervals dependency?

summary: - Explicit dependency on python3-intervals isn't needed
+ Explicit dependency on python3-infinity isn't needed
description: updated
Changed in intervals (Ubuntu):
assignee: nobody → Chris MacNaughton (chris.macnaughton)
status: New → In Progress
Revision history for this message
Corey Bryant (corey.bryant) wrote :

I think it has a pretty hard dependency on infinity, specifically the code in intervals/interval.py:

corey@corey-ThinkPad-T440s:/tmp/intervals-0.9.0$ grep -r infinity|grep import
README.rst: >>> from infinity import inf
README.rst: >>> from infinity import inf
intervals/interval.py:from infinity import inf, is_infinite
tests/interval/test_initialization.py:from infinity import inf
tests/interval/test_properties.py:from infinity import inf
tests/interval/test_coercion.py:from infinity import inf
tests/interval/test_factory_methods.py:from infinity import inf
tests/interval/test_operators.py:from infinity import inf

Revision history for this message
Corey Bryant (corey.bryant) wrote :

I think I misinterpreted the bug. Iain's point is to pick up the dependency via ${python3:Depends} rather than explicitly.

Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1890561] Re: Explicit dependency on python3-infinity isn't needed

On Mon, Aug 10, 2020 at 02:38:59PM -0000, Corey Bryant wrote:
> I think I misinterpreted the bug. Iain's point is to pick up the
> dependency via ${python3:Depends} rather than explicitly.

You got it :>

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package intervals - 0.9.0-0ubuntu2

---------------
intervals (0.9.0-0ubuntu2) groovy; urgency=medium

  * d/control: Remove explicit python3-infinity dependency (LP: #1890561).

 -- Chris MacNaughton <email address hidden> Thu, 06 Aug 2020 12:02:05 +0000

Changed in intervals (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.